From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752368AbdEDL6i (ORCPT <rfc822;w@1wt.eu>);
        Thu, 4 May 2017 07:58:38 -0400
Received: from slow1-d.mail.gandi.net ([217.70.178.86]:42860 "EHLO
        slow1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751264AbdEDL6b (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 4 May 2017 07:58:31 -0400
X-Originating-IP: 83.155.44.161
Message-ID: <1493897416.22420.36.camel@hadess.net>
Subject: Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as
 conditional
From: Bastien Nocera <hadess@hadess.net>
To: Justin Vreeland <justin@jvreeland.com>, gregkh@linuxfoundation.org,
        Larry.Finger@lwfinger.net
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Thu, 04 May 2017 13:30:16 +0200
In-Reply-To: <20170502005254.10749-5-justin@jvreeland.com>
References: <20170502005254.10749-1-justin@jvreeland.com>
         <20170502005254.10749-5-justin@jvreeland.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.24.1 (3.24.1-1.fc26) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote:
> Ensure checkpatch compliance
> 
> > Signed-off-by: Justin Vreeland <justin@jvreeland.com>
> ---
> v2:
>   - Added commit message
>   - Fixed overly long lines
> 
>  drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 18 ++++++++----------
>  drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 12 ++++++------
>  drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c  |  9 ++++-----
>  3 files changed, 18 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> index 28d1a229c3a6..21ec890fd60c 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
> @@ -385,8 +385,7 @@ s32 PHY_MACConfig8723B(struct adapter *Adapter)
> >  	/*  Config MAC */
> >  	/*  */
> >  	rtStatus = phy_ConfigMACWithParaFile(Adapter, pszMACRegFile);
> > -	if (rtStatus == _FAIL)
> > -	{
> > +	if (rtStatus == _FAIL) {
> >  		ODM_ConfigMACWithHeaderFile(&pHalData->odmpriv);
> >  		rtStatus = _SUCCESS;
> >  	}
> @@ -459,8 +458,7 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
> >  		Adapter->registrypriv.RegEnableTxPowerLimit == 1 ||
> >  		(Adapter->registrypriv.RegEnableTxPowerLimit == 2 && pHalData->EEPROMRegulatory == 1)
> >  	) {
> > -		if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter, pszRFTxPwrLmtFile) == _FAIL)
> > -		{
> > +		if (PHY_ConfigRFWithPowerLimitTableParaFile(Adapter, pszRFTxPwrLmtFile) == _FAIL) {
> >  			if (HAL_STATUS_SUCCESS != ODM_ConfigRFWithHeaderFile(&pHalData->odmpriv, CONFIG_RF_TXPWR_LMT, (ODM_RF_RADIO_PATH_E)0))
> >  				rtStatus = _FAIL;
> >  		}
> @@ -474,8 +472,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
> >  	/*  */
> >  	/*  1. Read PHY_REG.TXT BB INIT!! */
> >  	/*  */
> > -	if (phy_ConfigBBWithParaFile(Adapter, pszBBRegFile, CONFIG_BB_PHY_REG) == _FAIL)
> > -	{
> > +	if (phy_ConfigBBWithParaFile(Adapter, pszBBRegFile, CONFIG_BB_PHY_REG) ==
> +		_FAIL) {

This and...

>  		if (HAL_STATUS_SUCCESS != ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, CONFIG_BB_PHY_REG))
> >  			rtStatus = _FAIL;
> >  	}
> @@ -491,8 +489,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
> >  		Adapter->registrypriv.RegEnableTxPowerByRate == 1 ||
> >  		(Adapter->registrypriv.RegEnableTxPowerByRate == 2 && pHalData->EEPROMRegulatory != 2)
> >  	) {
> > -		if (phy_ConfigBBWithPgParaFile(Adapter, pszBBRegPgFile) == _FAIL)
> > -		{
> > +		if (phy_ConfigBBWithPgParaFile(Adapter, pszBBRegPgFile) ==
> > +			_FAIL) {
> >  			if (HAL_STATUS_SUCCESS != ODM_ConfigBBWithHeaderFile(&pHalData->odmpriv, CONFIG_BB_PHY_REG_PG))
> >  				rtStatus = _FAIL;
> >  		}
> @@ -514,8 +512,8 @@ static int phy_BB8723b_Config_ParaFile(struct adapter *Adapter)
> >  	/*  */
> >  	/*  2. Read BB AGC table Initialization */
> >  	/*  */
> > -	if (phy_ConfigBBWithParaFile(Adapter, pszAGCTableFile, CONFIG_BB_AGC_TAB) == _FAIL)
> > -	{
> > +	if (phy_ConfigBBWithParaFile(Adapter, pszAGCTableFile,
> +				     CONFIG_BB_AGC_TAB) == _FAIL) {

...this and the other such changes below are just way ugly, whatever
the coding style says.