From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755950AbdEDTCj (ORCPT ); Thu, 4 May 2017 15:02:39 -0400 Received: from smtprelay0154.hostedemail.com ([216.40.44.154]:41009 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751515AbdEDTC3 (ORCPT ); Thu, 4 May 2017 15:02:29 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:1801:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:4321:4605:5007:9707:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21451:21627:30012:30041:30051:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:17,LUA_SUMMARY:none X-HE-Tag: roof78_4e95580913e4c X-Filterd-Recvd-Size: 1989 Message-ID: <1493924538.22125.43.camel@perches.com> Subject: Re: [net-ipv4] question about arguments position From: Joe Perches To: "Gustavo A. R. Silva" Cc: David Miller , kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 04 May 2017 12:02:18 -0700 In-Reply-To: <20170504140015.Horde.iqqsROVYuFdJnC6P1dMPyBa@gator4166.hostgator.com> References: <20170504110755.Horde.9md-X4baf8TwOEKjGrXkelZ@gator4166.hostgator.com> <20170504.124600.627647229351638856.davem@davemloft.net> <1493920071.22125.37.camel@perches.com> <20170504140015.Horde.iqqsROVYuFdJnC6P1dMPyBa@gator4166.hostgator.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-05-04 at 14:00 -0500, Gustavo A. R. Silva wrote: > Regarding the code comments, what about the following patch: [] > diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c [] > @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct > sk_buff *skb, > nlmsg_flags, unlh, net_admin); > } > > +/* > + * Ignore the position of the arguments req->id.idiag_dport and > + * req->id.idiag_sport in both calls to inet_lookup() and inet6_lookup() > + * functions, once this is a locked in behavior exposed to user space. > + * Changing this will break things for people. > + */ > struct sock *inet_diag_find_one_icsk(struct net *net, > struct inet_hashinfo *hashinfo, > const struct inet_diag_req_v2 *req) > Seems sensible. Thanks.