From: Julia Lawall <Julia.Lawall@lip6.fr>
To: David Woodhouse <dwmw2@infradead.org>
Cc: keescook@chromium.org, kernel-janitors@vger.kernel.org,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/9] mtd: cfi_cmdset_0020: Drop unnecessary static
Date: Thu, 4 May 2017 22:10:46 +0200 [thread overview]
Message-ID: <1493928654-18768-2-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1493928654-18768-1-git-send-email-Julia.Lawall@lip6.fr>
Drop static on a local variable, when the variable is initialized before
any use on every possible execution path through the function. The static
has no benefit, and dropping it reduces the code size.
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>
@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
T x@p;
... when != x
when strict
?x = e;
// </smpl>
The change in code size is indicates by the following output from the size
command.
before:
text data bss dec hex filename
16671 48 16 16735 415f drivers/mtd/chips/cfi_cmdset_0020.o
after:
text data bss dec hex filename
16639 48 8 16695 4137 drivers/mtd/chips/cfi_cmdset_0020.o
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/mtd/chips/cfi_cmdset_0020.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c
index 94d3eb4..7d34296 100644
--- a/drivers/mtd/chips/cfi_cmdset_0020.c
+++ b/drivers/mtd/chips/cfi_cmdset_0020.c
@@ -666,7 +666,7 @@ static int cfi_staa_write_buffers (struct mtd_info *mtd, loff_t to,
size_t totlen = 0, thislen;
int ret = 0;
size_t buflen = 0;
- static char *buffer;
+ char *buffer;
if (!ECCBUF_SIZE) {
/* We should fall back to a general writev implementation.
next prev parent reply other threads:[~2017-05-04 20:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 20:10 [PATCH 0/9] Drop unnecessary static Julia Lawall
2017-05-04 20:10 ` Julia Lawall [this message]
2017-05-11 18:49 ` [PATCH 1/9] mtd: cfi_cmdset_0020: " Brian Norris
2017-05-04 20:10 ` [PATCH 2/9] mtd: physmap_of: " Julia Lawall
2017-05-04 20:10 ` [PATCH 3/9] drbd: " Julia Lawall
2017-05-05 7:19 ` Roland Kammerer
2017-06-27 23:49 ` Kees Cook
2017-06-27 23:58 ` Jens Axboe
2017-05-04 20:10 ` [PATCH 4/9] power: supply: axp20x_usb_power: " Julia Lawall
2017-05-15 13:25 ` Sebastian Reichel
2017-05-04 20:10 ` [PATCH 5/9] mfd: " Julia Lawall
2017-06-27 23:46 ` Kees Cook
2017-07-03 11:42 ` Lee Jones
2017-07-17 11:01 ` Lee Jones
2017-05-04 20:10 ` [PATCH 6/9] regulator: palmas: " Julia Lawall
2017-05-14 10:13 ` Mark Brown
2017-05-15 10:41 ` Julia Lawall
2017-05-15 10:54 ` Mark Brown
2017-05-23 11:24 ` Applied "regulator: palmas: Drop unnecessary static" to the regulator tree Mark Brown
2017-05-04 20:10 ` [PATCH 7/9] iio: hid-sensor-accel-3d: Drop unnecessary static Julia Lawall
2017-05-07 12:57 ` Jonathan Cameron
2017-05-04 20:10 ` [PATCH 8/9] clocksource/drivers/fttmr010: " Julia Lawall
2017-06-27 23:45 ` Kees Cook
2017-05-04 20:10 ` [PATCH 9/9] mfd: max8925-i2c: " Julia Lawall
2017-06-27 23:47 ` Kees Cook
2017-07-03 11:42 ` Lee Jones
2017-07-17 11:00 ` Lee Jones
2017-06-27 23:47 ` [PATCH 0/9] " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493928654-18768-2-git-send-email-Julia.Lawall@lip6.fr \
--to=julia.lawall@lip6.fr \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).