From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752144AbdEFJck (ORCPT <rfc822;w@1wt.eu>);
        Sat, 6 May 2017 05:32:40 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47156 "EHLO
        relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751704AbdEFJcc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 6 May 2017 05:32:32 -0400
X-Originating-IP: 83.155.44.161
Message-ID: <1494063147.22420.57.camel@hadess.net>
Subject: Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as
 conditional
From: Bastien Nocera <hadess@hadess.net>
To: Justin Vreeland <justin@jvreeland.com>, gregkh@linuxfoundation.org,
        Larry.Finger@lwfinger.net
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Sat, 06 May 2017 11:32:27 +0200
In-Reply-To: <87mvarlzu7.fsf@makise.i-did-not-set--mail-host-address--so-tickle-me>
References: <20170502005254.10749-1-justin@jvreeland.com>
         <20170502005254.10749-5-justin@jvreeland.com>
         <1493897416.22420.36.camel@hadess.net>
         <87mvarlzu7.fsf@makise.i-did-not-set--mail-host-address--so-tickle-me>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.24.1 (3.24.1-1.fc26) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2017-05-05 at 16:10 -0600, Justin Vreeland wrote:
> 
<snip>
> Sorry about blank email.
> 
> I'm not 100% happy with it either.  Larry Finger suggested to fix the
> overly long lines so I tried to find a decent way to shorten them.  I
> think the best way would be to change the function names or pull the
> function
> calls out of the if statements.
> 
> If these line breaks aren't a good solution and keeping them over 80
> isn't either I'd
> rather drop this patch from the set if that's okay.

Dropping the sections of this patch that require linefeeds in the
middle of if statements would be fine by me. I don't think that a brace
on the next line is worse than splitting a condition on 2 lines.

Cheers