linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincent Legoll <vincent.legoll@gmail.com>
To: tglx@linutronix.de, linux-kernel@vger.kernel.org
Cc: Vincent Legoll <vincent.legoll@gmail.com>
Subject: [PATCH] genirq: Tell that early_irq_init() is printing the nr of preallocated irqs
Date: Tue,  9 May 2017 10:34:09 +0200	[thread overview]
Message-ID: <1494318849-6733-1-git-send-email-vincent.legoll@gmail.com> (raw)
In-Reply-To: <1494318042-6512-1-git-send-email-vincent.legoll@gmail.com>

The early_irq_init() function was not telling what all the displayed
information is.

- Add some missing whitespace & commas for easier reading
- Tell that the third number is the number of preallocated irqs
  returned by arch_probe_nr_irqs()
- Also cover !CONFIG_SPARSE_IRQ case

Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
 kernel/irq/irqdesc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 00bb0ae..fb53da0 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -480,7 +480,8 @@ int __init early_irq_init(void)
 
 	/* Let arch update nr_irqs and return the nr of preallocated irqs */
 	initcnt = arch_probe_nr_irqs();
-	printk(KERN_INFO "NR_IRQS:%d nr_irqs:%d %d\n", NR_IRQS, nr_irqs, initcnt);
+	printk(KERN_INFO "NR_IRQS: %d, nr_irqs: %d, nr of preallocated irqs: %d\n",
+	       NR_IRQS, nr_irqs, initcnt);
 
 	if (WARN_ON(nr_irqs > IRQ_BITMAP_BITS))
 		nr_irqs = IRQ_BITMAP_BITS;
@@ -516,7 +517,7 @@ int __init early_irq_init(void)
 
 	init_irq_default_affinity();
 
-	printk(KERN_INFO "NR_IRQS:%d\n", NR_IRQS);
+	printk(KERN_INFO "NR_IRQS: %d\n", NR_IRQS);
 
 	desc = irq_desc;
 	count = ARRAY_SIZE(irq_desc);
-- 
2.7.4

  reply	other threads:[~2017-05-09  8:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 10:03 [PATCH] Fix NR_IRQS printk() Vincent Legoll
2017-05-09  7:08 ` Thomas Gleixner
2017-05-09  7:41   ` Vincent Legoll
2017-05-09  8:20     ` [PATCH] genirq: Tell that early_irq_init() is printing the nr of preallocated irqs Vincent Legoll
2017-05-09  8:34       ` Vincent Legoll [this message]
2017-05-26 12:58         ` [tip:irq/core] genirq: Make early_irq_init() print out more informative tip-bot for Vincent Legoll

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494318849-6733-1-git-send-email-vincent.legoll@gmail.com \
    --to=vincent.legoll@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).