From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035AbdEIJsK (ORCPT ); Tue, 9 May 2017 05:48:10 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:34650 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753635AbdEIJsI (ORCPT ); Tue, 9 May 2017 05:48:08 -0400 From: suniel.spartan@gmail.com To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, sunil.m@techveda.org, Suniel Mahesh Subject: [PATCH] staging: rtl8192u: Fix type mismatch warnings reported by sparse Date: Tue, 9 May 2017 15:17:56 +0530 Message-Id: <1494323276-6419-1-git-send-email-suniel.spartan@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suniel Mahesh The function Mk16_le() is calling le16_to_cpu() internally. le16_to_cpu() takes an argument of type (__le *) but the argument passed is of type (u16 *). Fixed it by passing the correct argument type. Signed-off-by: Suniel Mahesh --- .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c index 5039172..11ddf30 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c @@ -172,7 +172,7 @@ static inline u16 Mk16(u8 hi, u8 lo) } -static inline u16 Mk16_le(u16 *v) +static inline u16 Mk16_le(__le16 *v) { return le16_to_cpu(*v); } @@ -264,15 +264,15 @@ static void tkip_mixing_phase2(u8 *WEPSeed, const u8 *TK, const u16 *TTAK, PPK[5] = TTAK[4] + IV16; /* Step 2 - 96-bit bijective mixing using S-box */ - PPK[0] += _S_(PPK[5] ^ Mk16_le((u16 *) &TK[0])); - PPK[1] += _S_(PPK[0] ^ Mk16_le((u16 *) &TK[2])); - PPK[2] += _S_(PPK[1] ^ Mk16_le((u16 *) &TK[4])); - PPK[3] += _S_(PPK[2] ^ Mk16_le((u16 *) &TK[6])); - PPK[4] += _S_(PPK[3] ^ Mk16_le((u16 *) &TK[8])); - PPK[5] += _S_(PPK[4] ^ Mk16_le((u16 *) &TK[10])); - - PPK[0] += RotR1(PPK[5] ^ Mk16_le((u16 *) &TK[12])); - PPK[1] += RotR1(PPK[0] ^ Mk16_le((u16 *) &TK[14])); + PPK[0] += _S_(PPK[5] ^ Mk16_le((__le16 *)&TK[0])); + PPK[1] += _S_(PPK[0] ^ Mk16_le((__le16 *)&TK[2])); + PPK[2] += _S_(PPK[1] ^ Mk16_le((__le16 *)&TK[4])); + PPK[3] += _S_(PPK[2] ^ Mk16_le((__le16 *)&TK[6])); + PPK[4] += _S_(PPK[3] ^ Mk16_le((__le16 *)&TK[8])); + PPK[5] += _S_(PPK[4] ^ Mk16_le((__le16 *)&TK[10])); + + PPK[0] += RotR1(PPK[5] ^ Mk16_le((__le16 *)&TK[12])); + PPK[1] += RotR1(PPK[0] ^ Mk16_le((__le16 *)&TK[14])); PPK[2] += RotR1(PPK[1]); PPK[3] += RotR1(PPK[2]); PPK[4] += RotR1(PPK[3]); @@ -285,7 +285,7 @@ static void tkip_mixing_phase2(u8 *WEPSeed, const u8 *TK, const u16 *TTAK, WEPSeed[0] = Hi8(IV16); WEPSeed[1] = (Hi8(IV16) | 0x20) & 0x7F; WEPSeed[2] = Lo8(IV16); - WEPSeed[3] = Lo8((PPK[5] ^ Mk16_le((u16 *) &TK[0])) >> 1); + WEPSeed[3] = Lo8((PPK[5] ^ Mk16_le((__le16 *)&TK[0])) >> 1); #ifdef __BIG_ENDIAN { -- 1.9.1