From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH v3 0/7] perf config: Bugfixes & Refactoring
Date: Tue, 9 May 2017 20:04:34 +0900 [thread overview]
Message-ID: <1494327874-25012-1-git-send-email-treeze.taeung@gmail.com> (raw)
Hi all,
This is simple patchset for perf-config
to fix small bugs and refactor code.
I'd appreciate some feedback on this patchset.
The code is also available at 'config/refactoring-v3' branch on
git://github.com/taeung/linux-perf.git
Thanks,
Taeung
v3:
- fix a bug of no checked 'ret' in the loop in cmd_config() (Arnaldo)
- modify commit log messages to be more clear (Aranaldo)
- return -1 if show_spec_config() cannot show the config
- initialize 'ret' with -1 instead of 0 for more compact code in cmd_config()
- Add a error message when perf_config_set__new() failed in cmd_config()
v2:
- there is no need to consider empty config file (Arnaldo)
Taeung Song (7):
perf config: Handle errors from {show_spec, set}_config() in the loop
perf config: Refactor the code using 'ret' variable in cmd_config()
perf config: Return -1 if show_spec_config() cannot show the config
perf config: Add a error message when perf_config_set__new() failed in
cmd_config()
perf config: Finally write changed configs on config file at a time
perf config: Check whether items are from system config in
set_config()
perf config: Support autogeneration of config file when setting
configs
tools/perf/builtin-config.c | 57 +++++++++++++++++++++++++++++++--------------
tools/perf/util/config.c | 5 +---
2 files changed, 40 insertions(+), 22 deletions(-)
--
2.7.4
reply other threads:[~2017-05-09 11:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494327874-25012-1-git-send-email-treeze.taeung@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).