From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318AbdEQRcP (ORCPT ); Wed, 17 May 2017 13:32:15 -0400 Received: from mail-dm3nam03on0089.outbound.protection.outlook.com ([104.47.41.89]:21900 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751395AbdEQRcM (ORCPT ); Wed, 17 May 2017 13:32:12 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Message-ID: <1495042325.26925.15.camel@nxp.com> Subject: Re: [PATCH linux-next v2 1/1] spi: imx: dynamic burst length adjust for PIO mode From: Leonard Crestez To: CC: , , Mark Brown , Octavian Purdila , "Fabio Estevam" Date: Wed, 17 May 2017 20:32:05 +0300 In-Reply-To: <1493634704-3545-2-git-send-email-jiada_wang@mentor.com> References: <1493634704-3545-1-git-send-email-jiada_wang@mentor.com> <1493634704-3545-2-git-send-email-jiada_wang@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131395159285230845;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39410400002)(39840400002)(39860400002)(39450400003)(39850400002)(39400400002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(377424004)(199003)(24454002)(189002)(9170700003)(76176999)(50986999)(85426001)(33646002)(45080400002)(575784001)(8936002)(110136004)(4326008)(38730400002)(104016004)(2351001)(50226002)(106466001)(2906002)(86362001)(105606002)(229853002)(8656002)(2950100002)(50466002)(6246003)(2870700001)(8676002)(77096006)(5890100001)(5820100001)(305945005)(498600001)(23676002)(47776003)(36756003)(81166006)(356003)(53936002)(189998001)(5660300001)(6916009)(54906002)(81156014)(103116003)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR0301MB0897;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD006;1:cLGPl+8G3+7EzaU8dvzbn2/Xk0JMLr4GMOyUdzC8upoTJIJoqoBSC6TB0hz7kUq0VjD4KvyK7WRxnU88zQFXI+LbCvuCafXA5SyJ8MJTE9XRLdwKYsK3TuqRE+VTmbkRl3fbBEOtBoOjUW2rGst86SELrqRwanVAMWtzXJGL9TAI7UI9DpETAIoKv/M9SCMYKvb5IkavP/Tkb80o0orAZqUlOZtrWXFfy5wfAy2cv4vw+k7DTao7VJrWYQgKwPSklKE3gixE1hoCJsDvldomjcfXxAzSnHslm7nqqph5h3s3lkUOn5/jaYq2Px0eqADzjxMAdWbEPTIfbQqXPkarEGj+xD31JcF3AwNF8D7y77lAJ4R3gUllRIzJ5QIog2gH6nHeb21hum7jdRaxJNE4m1y5U8itRpnpLSFC9dFFBn5mgI9QUgnEOGai50HoKJApJ8Rn21mlRlLMAkHUWUCur5nkv5RpuahTTKHdIa/9MX+yO/Xn4RUQq8m9ZfUxNKuSS7HNpx+ottv0xAc0L43IIPnFmOZy2kSYrYauT5/TphnhAOLxSmDj/0VQ00IldV7iZacfqPXcNMXJSYWMbvDMSakrXT+i1OjLpwk68VM2RoBF8HlgWqTMT474BhkrMbz9/dRi5W36++P11BIDDH7jRl9HpgvIpXpRoOUC5tYcke/Gbx6B2lLEw9ePNZF5hh0xMdXj8MmP8cPfWkIJa1SSlckZyRrtqwJtGxxuQCASEj8= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PR0301MB0897: X-MS-Office365-Filtering-Correlation-Id: fec965cf-355f-4003-ecfd-08d49d4aa4dd X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:BN3PR0301MB0897; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0897;3:vL4BOUZfGZmq1hAL1IxcQ0EhTjamfQ68xW48nofQISpqRa7Z4LQsZJi9jG+y+YfL+s99B9aAYG/5QZS36A8p56ehsufy4EsC1fooSGoUar6gIATFTSDgT9pyjt5Wd6xmRYWrDPRthuyf1ByRr8b+uIsm2d+IzTzcXay6sCqylsMJqhgFv1HYgUth+um+BqLfo0D2nfuYUkCwIAIgH551BT0Q1s0pqu0Ej55009dqIKqrrLEUdoPr5c9M+yHPv2pOm21RFHHxQ/1gLgaXKlsaRpsk9coD0MXOv2YVrb5zFwqfJAt6ZX50p8o6zZEfVtlu7WsxnWx5gEyGmdpQsUExniXSFdRz+uFtrLZFAODg1OWFVW75uRvYzGKfwW2nt40G95Z8aO47t4Y6mtVsrICx0pUGB2pWAamwMs5e5Gyr+blKs3I8KV1uAB/gy6FM6v0j;25:LOd5ICqZGfJAXhZoV7/JwAnAdFuIXPpmJi82FQXGqa75XLg4v41oCcAAuemWqKHFDkp7JJRNnmx6bFSldAwDOfAP7ZhikcyA4RFJ+xz4OBiUnXiAbkaZL6iQKzika0oLdYyqcBaIyOku5wedfSqDZRSsZBc6qg35fZOkhg2vj5EUB/OHW/tgnBv9u9aTrJyxMtieEL5T0KoJ+obswU+WTzjl09dt43Csyfuvi3uN8Eqm+D4A/7/LauhYw5UrCTUdUQOBCrPjWfwlMo+AG+VNDGwOM2pKex3Xz+X87X4B0Vux5D3GW0wo4jq/eWHO53XBYh/8JTCUxfuThM6ndW9W+L8YtSJ7XBMH/m9tVYU9fLSzKfyDVyGObYCbd3WrRyf43FAFvUxyK45EwLuABctxv6/ubuHT+Y23lQYLCdfPvykDMFdzah66dJ0d30cHcZ0ZU/AqYXiS5G5Nhgatf/8ILaD/OtuJq7FB6R8oAIUpWVY= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0897;31:b1sBrwNVOPAe3f1zVhcXTvCW0u27YmHm0fBOnYQX1ZqonrUjLcNdsK44hqjC5CocyzhF3lUtzwcsFwZERP/dB9k1tVnCX0NunmIjWId8t9NIhMqSKSxTu8Y1w1U3c2lIdWeY6x5ZYO77D/ht0wV3I4idAj0U72iTO3jJFiK2AHrfuNGCVWpkihiXzlnNqFePf9iJ53U4IXaYJZZl9aiFVu/FFZmPLUmqDS0KqZ3APXceYmVVThqrMf6bCbthLumZCKp6N/dAR3rJ2pxY0vNZdg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(13023025)(13018025)(8121501046)(13024025)(5005006)(13015025)(13017025)(10201501046)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123565025)(20161123561025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123556025)(20161123563025)(20161123559100);SRVR:BN3PR0301MB0897;BCL:0;PCL:0;RULEID:(400006);SRVR:BN3PR0301MB0897; X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0897;4:G6+84wABgdHz1gjt/C0Yi2QjGuFPlnycFY6utXWBqc6PGBzCEQ3eew1MID1kxMHsyUqR1S0YbTbuRjQjQo6e2EsuUSQV+VD+oFYpvvwaVjtnW0C9GgsjIDtrd4ROJXqiPrQbtE8nX/w+w9O21EEh4dFUyHTV1I1Cckqwe4H0p2qs9qWftI0+4FBu06BgGmNgE1BJtdQFd+GgSoLvoRs0FGr9a7zGnX+wAkaLG9PGluwa1aog1trjH1Uex1BeBpTaxiaQ9jmmgjwUL85Hj83T1gRSBsQTO8j9aHc3w+SecJ5FskBzDB5Xfl7/qYPDEI/pCmnH6Nk8mS5aq/ogatsg8fhQH/29Ip+Ewp2XRouFIJIes+TSFcaphA4S5XCx/r1Li45D5B7onP2J3imucZyoiCUrF7pGVdzzfXbHZWwvyfhKObBo2oiaPTOfYaYr0dgWZxYorwqMWspmMZmJU/21c2Pw5OzDfxvomFosVN2VdvZF8sBnpLUc2pGoccR52cJcYBM6uZ4OtwlSvSYulycJ4rCIZl4sCwn2m3OmcYJCL+eny+Pv935vu3U5gpfpDauc24EGrBAS4SwA3rDomy+WPJRr8XI/yGzDsrWyR1z+g7qI9qQUxC+G3Q+uXGehSAOFnhRQjv40pbnRrcpN882nG4DEFg6UVvU7UDqarxj6E3NElKXTPoiiU8cOVD/jU2ico0yEiGBCMWe9CAWVBJhMk9/2sOcUHeDKIeyYiMfRwAVv+dopPjbb8delE72hfCjcTQ9nnA14BynihVUvA/IoCzhybsbgjalo/n/CLGOCgjrXDL1CDXX56TjffyDgoNr9BEbVUfimt1jmEG8RzT0NQSvquz4npR8GpE3pEmqDEPLfb8cNx1TN7+uU7nhw3nd3i2WdwniO6ScDJS6kyzNb2OYkRmCW+MlZ4+XwNmW65Ak= X-Forefront-PRVS: 0310C78181 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzMDFNQjA4OTc7MjM6K3JwbUFEbVIxeHo5TFVtV05BbGwyN3Yx?= =?utf-8?B?ejJDWEl6MitKd1hCck5zeGxWbnQvcGtBbVF0UzZEMlpyUXFhTlJsR05iRTFL?= =?utf-8?B?a2dIU1ZtenpWOUdBMFRCemR0NS9DeVhTWjdOV1VnMTUyNWFOR2VQcGNBWjV5?= =?utf-8?B?UUtaUjVzUVFIZktMUFlWaXViWnQ5cXZhNDVobGJMdTdwejNxMk4wTmZMWDUz?= =?utf-8?B?TUZXeVBxMFEvUHN2bWNnRm9vWkRRTmdtUG9YM3pWdStyVUFSSHVtcFh3aTZN?= =?utf-8?B?V3Q0R29NbXBYV3lORExwYXdJMjJJZEFmREdLU2N6R2UvYnZFTDJtYUdvbG5E?= =?utf-8?B?MzRGakJhcmhvUmtLRU1ZOGdXSXh5emlZQ2tETFJQeldSN0NmZ2JSM3JqWDdN?= =?utf-8?B?SCtUSjk1TWdvZm5MWDRkSnRrZUZjZngremlRM1hTL3EwN1VpZDEyaDdHRkd4?= =?utf-8?B?NXd0enVjWmtuWEhKMGhsZ1lTOWZMYUNHOElIa0FSNWZFU0ZsNDZOUlRadVJU?= =?utf-8?B?OTlhb0l6K2Z6RktkV2orUFU3ZGF3dWF1cjJqQ1lOT1MralFtV0FTZFpNWld5?= =?utf-8?B?bkp3SjdQTk9BTTlyUkdVUEdGQUtVckRiQVZsem5TZEtMYWM0Sm5ON0hBTVFy?= =?utf-8?B?N1VmSWVyQmhzck0zVTN6T1NBVmdKMDFMZ1NYUkc4c1F0cE5NSUNJZnZIUmdZ?= =?utf-8?B?ZXFvZGRkRndEbTd2QUZialk1TllpYlA4ZTVGWEM0c295eVBEaktGVkx3dENz?= =?utf-8?B?WTl3QXJraEVDb0VveSt5ZHpKNzRqMldlRG91RW04V3p3L2U0aGhuVkg1bCtR?= =?utf-8?B?TVpKZ2JSK0tkZGljd29hUFpGdXpRN2hTUi9ncmRyN0hhK1dzQTF5WHF6ZjhR?= =?utf-8?B?TW5HSXpZWGFUcDZETC9qK3ZWZWtzb01ndHF2eTM4OVl5UnJoaFlaWG1PQXBJ?= =?utf-8?B?aTNTTEdIMTFkTzdYZkF3WWlzUlBJYmZQMllsREZQVlBPYUhiY09rUUVBV2Y4?= =?utf-8?B?MHNmOG1KSzAzODhybzM3QkxTbTA3ckd2QWlySExtVnk2UnY3c3VnSENVN00r?= =?utf-8?B?UHQ2MDRFZS8yRjhIM2hrS1JxYkxBbVJuZ0ROcHdERUVVVmNEUGQ5SlgxWDdL?= =?utf-8?B?bEhrUDRqYW0xZmZTbDBnRm5iYlU3WkJtd0hnRVlzU3JhK2Flb3NZbDcrZFJE?= =?utf-8?B?N3RRazVIN1dnc3hyTll2SDFhcmlsZ3RBd1pDTzlPV3g4SlJCbHZFTysremo2?= =?utf-8?B?aUJxRThVQURuYUdweU1sY3lCeHVuRWliem4vL25DMkc4Q0NCTHlXMlNVY0FR?= =?utf-8?B?eTErZ1V6L2dDc2Ezb1V5MEx0Q29pVCtreTdabk5Rb3I1RHR4RFhxdU54elEz?= =?utf-8?B?MnZ5SlBIaGFnUXNSd2VxWVFVQS9BK1MwN3IxOTh2R1h4QlhBUHQ3Z2p6L1dn?= =?utf-8?B?QUJrUGxSVzloSDNGeDVDbm9IemNiSzkvUXR2Z3QxU2FaV0laakhyWEs5N2hu?= =?utf-8?B?S1lMZ2FrZGNzLzloc1dxZHI0WlJDbG4wUXRkS3JlclBBcFg3djVTUjBqWGFO?= =?utf-8?B?RWRoWmtDUUV1K1AvUm1RMEtvdllLWGs0ZFZmNVZRTEhpK0FRQ2NNckc5ZlJD?= =?utf-8?B?aU1yQXpnVFV0Mmd0RSt3QUwxaWM0U1hTRk14MXFIb2h0dnBlRG0yVmRBZkly?= =?utf-8?B?U05tKzh3d0wvdHI4THJ5WEdPY05PVEtVSG5DZlNUVWNHTjRzU2IvMnVqWXFu?= =?utf-8?B?OWphTncwR3AyWjhmb0RIMjZ4VDFsT0EyU1NFcFZMekErVHJ2blRLc0x0ZllF?= =?utf-8?B?cXJ6Z1BKK0djSk8yVVQzOE1pYm9QS1J4a0lSbnhnR0lSQmUyakFMRDZCeTZK?= =?utf-8?B?dlN2ZW1wQ01KQWFjRDdrR2pCcjJnZllLOHhKOEZyeUtpZmZ5SCt0TWtURFNx?= =?utf-8?B?Z2FGSzFEWGV6TllGTFVGNkFtQTRaejRSRXJhWU1HTHlxdERmanhyV0VGZzZ4?= =?utf-8?Q?4iyYSeRE?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0897;6:3UXX1mPbbGGeV3ekXS2a/m3+dcsVaorxjeX1e/60y/lk4Zz0O+rQEgxvA4x35WIRmdqkBaQ1/B4FmOKMUMIdZWAMEjh1dhurcVUNIKy5FzAx3xLUxkIGoTI1Hyz996XNuaqKvdX1RHXBAQCzQrFpdTkM1dIxawUT50OFNC9wRX9plpsWtxn2Lfpt90m5iM/iErhzsuqluTrOGOSkVsBxjSsMHyK+Renn13sIUke/5K8AfWaM39FbJA6sQUY9vU0dFET77yZ0B3gH50Sgeg/2lZrtGY/9qNamXHyA5JYlrb4v3pxtG2Tf/k5jtAj1HIRb2b8g9e1pgKaF+dZUDGm70KDxme7ES23U3+wADwo5kc0XHu6G/chxa8LxPtnLXXaZdOhNQpnNkZcvJmekLZnnvUfI7jKvg/IZig3tBy0XGtdEhLvaAiOA1tX0OWrpX3F0nVQsLqckVDajlmSejX5/tf6m3iyeuSASCvujTGuRd+vDsl+cWcrNQz6eVX0VUO9/iceUg8PMiy0xPXSVSQAHww==;5:vTHrrdLSHGtUAZmUTo53c1H5QrThusjAB8u0Xaqjvtm23GQFMw222NJJ8DnG9Zl/FABWX5T8q8WyUG61weGsg5bfrLMYkqhwG9E9x2nfl5aat0chZQic3991ubRTTTtvPdin8DNdKyRfk83zJ3gmkroQKURg3J7SqTviGObc17vg7tsE8kEWuwEswgQhHbdw;24:hCwX1nHiqVukjOztDR/Af74BBSJm55i6nmb/3D4bPgTZe03QQfyuaKhKHSSl3aazaSFPYL2bhJz2Dlywc2wzo743wRhRJR0Cp2KlwrlnxoE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB0897;7:5s/XYkz5R1oiFXgITM6+sUcQ/UjD3ZtwJ7Y1YjTVvsGOUdsFCW5hKEZEZktM9ANGgnbdgG4d+DEFbETAD1K6LJvPguMZ/6Odyp890el0ErwhPT7OttEIMvcbWk1jCH+uEb0b2qkWZCx0KP/8LBH9/7qCJrlXhT6NQGMVCrzgZy1NuWN7vXNHekYN8Aew8wz1IQ7+mb0smcaqCiJ1fEIDTIGS+s9VvFn0vUz0BAezZvyt5PKsnvDDM3K4AFsa5gev7UKvPydHsHantJdUGMkVnONK1e49FjwlhSr9AbJknpaXEaEPZ+5yRake+ytQ8YlXHkOfOeTwfl79Ph+rYtnlag== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2017 17:32:08.3670 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB0897 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-05-01 at 03:31 -0700, jiada_wang@mentor.com wrote: > From: Jiada Wang > > previously burst length (BURST_LENGTH) is always set to equal > to bits_per_word, causes a 10us gap between each word in > transfer, which significantly affects performance. > > This patch uses 32 bits transfer to simulate lower bits transfer, > and adjusts burst length runtimely to use biggeest burst length > as possible to reduce the gaps in transfer for PIO mode. > > Signed-off-by: Jiada Wang > --- >  drivers/spi/spi-imx.c | 157 +++++++++++++++++++++++++++++++++++++++++++++++--- >  1 file changed, 149 insertions(+), 8 deletions(-) This patch made it's way to linux-next and broke boot on imx6dl- sabreauto and imx6sl-evk boards (but others work). The crashes look like this: [    1.442384] spi_imx 2008000.ecspi: dma setup error -19, use pio [    1.452930] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [    1.461320] pgd = c0004000 [    1.464078] [00000000] *pgd=00000000 [    1.467821] Internal error: Oops: 5 [#1] SMP ARM [    1.472464] Modules linked in: [    1.475558] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.12.0-rc1-00001-g8d4a6ca #90 [    1.483234] Hardware name: Freescale i.MX6 SoloLite (Device Tree) [    1.489349] task: ef058000 task.stack: ef054000 [    1.493926] PC is at spi_imx_transfer+0x2d8/0x364 [    1.498659] LR is at spi_bitbang_transfer_one+0x80/0xa0 [    1.503910] pc : []    lr : []    psr: 20000013 [    1.503910] sp : ef0558b0  ip : ef0558e0  fp : ef0558dc [    1.515412] r10: ee938a98  r9 : ef340c28  r8 : ee938800 [    1.520658] r7 : ee938800  r6 : ef340800  r5 : ef055aac  r4 : ef340ce0 [    1.527206] r3 : 00000001  r2 : fffffffc  r1 : 00000000  r0 : ee938800 [    1.533757] Flags: nzCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none [    1.540913] Control: 10c5387d  Table: 8000404a  DAC: 00000051 [    1.546680] Process swapper/0 (pid: 1, stack limit = 0xef054210) [    1.552709] Stack: (0xef0558b0 to 0xef056000) [    1.557093] 58a0:                                     c05f5cfc c05f587c 00000000 ef055aac [    1.565301] 58c0: ef340800 ef340ce0 ee938800 ef340c28 ef055904 ef0558e0 c05f3440 c05f5f98 [    1.573509] 58e0: ee938800 ef055aac ef340800 ef055a38 00000000 ef340c28 ef055944 ef055908 [    1.581714] 5900: c05f21c0 c05f33cc ee938800 00000000 ef05592c ef055920 c0496c3c 00000000 [    1.589920] 5920: ef340800 ef055a38 00000000 00000000 ee938a98 00000000 ef055984 ef055948 [    1.598126] 5940: c05f28c8 c05f2118 ef055a38 ef340800 ef05596c ef340a80 c016d518 ef055990 [    1.606332] 5960: ee938800 ef055a38 ef340800 ef340c28 ee938a98 00000000 ef055a14 ef055988 [    1.614537] 5980: c05f2bf0 c05f24e0 ef340ac4 60000013 00000000 00000000 dead4ead ffffffff [    1.622743] 59a0: ffffffff c1669b70 00000000 00000000 c0be1d7c ef0559b4 ef0559b4 00000000 [    1.630948] 59c0: 00000000 dead4ead ffffffff ffffffff c1669b70 00000000 00000000 c0be1d7c [    1.639153] 59e0: ef0559b4 ef0559b4 ee938800 ee938800 ef055a38 ef055a38 00000006 c1669b3c [    1.647359] 5a00: ee938800 ef055b27 ef055a2c ef055a18 c05f2c34 c05f2a30 ef0c8bc1 ef0c8bc0 [    1.655565] 5a20: ef055b14 ef055a30 c05f2d20 c05f2c10 ef055a54 ef055b4a ef055aa4 ef055ae0 [    1.663770] 5a40: ee938800 00000000 c05f0640 ef055990 00000007 00000001 ffffff8d ef055a5c [    1.671975] 5a60: ef055a5c 00000000 ef055a68 ef055a68 ef0c8bc0 00000000 00000001 00000000 [    1.680179] 5a80: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000802 [    1.688384] 5aa0: 01312d00 ef055ae0 ef055a38 00000000 ef0c8bc1 00000006 00000000 00000000 [    1.696588] 5ac0: 00000000 00000000 00000000 00000000 00000000 00000000 00000810 01312d00 [    1.704794] 5ae0: ef055a38 ef055aa4 ef058000 c05c298c ee938800 ee938a70 ee938800 ef341018 [    1.712999] 5b00: ef7e6f0c c0a669a4 ef055b3c ef055b18 c05c29c4 c05f2c58 00000006 00000000 [    1.721206] 5b20: ef055b4c 9f055b30 c05c298c c0a669a4 ef055b74 ef055b40 c05d4970 c05c2998 [    1.729412] 5b40: ef055b5c ef055b50 c016d518 c016d320 ef055b74 ef341018 c0a669a4 ee938a70 [    1.737617] 5b60: ee938800 00000000 ef055bb4 ef055b78 c05d5634 c05d4954 ef341010 ef341050 [    1.745822] 5b80: 00000000 ef341018 00000000 ef341010 ee938a70 00000000 ef341018 00000000 [    1.754027] 5ba0: 00000000 00000000 ef055be4 ef055bb8 c05c2f88 c05d5300 c0e3ed44 00000000 [    1.762232] 5bc0: 00000000 ee938800 c0e3ed34 00000000 c0e3ed44 00000000 ef055c04 ef055be8 [    1.770437] 5be0: c05f0070 c05c2e78 ee938800 c166767c 00000000 c0e3ed44 ef055c2c ef055c08 [    1.778643] 5c00: c053ed28 c05efff8 c0e3ed44 ef055c78 ee938800 00000001 00000000 c1667638 [    1.786848] 5c20: ef055c4c ef055c30 c053ef1c c053eacc 00000000 ef055c78 c053ee7c 00000001 [    1.795055] 5c40: ef055c74 ef055c50 c053d050 c053ee88 ef0c0ed4 ee8adfd4 ee938800 ee938800 [    1.803261] 5c60: ee938834 c0e403a4 ef055c9c ef055c78 c053e998 c053cff0 ee938800 00000001 [    1.811466] 5c80: ee938808 ee938800 c0e403a4 00000000 ef055cac ef055ca0 c053ef9c c053e8ec [    1.819671] 5ca0: ef055ccc ef055cb0 c053df88 c053ef94 ee938808 ef340800 ee938800 00000000 [    1.827877] 5cc0: ef055d0c ef055cd0 c053c0ec c053df04 c05f07d8 c0450bd8 00000000 ee938800 [    1.836083] 5ce0: ef055d0c ee938800 ef340800 00000000 ef0f5010 00000000 ef340800 00000000 [    1.844288] 5d00: ef055d2c ef055d10 c05f1044 c053bd28 ef7e6f0c ef7e6f5c ee938800 00000001 [    1.852493] 5d20: ef055d74 ef055d30 c05f18f0 c05f0fb8 00000000 c04289b8 ef055d64 ef0f5010 [    1.860699] 5d40: c040f6f4 01312d00 ef055d74 ef340800 ef340ce0 ef340a60 ffffffed ef0f5010 [    1.868905] 5d60: ef0f5000 ee8d4f80 ef055d8c ef055d78 c05f3508 c05f14b8 ef340ce0 ef340800 [    1.877111] 5d80: ef055ddc ef055d90 c05f6700 c05f346c 00000000 ef0c5840 ef340ce0 00000002 [    1.885316] 5da0: c1667638 ef0f5010 00000000 00000000 c0e40ccc ef0f5010 fffffffe c0e40ccc [    1.893522] 5dc0: fffffdfb 00000000 00000000 c0d00618 ef055dfc ef055de0 c05409cc c05f6394 [    1.901728] 5de0: ef0f5010 c166767c 00000000 c0e40ccc ef055e24 ef055e00 c053ed28 c0540980 [    1.909934] 5e00: ef0f5010 c0e40ccc ef0f5044 00000000 00000000 c0d5f858 ef055e44 ef055e28 [    1.918139] 5e20: c053ee78 c053eacc 00000000 c0e40ccc c053edb0 00000000 ef055e6c ef055e48 [    1.926345] 5e40: c053cf8c c053edbc ef009aa4 ef0bbcd0 ef009ad4 c0e40ccc ee8d7300 c0e3b068 [    1.934551] 5e60: ef055e7c ef055e70 c053e680 c053cf24 ef055ea4 ef055e80 c053e1a4 c053e66c [    1.942756] 5e80: c0c4a470 ef055e90 c0e40ccc ffffe000 c0d5f850 c0cdd42c ef055ebc ef055ea8 [    1.950963] 5ea0: c053f814 c053e0ac c0d47a14 ffffe000 ef055ecc ef055ec0 c054091c c053f7a0 [    1.959168] 5ec0: ef055edc ef055ed0 c0d47a2c c05408f0 ef055f4c ef055ee0 c0101934 c0d47a20 [    1.967374] 5ee0: c0d00634 c04157f0 c0cde600 000000ef ef055f4c ef055f00 c0147468 c0d00624 [    1.975578] 5f00: 00000000 00000006 00000006 00000000 c0cdd42c c0c53d64 efffcc3a efffcc42 [    1.983784] 5f20: c0e179e4 00000006 c0e7c000 c0d70ee8 c0e7c000 c0d5f850 c0cdd42c 000000ef [    1.991990] 5f40: ef055f94 ef055f50 c0d00e74 c01018fc 00000006 00000006 00000000 c0d00618 [    2.000194] 5f60: 96fb16ef 00000007 c09af0d8 00000000 c09af0d8 00000000 00000000 00000000 [    2.008401] 5f80: 00000000 00000000 ef055fac ef055f98 c09af0e8 c0d00d54 00000000 c09af0d8 [    2.016605] 5fa0: 00000000 ef055fb0 c0107d30 c09af0e4 00000000 00000000 00000000 00000000 [    2.024810] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [    2.033015] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 def4d473 a64cea87 [    2.041206] Backtrace: [    2.043707] [] (spi_imx_transfer) from [] (spi_bitbang_transfer_one+0x80/0xa0) [    2.052699]  r9:ef340c28 r8:ee938800 r7:ef340ce0 r6:ef340800 r5:ef055aac r4:00000000 [    2.060479] [] (spi_bitbang_transfer_one) from [] (spi_transfer_one_message+0xb4/0x3c8) [    2.070251]  r9:ef340c28 r8:00000000 r7:ef055a38 r6:ef340800 r5:ef055aac r4:ee938800 [    2.078029] [] (spi_transfer_one_message) from [] (__spi_pump_messages+0x3f4/0x534) [    2.087452]  r10:00000000 r9:ee938a98 r8:00000000 r7:00000000 r6:ef055a38 r5:ef340800 [    2.095301]  r4:00000000 [    2.097869] [] (__spi_pump_messages) from [] (__spi_sync+0x1cc/0x1e0) [    2.106079]  r10:00000000 r9:ee938a98 r8:ef340c28 r7:ef340800 r6:ef055a38 r5:ee938800 [    2.113927]  r4:ef055990 [    2.116492] [] (__spi_sync) from [] (spi_sync+0x30/0x48) [    2.123570]  r10:ef055b27 r9:ee938800 r8:c1669b3c r7:00000006 r6:ef055a38 r5:ef055a38 [    2.131418]  r4:ee938800 [    2.133985] [] (spi_sync) from [] (spi_write_then_read+0xd4/0x184) [    2.141924]  r5:ef0c8bc0 r4:ef0c8bc1 [    2.145534] [] (spi_write_then_read) from [] (m25p80_read_reg+0x38/0x70) [    2.154002]  r10:c0a669a4 r9:ef7e6f0c r8:ef341018 r7:ee938800 r6:ee938a70 r5:ee938800 [    2.161851]  r4:c05c298c [    2.164415] [] (m25p80_read_reg) from [] (spi_nor_read_id+0x28/0xc0) [    2.172527]  r5:c0a669a4 r4:c05c298c [    2.176132] [] (spi_nor_read_id) from [] (spi_nor_scan+0x340/0x8f8) [    2.184164]  r8:00000000 r7:ee938800 r6:ee938a70 r5:c0a669a4 r4:ef341018 [    2.190894] [] (spi_nor_scan) from [] (m25p_probe+0x11c/0x168) [    2.198494]  r10:00000000 r9:00000000 r8:00000000 r7:ef341018 r6:00000000 r5:ee938a70 [    2.206342]  r4:ef341010 [    2.208907] [] (m25p_probe) from [] (spi_drv_probe+0x84/0xb4) [    2.216418]  r8:00000000 r7:c0e3ed44 r6:00000000 r5:c0e3ed34 r4:ee938800 [    2.223162] [] (spi_drv_probe) from [] (driver_probe_device+0x268/0x2f0) [    2.231626]  r7:c0e3ed44 r6:00000000 r5:c166767c r4:ee938800 [    2.237321] [] (driver_probe_device) from [] (__device_attach_driver+0xa0/0xd4) [    2.246396]  r9:c1667638 r8:00000000 r7:00000001 r6:ee938800 r5:ef055c78 r4:c0e3ed44 [    2.254174] [] (__device_attach_driver) from [] (bus_for_each_drv+0x6c/0xa0) [    2.262984]  r7:00000001 r6:c053ee7c r5:ef055c78 r4:00000000 [    2.268675] [] (bus_for_each_drv) from [] (__device_attach+0xb8/0x120) [    2.276963]  r6:c0e403a4 r5:ee938834 r4:ee938800 [    2.281614] [] (__device_attach) from [] (device_initial_probe+0x14/0x18) [    2.290164]  r7:00000000 r6:c0e403a4 r5:ee938800 r4:ee938808 [    2.295857] [] (device_initial_probe) from [] (bus_probe_device+0x90/0x98) [    2.304501] [] (bus_probe_device) from [] (device_add+0x3d0/0x584) [    2.312443]  r7:00000000 r6:ee938800 r5:ef340800 r4:ee938808 [    2.318134] [] (device_add) from [] (spi_add_device+0x98/0x13c) [    2.325821]  r10:00000000 r9:ef340800 r8:00000000 r7:ef0f5010 r6:00000000 r5:ef340800 [    2.333669]  r4:ee938800 [    2.336235] [] (spi_add_device) from [] (spi_register_master+0x444/0x7a4) [    2.344786]  r7:00000001 r6:ee938800 r5:ef7e6f5c r4:ef7e6f0c [    2.350478] [] (spi_register_master) from [] (spi_bitbang_start+0xa8/0x12c) [    2.359207]  r10:ee8d4f80 r9:ef0f5000 r8:ef0f5010 r7:ffffffed r6:ef340a60 r5:ef340ce0 [    2.367055]  r4:ef340800 [    2.369623] [] (spi_bitbang_start) from [] (spi_imx_probe+0x378/0x604) [    2.377909]  r5:ef340800 r4:ef340ce0 [    2.381518] [] (spi_imx_probe) from [] (platform_drv_probe+0x58/0xb8) [    2.389727]  r10:c0d00618 r9:00000000 r8:00000000 r7:fffffdfb r6:c0e40ccc r5:fffffffe [    2.397574]  r4:ef0f5010 [    2.400140] [] (platform_drv_probe) from [] (driver_probe_device+0x268/0x2f0) [    2.409037]  r7:c0e40ccc r6:00000000 r5:c166767c r4:ef0f5010 [    2.414730] [] (driver_probe_device) from [] (__driver_attach+0xc8/0xcc) [    2.423197]  r9:c0d5f858 r8:00000000 r7:00000000 r6:ef0f5044 r5:c0e40ccc r4:ef0f5010 [    2.430973] [] (__driver_attach) from [] (bus_for_each_dev+0x74/0xa8) [    2.439175]  r7:00000000 r6:c053edb0 r5:c0e40ccc r4:00000000 [    2.444867] [] (bus_for_each_dev) from [] (driver_attach+0x20/0x28) [    2.452894]  r6:c0e3b068 r5:ee8d7300 r4:c0e40ccc [    2.457544] [] (driver_attach) from [] (bus_add_driver+0x104/0x214) [    2.465582] [] (bus_add_driver) from [] (driver_register+0x80/0xfc) [    2.473611]  r7:c0cdd42c r6:c0d5f850 r5:ffffe000 r4:c0e40ccc [    2.479302] [] (driver_register) from [] (__platform_driver_register+0x38/0x4c) [    2.488369]  r5:ffffe000 r4:c0d47a14 [    2.491984] [] (__platform_driver_register) from [] (spi_imx_driver_init+0x18/0x20) [    2.501412] [] (spi_imx_driver_init) from [] (do_one_initcall+0x44/0x178) [    2.509977] [] (do_one_initcall) from [] (kernel_init_freeable+0x12c/0x1ec) [    2.518704]  r8:000000ef r7:c0cdd42c r6:c0d5f850 r5:c0e7c000 r4:c0d70ee8 [    2.525441] [] (kernel_init_freeable) from [] (kernel_init+0x10/0x118) [    2.533735]  r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c09af0d8 [    2.541582]  r4:00000000 [    2.544153] [] (kernel_init) from [] (ret_from_fork+0x14/0x24) [    2.551745]  r5:c09af0d8 r4:00000000 [    2.555349] Code: e1b03123 0affff6a e2422004 e3a01000 (e5923004) [    2.561619] ---[ end trace 5e472bb4310ae461 ]--- [    2.566504] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b [    2.566504] [    2.575695] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b [    2.575695] [    2.604346] random: fast init done This is at commit 8d4a6cad7adb3ddac32cd52635f20e11de11a658 from broonie/spi/topic/imx which has no other patches on top of v4.12-rc1. >>From a very brief investigation it seems this is not handling correctly the cases where spi_transfer->rx_buf or tx_buf are NULL? -- Regards, Leonard