From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
To: Wim Van Sebroeck <wim@iguana.be>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
<esben.haabendal@gmail.com>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
<linux-watchdog@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v5 3/3] watchdog: introduce CONFIG_WATCHDOG_OPEN_TIMEOUT
Date: Mon, 22 May 2017 16:06:39 +0200 [thread overview]
Message-ID: <1495462000-28979-4-git-send-email-rasmus.villemoes@prevas.dk> (raw)
In-Reply-To: <1495462000-28979-1-git-send-email-rasmus.villemoes@prevas.dk>
This allows setting a default value for the watchdog.open_timeout
commandline parameter via Kconfig.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
Documentation/watchdog/watchdog-parameters.txt | 9 +++++----
drivers/watchdog/Kconfig | 9 +++++++++
drivers/watchdog/watchdog_dev.c | 2 +-
3 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/Documentation/watchdog/watchdog-parameters.txt b/Documentation/watchdog/watchdog-parameters.txt
index 4801ec6..6a55a3d 100644
--- a/Documentation/watchdog/watchdog-parameters.txt
+++ b/Documentation/watchdog/watchdog-parameters.txt
@@ -12,10 +12,11 @@ The watchdog core currently understands one parameter,
watchdog.open_timeout. This is the maximum time, in milliseconds, for
which the watchdog framework will take care of pinging a hardware
watchdog until userspace opens the corresponding /dev/watchdogN
-device. A value of 0 (the default) means an infinite timeout. Setting
-this to a non-zero value can be useful to ensure that either userspace
-comes up properly, or the board gets reset and allows fallback logic
-in the bootloader to try something else.
+device. The defalt value is CONFIG_WATCHDOG_OPEN_TIMEOUT. A value of 0
+means an infinite timeout. Setting this to a non-zero value can be
+useful to ensure that either userspace comes up properly, or the board
+gets reset and allows fallback logic in the bootloader to try
+something else.
-------------------------------------------------
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 8b9049d..11946fb 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -52,6 +52,15 @@ config WATCHDOG_SYSFS
Say Y here if you want to enable watchdog device status read through
sysfs attributes.
+config WATCHDOG_OPEN_TIMEOUT
+ int "Timeout value for opening watchdog device"
+ default 0
+ help
+ The maximum time, in milliseconds, for which the watchdog
+ framework takes care of pinging a hardware watchdog. A value
+ of 0 means infinite. The value set here can be overridden by
+ the commandline parameter "watchdog.open_timeout".
+
#
# General Watchdog drivers
#
diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
index c807067..098b9cb 100644
--- a/drivers/watchdog/watchdog_dev.c
+++ b/drivers/watchdog/watchdog_dev.c
@@ -81,7 +81,7 @@ static struct watchdog_core_data *old_wd_data;
static struct workqueue_struct *watchdog_wq;
-static unsigned open_timeout;
+static unsigned open_timeout = CONFIG_WATCHDOG_OPEN_TIMEOUT;
module_param(open_timeout, uint, 0644);
static bool watchdog_past_open_deadline(struct watchdog_core_data *data)
--
2.7.4
next prev parent reply other threads:[~2017-05-22 14:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 14:06 [PATCH v5 0/3] watchdog: allow setting deadline for opening /dev/watchdogN Rasmus Villemoes
2017-05-22 14:06 ` [PATCH v5 1/3] watchdog: introduce watchdog_worker_should_ping helper Rasmus Villemoes
2017-05-25 0:53 ` Guenter Roeck
2017-05-22 14:06 ` [PATCH v5 2/3] watchdog: introduce watchdog.open_timeout commandline parameter Rasmus Villemoes
2017-05-25 0:56 ` Guenter Roeck
2017-05-30 8:00 ` Rasmus Villemoes
2017-05-22 14:06 ` Rasmus Villemoes [this message]
2017-05-22 18:07 ` [PATCH v5 0/3] watchdog: allow setting deadline for opening /dev/watchdogN Alan Cox
2017-05-22 19:44 ` Guenter Roeck
2017-05-23 7:15 ` Rasmus Villemoes
2017-05-24 14:19 ` Esben Haabendal
2017-05-30 8:56 ` [PATCH v6 " Rasmus Villemoes
2017-05-30 8:56 ` [PATCH v6 1/3] watchdog: introduce watchdog_worker_should_ping helper Rasmus Villemoes
2017-05-30 8:56 ` [PATCH v6 2/3] watchdog: introduce watchdog.open_timeout commandline parameter Rasmus Villemoes
2017-07-08 15:12 ` [v6, " Guenter Roeck
2017-05-30 8:56 ` [PATCH v6 3/3] watchdog: introduce CONFIG_WATCHDOG_OPEN_TIMEOUT Rasmus Villemoes
2017-07-08 15:15 ` [v6,3/3] " Guenter Roeck
2017-07-11 15:50 ` Wim Van Sebroeck
2017-06-06 8:08 ` [PATCH v6 0/3] watchdog: allow setting deadline for opening /dev/watchdogN Rasmus Villemoes
2017-06-06 13:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495462000-28979-4-git-send-email-rasmus.villemoes@prevas.dk \
--to=rasmus.villemoes@prevas.dk \
--cc=corbet@lwn.net \
--cc=esben.haabendal@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sebastian.reichel@collabora.co.uk \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).