From: Philipp Zabel <p.zabel@pengutronix.de>
To: Joel Stanley <joel@jms.id.au>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH 1/2] dt-bindings: reset: Add bindings for basic reset controller
Date: Mon, 29 May 2017 11:09:19 +0200 [thread overview]
Message-ID: <1496048959.17695.20.camel@pengutronix.de> (raw)
In-Reply-To: <20170526033214.8081-2-joel@jms.id.au>
Hi Joel,
On Fri, 2017-05-26 at 13:32 +1000, Joel Stanley wrote:
> This adds the bindings documentation for a basic single-register reset
> controller.
>
> The bindings describe a single 32-bit register that contains up to 32
> reset lines, each deasserted by clearing the appropriate bit in the
> register.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> .../devicetree/bindings/reset/reset-basic.txt | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/reset-basic.txt
>
> diff --git a/Documentation/devicetree/bindings/reset/reset-basic.txt b/Documentation/devicetree/bindings/reset/reset-basic.txt
> new file mode 100644
> index 000000000000..7341e04e7904
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/reset-basic.txt
> @@ -0,0 +1,31 @@
> +Basic single-register reset controller
> +======================================
> +
> +This describes a generic reset controller where the reset lines are controlled
> +by single bits within a 32-bit memory location. The memory location is assumed
> +to be part of a syscon regmap.
There are a few more assumptions. First, that the reset line is asserted
by setting the corresponding bits, and that it is deasserted by clearing
them. Further, that the bits are not auto-clearing. And then, that the
same bit can be read back to provide the current reset line status.
> +Reset controller required properties:
> + - compatible: should be "reset-basic"
> + - #reset-cells: must be set to 1
> + - reg: reset register location within regmap
> +
> +Device node required properties:
> + - resets phandle
> + - bit number, counting from zero, for the desired reset line. Max is 31.
> +
> +Example:
> +
> +syscon {
> + compatible = "syscon";
> +
> + uart_rest: rest@0c {
The device node name should be "reset-controller", and leading zeroes
should be dropped from the address part:
uart_rest: reset-controller@c {
> + compatible = "reset-basic";
Maybe this is not necessary for the example, but the compatible should
contain a vendor/hardware specific string first.
> + #reset-cells = <1>;
> + reg = <0x0c>;
> + };
> +}
> +
> +&uart {
> + resets = <&uart_rest 0x04>;
I'd use decimal here.
regards
Philipp
next prev parent reply other threads:[~2017-05-29 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 3:32 [PATCH 0/2] reset: Basic reset controller Joel Stanley
2017-05-26 3:32 ` [PATCH 1/2] dt-bindings: reset: Add bindings for basic " Joel Stanley
2017-05-29 9:09 ` Philipp Zabel [this message]
2017-05-29 10:16 ` Joel Stanley
2017-05-26 3:32 ` [PATCH 2/2] reset: Add basic single-register reset driver Joel Stanley
2017-05-27 15:11 ` Andy Shevchenko
2017-05-29 10:24 ` Joel Stanley
2017-05-29 15:41 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496048959.17695.20.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).