Re: NUMA API for Linux

From: "Martin J. Bligh" <mbligh@aracnet.com>
To: colpatch@us.ibm.com, Andi Kleen <ak@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: NUMA API for Linux
Date: Thu, 08 Apr 2004 22:29:23 -0700	[thread overview]
Message-ID: <1496342704.1081488562@[10.10.2.4]> (raw)
In-Reply-To: <1081472946.12673.310.camel@arrakis>

> Instead of looking up a page's node number by
> page_zone(p)->zone_pgdat->node_id, you can get the same information much
> more efficiently by doing some bit-twidling on page->flags.  Use
> page_nodenum(struct page *) from include/linux/mm.h.

Never noticed that before - I'd prefer we renamed this to page_to_nid 
before anyone starts using it ... fits with the naming convention of 
everything else (pfn_to_nid, etc). Nobody uses it right now - I grepped 
the whole tree.

M.

diff -aurpN -X /home/fletch/.diff.exclude virgin/include/linux/mm.h name_nids/include/linux/mm.h

--- virgin/include/linux/mm.h	Wed Mar 17 07:33:09 2004
+++ name_nids/include/linux/mm.h	Thu Apr  8 22:27:24 2004
@@ -340,7 +340,7 @@ static inline unsigned long page_zonenum
 {
 	return (page->flags >> NODEZONE_SHIFT) & (~(~0UL << ZONES_SHIFT));
 }
-static inline unsigned long page_nodenum(struct page *page)
+static inline unsigned long page_to_nid(struct page *page)
 {
 	return (page->flags >> (NODEZONE_SHIFT + ZONES_SHIFT));
 }





