From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751455AbdFEOnW (ORCPT ); Mon, 5 Jun 2017 10:43:22 -0400 Received: from mga09.intel.com ([134.134.136.24]:57005 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdFEOnV (ORCPT ); Mon, 5 Jun 2017 10:43:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,300,1493708400"; d="scan'208";a="1178484642" Message-ID: <1496673798.22624.9.camel@linux.intel.com> Subject: Re: new tree for linux-next: uuid From: Andy Shevchenko To: Stephen Rothwell Cc: Christoph Hellwig , Linus Torvalds , linux-kernel@vger.kernel.org Date: Mon, 05 Jun 2017 17:43:18 +0300 In-Reply-To: <20170606002914.695e9c0b@canb.auug.org.au> References: <20170604201413.GA12748@lst.de> <20170605094956.069d5af3@canb.auug.org.au> <20170605080713.GA22028@lst.de> <1496671605.22624.2.camel@linux.intel.com> <20170606002914.695e9c0b@canb.auug.org.au> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-06-06 at 00:29 +1000, Stephen Rothwell wrote: > Hi Andy, > > On Mon, 05 Jun 2017 17:06:45 +0300 Andy Shevchenko linux.intel.com> wrote: > > > > On Mon, 2017-06-05 at 10:07 +0200, Christoph Hellwig wrote: > > > Meh, thanks.  This has been throught the buildbot countless times > > > without a report.  But I guess a less generic name might be a good > > > idea to start with. > > > > > > Andy: do you think UUID_INIT/GUID_INIT make sense to your? > > > or _INITIALIZER?   > > > > I'm a bit out of context. Where this will be used? > > include/uapi/linux/uuid.h (after the uuid lib changes) contains a > definition of the macro GUID() which is probably a bit generic a name > for a uapi include file.  It also clashes with a couple of other uses > of that macro name already in the kernel (one of which produced > several > warnings in linux-next today). > > It produces an initializer for a guid_t (structure). Just had read and finished answering to a warning. In kernel users shouldn't really use so generic names, we may fix it. OTOH, for user space I dunno if need to export that at all. If we need by some reason, shorter version looks better, GUID_INIT(), UUID_INIT()... -- Andy Shevchenko Intel Finland Oy