From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751549AbdFGJps (ORCPT ); Wed, 7 Jun 2017 05:45:48 -0400 Received: from mail-bl2nam02on0045.outbound.protection.outlook.com ([104.47.38.45]:13095 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751526AbdFGJoP (ORCPT ); Wed, 7 Jun 2017 05:44:15 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; pengutronix.de; dkim=none (message not signed) header.d=none;pengutronix.de; dmarc=fail action=none header.from=nxp.com; Message-ID: <1496828647.28352.58.camel@nxp.com> Subject: Re: [PATCH] ARM: imx6ull: Make suspend/resume work like on 6ul From: Leonard Crestez To: Anson Huang , Shawn Guo CC: Peter Chen , "linux-kernel@vger.kernel.org" , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" , Lucas Stach Date: Wed, 7 Jun 2017 12:44:07 +0300 In-Reply-To: References: <20170605053722.GI4094@dragon> <1496746313.28352.19.camel@nxp.com> <20170607032124.GA31070@dragon> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131413022516165398;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39840400002)(39450400003)(39410400002)(39860400002)(39400400002)(39850400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(377454003)(13464003)(24454002)(199003)(377424004)(189002)(9170700003)(38730400002)(6246003)(15650500001)(53936002)(93886004)(86362001)(4326008)(53546009)(229853002)(77096006)(2870700001)(54906002)(8656002)(50226002)(8936002)(8676002)(2906002)(81166006)(356003)(2950100002)(5820100001)(85426001)(105606002)(33646002)(104016004)(106466001)(498600001)(5660300001)(189998001)(76176999)(50466002)(47776003)(103116003)(305945005)(23676002)(36756003)(50986999)(99106002)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0301MB0906;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD019;1:Mpo3gB46TCMDeiWkRkYqSGbB7PK6kVAscjscM/5V1RsUWnXSaCSvICg5XEnKyJduR7Prxq6x7NU2iezBGUAJbPsWRt3GOLA3Qf23WQ/CXq8c6mMZY9S9mVOy5C918+VdzaWRkRyqD6xm4WLfLQxwuQ06S0DL4dpsxFcn98Hvc7HDU8syfV6Ld2ijOGP3Lnq7cORB36dwj4YfZBzBHSjl7quzyh94OUe8ZCZSZvR79DCUnIWE3pgK7bkXeX6lyZV8w5A2UTbM6/GjPkzVyj+uW2b2R27gcgevvZi3E1Ll/Wixzig4TefugHbwW55iHBnQE48QvadfqnGaSQ57zGBJwaEEoas82sf0XAoqzOi2bSaEJart6W9Fp9IxEhgxM5hpJ7Ljqy2IAxo8DyFWVqXfVE8PG7tNKE9MZvp9buuHtLi54NZrlbI7E4k28sHN0bFs3HOyu1MfmK3byl6Ufqfj9KmNKdDruAVwjmxGjZermmuekV/iMobR2hqkk2Rlh8ZFuX06u5/t3VCBt53nf/jDiqsMPQv1eCA7AruQU0ETSFTP9YKdGfUkzebDlMHK2A5hkz7S8J4mrhlofGzprlK3+A== X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY1PR0301MB0906: X-MS-Office365-Filtering-Correlation-Id: 8f5f0b68-9fba-4404-bb16-08d4ad89c066 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:CY1PR0301MB0906; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0906;3:bQG+nQuhI4tW8BQ/3W+QIxxwLHd0L8bBoFeZ+xKmZcyEw6vVQcictBrJesMvluZ179O70RxVSsnNNxGUjO2QWefpoAdUJmN17t9d9vzaNvGM3ORZwbMrAvyswPmcA3HbGQ6Hyom74h54jawwJ4mzFDS7IaXVm1XCWM9oiQW/bMiHpMsHGiN3TzWz8O/lDkX/vuLVCa3IzHwtuAy30i4+bwX1S5/FnLUOqljwYOoPXT3mPOxrbGMS6cGkNDmSBpi2sppRRDfJmb/s9HKcbbOBpWiJ1tixvZipkYUaVzwyiIXFAZ/QkAsTjB1TLP8kAdiwc59CSKQ88h2FqH2HiMWL9nLqyoxxrzeMQwk/EtYixpkzfIDqZHNYm9dVqroFYkt3KD/pKJVQqw0pL0kvz5Llup/Omzu94yhrQW8jmeDunUAh0nCJ1WoqrC8ut2CB6/U6;25:XsnDqdnMYuOv2oMD43parwdlQaSM8el7LB0zHQFEP6VfuHZeEGxeb14Jsh+aZByqAfLOTi0HOLUq9abb64X72HJMHY+6WDSphPQ2Ok1fFskl7uMsZy0wVwiBrZyQeQI6gZ0g/bLmKFirdTOvyOChy9/5y/RFlPjTPO/ent7cAw98Jn1AVCMe27XE6dxp8OFcFDW3wrQ5BKV5qPVAPyaR32YMc+m3qD01Uwwa9RN08Q1wjzrFRDuz3NaF33NzSYz8REzbx5P5k6IcsGl9GkzwH2mUosGb3TMQb++yNZyYA9MYHS+XCAF43x8N7qUmhxuM/eBIh09e/LZF+dMgtg1SoHr0GZ4shpNyjubNxSsS3cXATXiJM2/G3dvzl4seVrS+wBRiPBiuDdJoUn8A6q8DqaqjN9GS8HKESj5r0ruA9Wfn/+mEYNNJMWMBoNIH1h3CiNtRw4A5kQ4aKVwdiAuCU4Q/ztXprraU4fd09aUaDbA= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0906;31:Ku8bWSV80pcAmBkHFVXN7EW3t20HG2pM2/EBeRF8eDY7an4PGbJIIckuh2Y+pRzMEhpw1KzWHTxZibgfSGFQLDdW5vMyOZv98zb0NqB3nRPLI+BqwZpvSefubDDwHM4KlX/kcZRwwrlKa8XPo+6LPZuzk+L1Z+UWH4oui8cHfvzFt2g3WSDyzSqq83hoteup/vEGOaUWHpdTsFzS8VTiuu4E+mZs2i2mEvbyd3DkeoEtDjOpyHjylc/85jWnL0R4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(185117386973197)(258649278758335); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(8121501046)(5005006)(13018025)(13016025)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6096035)(20161123563025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(20161123561025)(20161123556025)(20161123565025)(20161123559100)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0301MB0906;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0301MB0906; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzMDFNQjA5MDY7NDprbTlaczBFbUZBRk04My9HcGtNNm9CMmVF?= =?utf-8?B?V0lKaFVHVldNNzk5azZxSFQ1ZEViZGFxQ3hLUmVvMUl6Rkd4Sk1TeWRhaWVv?= =?utf-8?B?OUo4Z1hTRHh6c3ExQitCNUpVdTRWdUJKUkx1L2ZzMkxFVFJzWCtHRDZoMUt4?= =?utf-8?B?SXpvN1loQTFMYjg0VDEyNEFnQnNhODNNVFJTMWZmbDJSMHowL2JmMG9MVGFR?= =?utf-8?B?OXdyaktCYi9meWoxUzBML0d2MlRaaWI5WHBITU9YaUlBTkQ5cnpkcllMZjRJ?= =?utf-8?B?R2J1WEg3UlVlY01MTVlSZ1VCWDRBc3AzUlJUc2xjSExVeXMwcEJsUXdOUzQw?= =?utf-8?B?Z2daR0dYV1hRT2RvRWlpMFUvaEEzWXFkdUIvNUpFcVQwcmFmMDZEQUlnWXFH?= =?utf-8?B?SFJBTFZWVVBVbUUrL0prSTZLLzJVd0Q2ZzFKYjBjY1IydzV2cmRUMkRZS0wx?= =?utf-8?B?OFU4S3pOcnZTYU1IZzNIbTZZRFRvZUpYMjZ3MGsvMUN5ekpia1J0MVBqSjdJ?= =?utf-8?B?ZXorSWQ3SmpwWEpLeEFHQ2V2U2NweGdhekpNZFFnMENRd25XZkk3YUpFOFlP?= =?utf-8?B?dTJBeVNVS2pWcno2cjRVU2lYNWN2TUJ5eGZaT0s2YlVaV0xjM2N0NlpxdE50?= =?utf-8?B?NVR1ZTIvV1Z4VTNmQktQeFZYUUQvRFdVNTVEaXBWbVhMUjI3UlZqaTlQWWFC?= =?utf-8?B?V0dlNWNkSzJpMk9lWjhMeW1MS2E2d3NMSEl0OGFpTU5EN1FXbUZoWkhKelNj?= =?utf-8?B?OGFDa0VvUUtkTEhORVY2dW1pU3l1NER5SmZrVzJTL1BIV29RaE5rUU1GRE5J?= =?utf-8?B?VnFpZUMxTFF5dDlJYkR1bGdzSCtoRm5LeUFoSEtjd0grMmdGdGlqdEpjWXZW?= =?utf-8?B?aXJ6cFNFN0M5Y1pvUjMwRmhFU21xdXQrc1QyazJva05RNGUzcDh6ZXUwUXM3?= =?utf-8?B?TGxwb2w3M0g2WU9MVUd0blNLcDN5eVF6NU1LaFVKR2RZb1l0S29TbXJiTWsw?= =?utf-8?B?dkJFV3duaDMxYmR1V0JyZUFGSjdQS1dCVCtSQWlyblhQdlJkU2JtSG52SWRy?= =?utf-8?B?WTBpbHBQdGJmcU1XeTlOR1ZrWGh0SkdBNnZBYXpGc05vejdpOEt3Zjc4bm9D?= =?utf-8?B?UUw0cjFQaVVBR2h2RjdCQm0yb0VkSVhQd1g1YW9oRUE3bWRNVTI4M3FIQlRD?= =?utf-8?B?M3Y4VnlZRUJ1cVhqZitkSzV3aWRnd0RPZm16eUd2SVUrZlc1aW56SXU1QmRJ?= =?utf-8?B?VStRaER3cGtpbFlMaU1lZE9VbzRpcW1FMkVINkNVZUVtUHNvZXJ0RnhVQW9R?= =?utf-8?B?Qm15M2N5NVpHVTRpQy9tcGlSWVIrdHAxcUVNdWZ4emV6a2tKQ0U5WTFmVkVV?= =?utf-8?B?WVlRQUZMYStWanE4UTVoZFAyTjZ5WUIrK292ZDRoUWJsOUl4cDBJREU4OXhX?= =?utf-8?B?ZGFnS3o4Ny94VEswY0kwdW8xdlc1cEYxRlVXR1gvUW1jelB3T2UvenJ5WVpG?= =?utf-8?B?dkxuSkhPZVhpaTBrVzhUNEIrMzdVOHFsQXF0aW41RllldmpSTmhNd21ROHl5?= =?utf-8?B?SWtOTEZuQ21NL2dXZVBtWnhkeExSSk5Vc1ZLTjNGdyt4UDJVZnR6N3BPMERs?= =?utf-8?B?U2hpaFNEM0dyVTZxanNWQ1RyWVB2U0sxSTRqc3Q1QjRCMUxTa0hYSS9rbDRw?= =?utf-8?B?ejF0Yi9ndHh5WTdzYTByRTlmMlErV2pHdzNvY2hSVGZWdmtTR1ZGcCtNbytR?= =?utf-8?B?Sm52QlFUQzdua1ZzbnZBNWdBTzkxTmJzRzJRaVhSWXh6K1RzZktDZlVORFY3?= =?utf-8?Q?A9S3svQoVUo+wF?= X-Forefront-PRVS: 03319F6FEF X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzMDFNQjA5MDY7MjM6djZSMGxUZzB1cld4OHM1bmJsMUVSY0hY?= =?utf-8?B?Q3dUNkdUdGo5ZjlHbmc2NEl1TkJDajlhandadlhaOXlYR1JzOURTWnV6aFhL?= =?utf-8?B?UXRmQmdOdWQxTis1bmhiMUhDUGFSSFNBVzVqY3ZDbUROSE9oUjRuOThaVVVZ?= =?utf-8?B?dUlzTXo3S09OY0wzRTRqWkpRSVVEVXNRT3lTaXFIcWUraDBiYWtpZ2dFRi8w?= =?utf-8?B?czNFRnJuZURRL3lzR3AyZVVFTmJxdERlS1FRUUtqYU5tWHhqT1JVdExsY2Nv?= =?utf-8?B?ZWlRUjRVbm54NnovcU9LVFFycHVtLzVGdzVoR2JxdWxhM1Iva3BWT3hGdGlx?= =?utf-8?B?ZEdya1RFVENrWlltMTE2VC9nYTFhY0QvdXpkKzhYWFo4Z25IRHJ3d1F4Tm0z?= =?utf-8?B?bnNlV2prTHRHMmhjV1pTVnB2a0NybXNkZzh4cERta3ByQVFTYjZDM3VQUy83?= =?utf-8?B?VkRkZ0VMVGdTU1VPR3lTZGFRSnFtRWc2WG54TGo0VXpncStMOEpPbk5ScHNy?= =?utf-8?B?K2k5MWs2NWN6N1RRU2YveWROZUhXMXM5RWZua0NqM0p3czh3TnBpa0hPeUlv?= =?utf-8?B?bG94ajQrL0pYK0t4MXNBZ24yWEhkRlVwdW42OXpVY2xXMkJmRjFoT1JzeTJS?= =?utf-8?B?R055bzhITDdmL0NkUTJPbjhLSmcwWURIaUJ5cFJwMVNTT3JvTlBlbDZKVEVt?= =?utf-8?B?bTdiT2R3VDQ1ZDlQUHZ5WVFpZ25XQkY0ZzF5WjJodThEOTA2R2NBa3VJS1Mr?= =?utf-8?B?V0t6V25TUGhaUERHT0lLT09xNkRTeUVha2lwM1hLRXNDTm45aWF5R0ZSWVdu?= =?utf-8?B?ZnZZYUhOZHkxc29Db1F5WlhQK0VYcmo3NmpnRS9YQXBkZUpnSFM1czNPbzFM?= =?utf-8?B?UFREY3pSdk9MRityMENyL1Z0b2ZRT0ZiRy9uZE0rK1FjbXBRVldabS96aHJ5?= =?utf-8?B?S21Jd0l4STU0c2ovcWlYNEVCRHVhYW1sbE5lSWZGczdNUU9CK3pQVkNmNmJa?= =?utf-8?B?U1N1bXBnQXBYT0ZNRjhtM0tDSGRMMTZTQm81ejNRYkIxOHlVQlVCcVdsWVdE?= =?utf-8?B?eU1JKzJWRTBLMTBNcHMzMGhVT0ZJbDdUbWVEQ2Q2UFFreWp4SXhqcEJHRnBD?= =?utf-8?B?T01JRy9rckx0QW1ZdW5CVFRYYVUyNHFuZlYxcmxTeWNJM3BwdllETVVOMnor?= =?utf-8?B?RXNlWmhhUWovTStUSm9kVkJ3WC93TmxIdEFJRmo2UWx4NEwrNnVCZFJRdEZl?= =?utf-8?B?NnMzS25xamlOSDZ5bEpaaVpzaXF5bjdDb0lyNXd1bktQTHZ2d2x6THByRkU0?= =?utf-8?B?WUFtNGF1ajRvbUh3TlFBZzRWeGozV1ZtY0pLK01YdHQzc05CRTdkWUdZTFlv?= =?utf-8?B?RmxpeDAyVW41a1ByTDlFSmtJNDZvU1MrMHArT0NieXFoR2hlU3c3M245OFFF?= =?utf-8?B?bVNQbzUyZk5sbWFHNERVWUthZ2hZT21BamU1OTRHU2d1M005Mm9wVUJZRDhk?= =?utf-8?B?TWszSG5YbWJkSHhsZkN3eFNBdm44YlJlNVV2RkI0eTUxR2tmalpFQW9Vekp6?= =?utf-8?B?aENrSXBlRkZJblRaQUU2dTRsbFZyd2wvVVZqSTNLaERkeGxNTkwzbC9xTjhK?= =?utf-8?B?YXM1MFZFUXk3RTFGaUp4R0Rnbko1YkRKc2lBWllkSW9NS29IK3dxVWpCSkRR?= =?utf-8?B?dVR4S053QWdydHl0YktaTnhueVlkYmVoOXZkMHJET3QrY0JLM1VlSGR3Ylc4?= =?utf-8?B?UTBjYTh6ODduMVQvSndoZ3JJaEZqY0J2dlJNSFB3RkxQQnJ2Q3dldzd1M0wx?= =?utf-8?B?SVlSOEUxcVBJRzJDV1VIcG5ha241M21hbHRIYlloMWMzN2c0S1N3U29LNXJj?= =?utf-8?B?QmlqdUt3a0kyZnUxWGxNUGtpelZKYy9Nczg3b2VuVUdSMkVNQ3o1dUlJdFpF?= =?utf-8?Q?e/ctkidJz9sSLfEgt8diS53cuBKPqY/8=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0906;6:+4trda1qqw/c9QHJbguQgFY/dlLFlVME7P0ZAJYR7KX6BcVj4SD6driSalwBXjoDsp+oBBO90ysZ/mqN4HHcdHFq7woM3TpeZCXyDeU1KhCnrMcWAn4Nt5/84bhqfrItDl3PyfpylgPxwD/MBFjGN3brX+QbxxCn8zREVIYEUEC91VJ6vKJ84sp67U5tA589ZPKpLXJRVpK7A318uoRwRh7bmF1cP9o7DXZp96kg6kSbj1ECvujSCZRHb6uEn+gG4Up3VX5H8FNy0am4jSSwJP+kEAKLYpm7OigX/rD6EjhB/tpjF9hR1QtLoTSNLSRlIINqmGHNTOLzU3YrgNsOP/WKgnTZOXbYGP7gyjvaxCSzF7dreYExy0f1Knb6LCOiyp9TJ6vy217X/Vl4spUqXyVgima68fdo81DKs9KYB4CLyynFJU+WI51WfBJ0xrkpF3LX0kPdqpBax3lSt3a8FYEgxL6SnLUdSy3y63sdxvifhtAxWGfh8F8rIM7suig0yeiCeRNMxnmWj7qazEocZg== X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0906;5:mwBKMx33SJWeLfpfDZxiDw41MJGAkTNu3u2buLe/hHNYHsESVxajoln+w+/s4CO4pTCttoX2rfiWtgIyD57AEu8DRwDVOv039YDwrRjp6sI7eFci1/Yp0FmcIcw2vwUeGRcqzoSzbXHgU5DVZF/Oy+89a9l7PveCRTSRZZ0qh5U/LR3SDg8WieGM2kiE4AeyWwoHqgrHVCB9+CFd+BocyEGGN2kmSwxG5T1jazGEuFktih22rcaos0e3anllrunXvqp3m0mX/aQBBBvJxlDJtYPErq3REN+Wt4pKOdnjsR8malPlXEQsTOzBvc+76zYp5K0c3gHO9Je4oURLg1w9M24FdOkecMOIZ+U8NmC8HN3/7QVtAxCn2g9+ejMswqBn7BtrYNoyhz7pnYmz5dH6vpDqTsPfsz/XYojoUVLacN67JBxk9dHGMZJUNg56GRPTcv7T6q4rgx+5qf7J5rvceGvHjPr1jJbXy1jatwS4kInVaiaayJTaPgvo9OSH2loCHUHoDnUCwZv8MKT55DYFxg==;24:sDzyM25WL0vUTTseCSvx4n7QQQ81FKNUiWIX1113M+yRSzHwVN7sPF48iqv48NnXrTyQujog+YwpuS1yIzJX9OagtNWUHea17sYKKZSpu48= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0906;7:qEVhNmYxCj7IlrQMpzEIKMkkKBpoOupsUlXzRDnB8On4z0wGKIvA7qlvR56dLFl68kR5TVY0YKStQNqvY5A9rrAVo/LJBGsdQhf+/tTsgws1LWer4vl5VrvzdHv1E9qn7yUAKrRdF/iJ4vHiCRQW/niUzgwJ7JW34UNUp+nk3GABkKBfVaxjeRz1mRzFmOzYz+p5YRSFbqe6HoLhqgrK9D/HAxeMMWeD3jylhe2khYyPG8o8/6eKT2ibc9rAjBcPeYb/M84lIlmInBuAg8KKGSx3mz3HNiP632sQ+MAMHDVb6vEDQLOwLyzc37KabdbR8iyMIWVQvG7SikCBimEuXA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2017 09:44:11.3669 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0906 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-06-07 at 03:38 +0000, Anson Huang wrote: > > -----Original Message----- > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > Sent: 2017-06-07 11:21 AM > > To: Anson Huang > > Cc: Leonard Crestez ; Peter Chen > > ; linux-kernel@vger.kernel.org; Fabio Estevam > > ; linux-arm-kernel@lists.infradead.org; Lucas Stach > > > > Subject: Re: [PATCH] ARM: imx6ull: Make suspend/resume work like on 6ul > > > > On Tue, Jun 06, 2017 at 01:51:53PM +0300, Leonard Crestez wrote: > > > > > > On Mon, 2017-06-05 at 13:37 +0800, Shawn Guo wrote: > > > > > > > > On Tue, May 30, 2017 at 07:11:19PM +0300, Leonard Crestez wrote: > > > > > > > > > > > > > > > Suspend and resume on imx6ull is currenty not working because of > > > > > some missed checks where behavior should match imx6ul. > > > > > > > > > > Signed-off-by: Leonard Crestez > > > > > --- > > > > >  arch/arm/mach-imx/mxc.h     | 6 ++++++ > > > > >  arch/arm/mach-imx/pm-imx6.c | 6 ++++-- > > > > >  2 files changed, 10 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/arch/arm/mach-imx/mxc.h b/arch/arm/mach-imx/mxc.h > > > > > index 34f2ff6..e00d626 100644 > > > > > --- a/arch/arm/mach-imx/mxc.h > > > > > +++ b/arch/arm/mach-imx/mxc.h > > > > > @@ -39,6 +39,7 @@ > > > > >  #define MXC_CPU_IMX6SX 0x62 > > > > >  #define MXC_CPU_IMX6Q 0x63 > > > > >  #define MXC_CPU_IMX6UL 0x64 > > > > > +#define MXC_CPU_IMX6ULL 0x65 > > > > Since you are adding a new CPU type, you should probably patch > > > > imx_soc_device_init() for it as well. > > > Ok, I will resend as a 2-patch series. > > > > > > BTW, it actually seems to me that setting > > BM_CLPCR_BYP_MMDC_CH0_LPM_HS > > > > > > on imx6sl/sx/ul/ull is not actually needed. That bit (19) is > > > documented as "reserved" in the Reference Manual and likely ignored by > > hardware. > > > > > > > > > As far as I understand the MMDC on imx6qdl has two channels and unless > > > 2-channel mode is enabled (not currently supported) the handshake with > > > CH1 needs to be disabled. Other reduced chips only have one MMDC > > > channel and that is CH1 (CH0 was removed) and nothing needs to be done > > > from them. The only important thing is to avoid setting > > > BM_CLPCR_BYP_MMDC_CH1_LPM_HS. > > > > > > However perhaps what I am saying is wrong for some early chip versions? > > > Because this behavior of setting BM_CLPCR_BYP_MMDC_CH0_LPM_HS has > > been > > > > > > in the kernel for a long time. > As far as I know, since i.MX6SX, we only use MMDC_CH1, but MMDC_CH0 is still > there and we need to bypass its handshake when entering low power mode. > > The bit 19 in DOC is incorrect, I remembered I ever tried it and discuss with design > time, they request DOC team to update DOC, > but I think doc team forgot to do it. You can try removing this bit 19 setting > and see if standby/mem suspend can still work? And try to modify this bit 19 value > to see if it can be modified. After some testing it seems that setting MMDC_CH0 is indeed required. So nevermind I remember testing this earlier and getting the opposite result but I probably confused the STOP_POWER_ON and STOP_POWER_OFF paths. -- Regards, Leonard