From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbdFMKgR (ORCPT ); Tue, 13 Jun 2017 06:36:17 -0400 Received: from smtprelay0162.hostedemail.com ([216.40.44.162]:39051 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751895AbdFMKgQ (ORCPT ); Tue, 13 Jun 2017 06:36:16 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3866:3867:3870:3871:3872:4250:4321:5007:6691:7576:10004:10400:10848:11232:11657:11658:11914:12043:12048:12296:12740:12760:12895:13069:13095:13255:13311:13357:13439:14180:14181:14659:14721:21080:21433:21627:30034:30054:30070:30080:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: rice51_1938ba8db8f4e X-Filterd-Recvd-Size: 1844 Message-ID: <1497350172.18751.11.camel@perches.com> Subject: Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" From: Joe Perches To: Colin King , Herbert Xu , "David S . Miller" , Srikanth Jampala , linux-crypto@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 13 Jun 2017 03:36:12 -0700 In-Reply-To: <20170613085254.20855-1-colin.king@canonical.com> References: <20170613085254.20855-1-colin.king@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in seq_printf message Hey Colin. Fixing spelling typos is a good thing, but is it a good thing to change possibly API dependent output in seq_ calls? > diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c [] > @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v) > struct nitrox_device *ndev = s->private; > > seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx); > - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id); > + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id); > seq_printf(s, " Cores [AE: %u SE: %u]\n", > ndev->hw.ae_cores, ndev->hw.se_cores); > seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);