From: Bastien Nocera <hadess@hadess.net>
To: "Zheng, Lv" <lv.zheng@intel.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Peter Hutterer <peter.hutterer@who-t.net>,
Lennart Poettering <mzxreary@0pointer.de>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
"Brown, Len" <len.brown@intel.com>, Lv Zheng <zetalog@gmail.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"systemd-devel@lists.freedesktop.org"
<systemd-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI
Date: Tue, 20 Jun 2017 00:08:47 +0200 [thread overview]
Message-ID: <1497910127.2559.1.camel@hadess.net> (raw)
In-Reply-To: <1AE640813FDE7649BE1B193DEA596E886CED1419@SHSMSX101.ccr.corp.intel.com>
On Mon, 2017-06-19 at 01:43 +0000, Zheng, Lv wrote:
> <snip>
> >
> > If you implement it in such a way that GNOME settings daemon
> > behaves weirdly, you'll get my revert
> > request in the mail. Do. Not. Ever. Lie.
>
> First, I don't know what should be reverted...
> I have 2 solutions here for review, and Benjamin has 1.
> And none of them has been upstreamed.
> We are just discussing.
The discussion is getting tiring quite frankly. We've been over this
for nearly a year now, and with no end in sight.
> However we need to get 1 of them upstreamed in next cycle.
>
> I think users won't startup gnome-setting-daemon right after resume.
> It should have already been started.
>
> There is only 1 platform may see delayed state update after resume.
> Let's see if there is a practical issue.
> 1. Before suspend, the "lid state" is "close", and
> 2. After resume, the state might remain "close" for a while
> Since libinput won't deliver close to userspace,
> and gnome-setting-daemon listens to key switches, there is no
> wrong behavior.
It doesn't. It listens to UPower, which tells user-space whether there
is a lid switch, and whether it's opened or closed.
> 3. Then after several seconds, "open" arrives.
> gnome-setting-daemon re-arrange monitors and screen layouts in
> response to the new event.
Just how is anyone supposed to know that there is an event coming?
> So there is no problem. IMO, there is no need to improve for post-
> resume case.
>
> Users will just startup gnome-setting-daemon once after boot.
> And it's likely that when it is started, the state is correct.
You cannot rely on when gnome-settings-daemon will be started to make
*any* decision. Certainly not decisions on how the kernel should
behave.
> IMO, there might be a chance to improve for post-boot case using
> Benjamin's approach.
next prev parent reply other threads:[~2017-06-19 22:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 18:46 [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI Benjamin Tissoires
2017-06-01 18:46 ` [WIP PATCH 1/4] ACPI: button: extract input creation/destruction helpers Benjamin Tissoires
2017-06-01 18:46 ` [WIP PATCH 2/4] ACPI: button: remove the LID input node when the state is unknown Benjamin Tissoires
2017-06-05 3:19 ` Zheng, Lv
2017-06-06 10:22 ` Benjamin Tissoires
2017-06-07 1:27 ` Peter Hutterer
2017-06-07 9:56 ` Zheng, Lv
2017-06-01 18:46 ` [WIP PATCH 3/4] ACPI: button: Let input filter out the LID events Benjamin Tissoires
2017-06-05 4:28 ` Zheng, Lv
2017-06-06 10:31 ` Benjamin Tissoires
2017-06-01 18:46 ` [WIP PATCH 4/4] ACPI: button: Fix lid notification locks Benjamin Tissoires
2017-06-05 3:33 ` Zheng, Lv
2017-06-06 10:29 ` Benjamin Tissoires
2017-06-07 9:47 ` Zheng, Lv
2017-06-01 21:43 ` [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI Bastien Nocera
2017-06-02 7:24 ` Benjamin Tissoires
2017-06-05 2:25 ` Zheng, Lv
2017-06-07 7:48 ` [systemd-devel] " Lennart Poettering
2017-06-13 10:06 ` Benjamin Tissoires
2017-06-15 2:52 ` Zheng, Lv
2017-06-15 6:47 ` Peter Hutterer
2017-06-15 7:33 ` Zheng, Lv
2017-06-15 7:57 ` Peter Hutterer
2017-06-16 5:37 ` Zheng, Lv
2017-06-16 7:23 ` Benjamin Tissoires
2017-06-16 7:45 ` Zheng, Lv
2017-06-16 8:09 ` Benjamin Tissoires
2017-06-16 8:53 ` Zheng, Lv
2017-06-16 9:06 ` Bastien Nocera
2017-06-16 16:32 ` Lennart Poettering
2017-06-19 2:16 ` Zheng, Lv
2017-06-19 1:43 ` Zheng, Lv
2017-06-19 22:08 ` Bastien Nocera [this message]
2017-06-20 2:45 ` Zheng, Lv
2017-06-21 10:23 ` Bastien Nocera
2017-06-22 3:16 ` Zheng, Lv
2017-06-14 23:50 ` Zheng, Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497910127.2559.1.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mzxreary@0pointer.de \
--cc=peter.hutterer@who-t.net \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=systemd-devel@lists.freedesktop.org \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).