From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Luis Oliveira <Luis.Oliveira@synopsys.com>,
wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com,
jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com,
CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH v12 1/2] i2c: designware: add SLAVE mode functions
Date: Tue, 27 Jun 2017 17:22:06 +0300 [thread overview]
Message-ID: <1498573326.22624.196.camel@linux.intel.com> (raw)
In-Reply-To: <8da0ec338fd4b634b01ecded0117f7bd423c6aaf.1498126241.git.lolivei@synopsys.com>
On Thu, 2017-06-22 at 11:17 +0100, Luis Oliveira wrote:
> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
> - Slave functions added to core library file
> - Slave abort sources added to common source file
> - New driver: i2c-designware-slave added
> - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module
> when supported by the architecture.
>
> All the SLAVE flow is added but it is not enabled via platform
> driver.
There are couple of nits, otherwise I'm okay with the patch.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> V11-v12
> - Changed ifdef condition in the Makefile fixed Kbuild error
+ rebased on top of latest i2c-next (drop applied patches effectively)
> +static int i2c_dw_irq_handler_slave(struct dw_i2c_dev *dev)
> +{
>
> + dev_dbg(dev->dev,
> + "%#x STAUTS SLAVE_ACTTVITY=%#x : RAW_INTR_STAT=%#x"
> + " : INTR_STAT=%#x\n",
Don't split string literals.
> + enabled, slave_activity, raw_stat, stat);
> + dev_vdbg(dev->dev, "Byte %X
> acked!",
> + val);
I'm not sure it's any helpful.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-06-27 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 10:17 [PATCH v12 0/2] i2c: designware: add I2C SLAVE support Luis Oliveira
2017-06-22 10:17 ` [PATCH v12 1/2] i2c: designware: add SLAVE mode functions Luis Oliveira
2017-06-27 14:22 ` Andy Shevchenko [this message]
2017-06-27 14:22 ` Jarkko Nikula
2017-06-27 21:35 ` Wolfram Sang
2017-06-22 10:17 ` [PATCH v12 2/2] i2c: designware: enable SLAVE in platform module Luis Oliveira
2017-06-27 14:11 ` Jarkko Nikula
2017-06-27 21:35 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498573326.22624.196.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Luis.Oliveira@synopsys.com \
--cc=Ramiro.Oliveira@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).