From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751703AbdF2DAd (ORCPT ); Wed, 28 Jun 2017 23:00:33 -0400 Received: from mga07.intel.com ([134.134.136.100]:39455 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751541AbdF2DAZ (ORCPT ); Wed, 28 Jun 2017 23:00:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,278,1496127600"; d="scan'208";a="118688141" Message-ID: <1498705219.2510.4.camel@intel.com> Subject: Re: [PATCH] thermal/intel_powerclamp: add const to thermal_cooling_device_ops structure From: Zhang Rui To: Bhumika Goyal , julia.lawall@lip6.fr, edubezval@gmail.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jacob Pan Date: Thu, 29 Jun 2017 11:00:19 +0800 In-Reply-To: <1498028988-12916-1-git-send-email-bhumirks@gmail.com> References: <1498028988-12916-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-06-21 at 12:39 +0530, Bhumika Goyal wrote: > Declare thermal_cooling_device_ops structure as const as it is only > passed > as an argument to the function thermal_cooling_device_register and > this > argument is of type const. So, declare the structure as const. > I checked the source and the code is written in this way as well in some other drivers, why not fix them altogether? thanks, rui > Signed-off-by: Bhumika Goyal > --- >  drivers/thermal/intel_powerclamp.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/intel_powerclamp.c > b/drivers/thermal/intel_powerclamp.c > index d718cd1..e4c68b7 100644 > --- a/drivers/thermal/intel_powerclamp.c > +++ b/drivers/thermal/intel_powerclamp.c > @@ -659,7 +659,7 @@ static int powerclamp_set_cur_state(struct > thermal_cooling_device *cdev, >  } >   >  /* bind to generic thermal layer as cooling device*/ > -static struct thermal_cooling_device_ops powerclamp_cooling_ops = { > +static const struct thermal_cooling_device_ops > powerclamp_cooling_ops = { >   .get_max_state = powerclamp_get_max_state, >   .get_cur_state = powerclamp_get_cur_state, >   .set_cur_state = powerclamp_set_cur_state,