From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753387AbdF2OgN (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Jun 2017 10:36:13 -0400
Received: from imap0.codethink.co.uk ([185.43.218.159]:37834 "EHLO
        imap0.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751974AbdF2OgE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Jun 2017 10:36:04 -0400
Message-ID: <1498746951.1935.51.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 39/46] r8152: avoid start_xmit to schedule napi when
 napi is disabled
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Hayes Wang <hayeswang@realtek.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Sasha Levin <alexander.levin@verizon.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Thu, 29 Jun 2017 15:35:51 +0100
In-Reply-To: <20170615175220.137032432@linuxfoundation.org>
References: <20170615175218.286057711@linuxfoundation.org>
         <20170615175220.137032432@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-06-15 at 19:52 +0200, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: hayeswang <hayeswang@realtek.com>
> 
> 
> [ Upstream commit de9bf29dd6e4a8a874cb92f8901aed50a9d0b1d3 ]
> 
> Stop the tx when the napi is disabled to prevent napi_schedule() is
> called.
[...]
> +	netif_stop_queue(netdev);
>  	napi_disable(&tp->napi);
[...]

netif_stop_queue() is not synchronous, so you probably need
netif_tx_disable() instead.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.