From: Jin Yao <yao.jin@linux.intel.com>
To: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com
Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com,
Jin Yao <yao.jin@linux.intel.com>
Subject: [PATCH v4 0/2] perf report: Implement visual marker for macro fusion in annotate
Date: Fri, 7 Jul 2017 13:06:33 +0800 [thread overview]
Message-ID: <1499403995-19857-1-git-send-email-yao.jin@linux.intel.com> (raw)
Macro fusion merges two instructions to a single micro-op. Intel
core platform performs this hardware optimization under limited
circumstances. For example, CMP + JCC can be "fused" and executed
/retired together. While with sampling this can result in the
sample sometimes being on the JCC and sometimes on the CMP.
So for the fused instruction pair, they could be considered
together.
On Nehalem, fused instruction pairs:
cmp/test + jcc.
On other new CPU:
cmp/test/add/sub/and/inc/dec + jcc.
This patch series marks the case clearly by joining the fused
instruction pair in the arrow of the jump.
For example:
│ ┌──cmpl $0x0,argp_program_version_hook
81.93 │ ├──je 20
│ │ lock cmpxchg %esi,0x38a9a4(%rip)
│ │↓ jne 29
│ │↓ jmp 43
11.47 │20:└─→cmpxch %esi,0x38a999(%rip)
Change-log:
-----------
v4: Move the CPU model checking to symbol__disassemble and save
the family/model in arch structure. It avoids checking everytime
when display the jump arrows.
The patch set is still performing the fused checking when user
moves the cursor on the jump instruction.
v3: 1. Add checking for Nehalem (CMP, TEST). For other newer
Intel CPUs just check it by default (CMP, TEST, ADD,
SUB, AND, INC, DEC).
2. Use Arnaldo's fix to let the display be better
v2: According to Arnaldo's comments, remove the weak function and
use an arch-specific function instead to check fused instruction
pair.
v1: Inital post
Jin Yao (2):
perf util: Check for fused instruction
perf report: Implement visual marker for macro fusion in annotate
tools/perf/arch/x86/annotate/instructions.c | 46 +++++++++++++++++++++++++++++
tools/perf/builtin-top.c | 2 +-
tools/perf/ui/browser.c | 29 ++++++++++++++++++
tools/perf/ui/browser.h | 2 ++
tools/perf/ui/browsers/annotate.c | 30 ++++++++++++++++++-
tools/perf/ui/gtk/annotate.c | 2 +-
tools/perf/util/annotate.c | 27 +++++++++++++++--
tools/perf/util/annotate.h | 4 ++-
8 files changed, 136 insertions(+), 6 deletions(-)
--
2.7.4
next reply other threads:[~2017-07-07 5:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 5:06 Jin Yao [this message]
2017-07-07 5:06 ` [PATCH v4 1/2] perf util: Check for fused instruction Jin Yao
2017-07-20 8:36 ` [tip:perf/core] perf annotate: Check for fused instructions tip-bot for Jin Yao
2017-07-07 5:06 ` [PATCH v4 2/2] perf report: Implement visual marker for macro fusion in annotate Jin Yao
2017-07-07 14:51 ` Arnaldo Carvalho de Melo
2017-07-10 0:31 ` Jin, Yao
2017-07-20 8:36 ` [tip:perf/core] perf annotate: Implement visual marker for macro fusion tip-bot for Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499403995-19857-1-git-send-email-yao.jin@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).