From: Byungchul Park <byungchul.park@lge.com>
To: torvalds@linux-foundation.org
Cc: axboe@fb.com, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: [RESEND PATCH] namespace.c: Don't reinvent the wheel but use existing llist API
Date: Mon, 10 Jul 2017 11:37:32 +0900 [thread overview]
Message-ID: <1499654252-32540-5-git-send-email-byungchul.park@lge.com> (raw)
In-Reply-To: <1499654252-32540-1-git-send-email-byungchul.park@lge.com>
Although llist provides proper APIs, they are not used. Make them used.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
fs/namespace.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index b5b1259..5cb2229 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1082,12 +1082,10 @@ static void __cleanup_mnt(struct rcu_head *head)
static void delayed_mntput(struct work_struct *unused)
{
struct llist_node *node = llist_del_all(&delayed_mntput_list);
- struct llist_node *next;
+ struct mount *m, *t;
- for (; node; node = next) {
- next = llist_next(node);
- cleanup_mnt(llist_entry(node, struct mount, mnt_llist));
- }
+ llist_for_each_entry_safe(m, t, node, mnt_llist)
+ cleanup_mnt(m);
}
static DECLARE_DELAYED_WORK(delayed_mntput_work, delayed_mntput);
@@ -1615,7 +1613,7 @@ void __detach_mounts(struct dentry *dentry)
namespace_unlock();
}
-/*
+/*
* Is the caller allowed to modify his namespace?
*/
static inline bool may_mount(void)
@@ -2159,7 +2157,7 @@ static int do_loopback(struct path *path, const char *old_name,
err = -EINVAL;
if (mnt_ns_loop(old_path.dentry))
- goto out;
+ goto out;
mp = lock_mount(path);
err = PTR_ERR(mp);
--
1.9.1
next prev parent reply other threads:[~2017-07-10 2:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 2:37 [RESEND PATCH] Don't reinvent the wheel but use existing llilst API Byungchul Park
2017-07-10 2:37 ` [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-07-10 2:37 ` [RESEND PATCH] fput: " Byungchul Park
2017-07-10 2:37 ` [RESEND PATCH] mm: " Byungchul Park
2017-07-10 2:37 ` Byungchul Park [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-07 8:44 [RESEND PATCH] namespace.c: " Byungchul Park
2017-05-12 0:51 Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499654252-32540-5-git-send-email-byungchul.park@lge.com \
--to=byungchul.park@lge.com \
--cc=axboe@fb.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).