From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbdGMMob (ORCPT ); Thu, 13 Jul 2017 08:44:31 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:54661 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbdGMMo3 (ORCPT ); Thu, 13 Jul 2017 08:44:29 -0400 Authentication-Results: ppops.net; spf=none smtp.mailfrom=rf@opensource.wolfsonmicro.com Message-ID: <1499949850.4826.88.camel@rf-debian.wolfsonmicro.main> Subject: Re: [PATCH v2 01/18] mfd: madera: Add register definitions for Cirrus Logic Madera codecs From: Richard Fitzgerald To: Mark Brown CC: Lee Jones , , , , , , , , , , Date: Thu, 13 Jul 2017 13:44:10 +0100 In-Reply-To: <20170713100539.mqvyxgvwqowjim6i@sirena.org.uk> References: <1493050124-5970-1-git-send-email-rf@opensource.wolfsonmicro.com> <1493050124-5970-2-git-send-email-rf@opensource.wolfsonmicro.com> <20170713080210.lbsjnmlciovoxe4g@dell> <20170713100539.mqvyxgvwqowjim6i@sirena.org.uk> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.4.4-3 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707130199 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-07-13 at 11:05 +0100, Mark Brown wrote: > On Thu, Jul 13, 2017 at 09:02:10AM +0100, Lee Jones wrote: > > > This patch has been rejected by Linus. > > > https://lkml.org/lkml/2017/7/7/579 > > Hrm, when I used to push the register definition patches I did elide all > the obviously repeated register banks like the write sequencer one that > Linus is calling out there. I'm surprised by the "every single line" > bit though... Linux doesn't say what he wants us to do about it. I could manually strip out a few more definitions but seriously, it makes the code a lot harder to maintain if we can't grep it for use of registers and register fields. They are big chips, they have a lot of stuff in the registers.