From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5F2C33CB1 for ; Tue, 14 Jan 2020 08:04:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D2CF2187F for ; Tue, 14 Jan 2020 08:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729140AbgANIEB convert rfc822-to-8bit (ORCPT ); Tue, 14 Jan 2020 03:04:01 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:39851 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728682AbgANID7 (ORCPT ); Tue, 14 Jan 2020 03:03:59 -0500 Received: from mail-pj1-f71.google.com ([209.85.216.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1irHB5-0006fy-Rr for linux-kernel@vger.kernel.org; Tue, 14 Jan 2020 08:03:56 +0000 Received: by mail-pj1-f71.google.com with SMTP id bg6so7687147pjb.5 for ; Tue, 14 Jan 2020 00:03:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=oyHMiGCOwwLhZ3ql1qP5fClJMPTVAnuOcLkJMOC5WrM=; b=d96i1Tc8bwGvGmCOiuDJ5RSwRNl8nZdZ5Vr+VcjePyFpNiBXLDffWPrOLs0X06ZBe6 fRGfcM4bx/zFhC7ilTmGwTScW/b2WmFMjSmWMiY1mkQ9yrrTTgo4ip5M4I+TqeeEhjSk kM+KgYSIuUVR+ccbV2drQjkouwrHrigclg1QdXQRvyhxbP/2Yo65T9Kn2nAhvaY/73A4 61UbwpAqfz3qPATiKQO+B5GjC8S6qFmAX+MZf6idXWht/bwsLuu8r7T+LJ5pZ5RPoxT7 o7dZaqLzD0ee+2s65p8qhEYBHSIsJK0W9vM4YSsCLw7h4bmFYtltwKr4EeScDv+Ht5ZQ HSmA== X-Gm-Message-State: APjAAAVY+RUiaUoJc9YT5vV0u4R9o6/YxKfcCBYJztzTpZ78tyFzouiR XiqJSjJ9J3fl0bKO19l+SSzaMY5dd/4QmuiidvoZUUp+8inCGFr2bZ+XhWxda7opyRT5/CohxA2 t560yDy7/rWeOHE1vTzlLUP4SIrwe59DRxP43r6LI5g== X-Received: by 2002:a63:ea4c:: with SMTP id l12mr24798748pgk.174.1578989034500; Tue, 14 Jan 2020 00:03:54 -0800 (PST) X-Google-Smtp-Source: APXvYqxShyOZDQstdIjpd/FUo8c7HCAwhOQJ9K9D7HaFj30wgfmPowWV6e8wRIMwJtnAXgZ8tGtY1g== X-Received: by 2002:a63:ea4c:: with SMTP id l12mr24798706pgk.174.1578989034126; Tue, 14 Jan 2020 00:03:54 -0800 (PST) Received: from 2001-b011-380f-35a3-5d99-e277-e07f-4d26.dynamic-ip6.hinet.net (2001-b011-380f-35a3-5d99-e277-e07f-4d26.dynamic-ip6.hinet.net. [2001:b011:380f:35a3:5d99:e277:e07f:4d26]) by smtp.gmail.com with ESMTPSA id bo19sm15439224pjb.25.2020.01.14.00.03.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jan 2020 00:03:53 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: Re: [PATCH] r8152: Add MAC passthrough support to new device From: Kai-Heng Feng In-Reply-To: Date: Tue, 14 Jan 2020 16:03:50 +0800 Cc: David Miller , Hayes Wang , Jakub Kicinski , Grant Grundler , Mario Limonciello , David Chen , "open list:USB NETWORKING DRIVERS" , "open list:NETWORKING DRIVERS" , open list Content-Transfer-Encoding: 8BIT Message-Id: <14A65209-846C-4C94-9EC3-55605D2528B0@canonical.com> References: <20200114044127.20085-1-kai.heng.feng@canonical.com> To: Prashant Malani X-Mailer: Apple Mail (2.3608.40.2.2.4) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jan 14, 2020, at 15:51, Prashant Malani wrote: > > On Mon, Jan 13, 2020 at 8:41 PM Kai-Heng Feng > wrote: >> >> Device 0xa387 also supports MAC passthrough, therefore add it to the >> whitelst. >> >> BugLink: https://bugs.launchpad.net/bugs/1827961/comments/30 >> Signed-off-by: Kai-Heng Feng >> --- >> drivers/net/usb/r8152.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c >> index c5ebf35d2488..42dcf1442cc0 100644 >> --- a/drivers/net/usb/r8152.c >> +++ b/drivers/net/usb/r8152.c >> @@ -6657,7 +6657,8 @@ static int rtl8152_probe(struct usb_interface *intf, >> } >> >> if (le16_to_cpu(udev->descriptor.idVendor) == VENDOR_ID_LENOVO && >> - le16_to_cpu(udev->descriptor.idProduct) == 0x3082) >> + (le16_to_cpu(udev->descriptor.idProduct) == 0x3082 || >> + le16_to_cpu(udev->descriptor.idProduct) == 0xa387)) > Perhaps we can try to use #define's for these vendor IDs (like > https://github.com/torvalds/linux/blob/master/drivers/net/usb/r8152.c#L680) > ? We can, but it'll bring some inconsistencies inside of rtl8152_table[], since we don't know idProduct for other devices. Kai-Heng > >> set_bit(LENOVO_MACPASSTHRU, &tp->flags); >> >> if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x3011 && udev->serial && >> -- >> 2.17.1 >>