linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Archie Pusaka <apusaka@google.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	CrosBT Upstreaming <chromeos-bluetooth-upstreaming@chromium.org>,
	Archie Pusaka <apusaka@chromium.org>,
	Miao-chen Chou <mcchou@chromium.org>,
	Yun-Hao Chung <howardchung@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
Subject: Re: [PATCH v1 1/5] Bluetooth: advmon offload MSFT add rssi support
Date: Mon, 7 Dec 2020 10:56:50 +0100	[thread overview]
Message-ID: <14E449EF-6E91-43BF-9477-61B29B20783A@holtmann.org> (raw)
In-Reply-To: <CAJQfnxG_GDsTTJ1v=Ug0MqEGmTSdeYcOhEf3rQ1hDTmvJS0JrQ@mail.gmail.com>

Hi Archie,

>>>>> MSFT needs rssi parameter for monitoring advertisement packet,
>>>>> therefore we should supply them from mgmt.
>>>>> 
>>>>> Signed-off-by: Archie Pusaka <apusaka@chromium.org>
>>>>> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
>>>>> Reviewed-by: Yun-Hao Chung <howardchung@google.com>
>>>> 
>>>> I don’t need any Reviewed-by if they are not catching an obvious user API breakage.
>>>> 
>>>>> ---
>>>>> 
>>>>> include/net/bluetooth/hci_core.h | 9 +++++++++
>>>>> include/net/bluetooth/mgmt.h     | 9 +++++++++
>>>>> net/bluetooth/mgmt.c             | 8 ++++++++
>>>>> 3 files changed, 26 insertions(+)
>>>>> 
>>>>> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
>>>>> index 9873e1c8cd16..42d446417817 100644
>>>>> --- a/include/net/bluetooth/hci_core.h
>>>>> +++ b/include/net/bluetooth/hci_core.h
>>>>> @@ -246,8 +246,17 @@ struct adv_pattern {
>>>>>     __u8 value[HCI_MAX_AD_LENGTH];
>>>>> };
>>>>> 
>>>>> +struct adv_rssi_thresholds {
>>>>> +     __s8 low_threshold;
>>>>> +     __s8 high_threshold;
>>>>> +     __u16 low_threshold_timeout;
>>>>> +     __u16 high_threshold_timeout;
>>>>> +     __u8 sampling_period;
>>>>> +};
>>>>> +
>>>>> struct adv_monitor {
>>>>>     struct list_head patterns;
>>>>> +     struct adv_rssi_thresholds rssi;
>>>>>     bool            active;
>>>>>     __u16           handle;
>>>>> };
>>>>> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
>>>>> index d8367850e8cd..dc534837be0e 100644
>>>>> --- a/include/net/bluetooth/mgmt.h
>>>>> +++ b/include/net/bluetooth/mgmt.h
>>>>> @@ -763,9 +763,18 @@ struct mgmt_adv_pattern {
>>>>>     __u8 value[31];
>>>>> } __packed;
>>>>> 
>>>>> +struct mgmt_adv_rssi_thresholds {
>>>>> +     __s8 high_threshold;
>>>>> +     __le16 high_threshold_timeout;
>>>>> +     __s8 low_threshold;
>>>>> +     __le16 low_threshold_timeout;
>>>>> +     __u8 sampling_period;
>>>>> +} __packed;
>>>>> +
>>>>> #define MGMT_OP_ADD_ADV_PATTERNS_MONITOR      0x0052
>>>>> struct mgmt_cp_add_adv_patterns_monitor {
>>>>>     __u8 pattern_count;
>>>>> +     struct mgmt_adv_rssi_thresholds rssi;
>>>>>     struct mgmt_adv_pattern patterns[];
>>>>> } __packed;
>>>> 
>>>> This is something we can not do. It breaks an userspace facing API. Is the mgmt opcode 0x0052 in an already released kernel?
>>> 
>>> Yes, the opcode does exist in an already released kernel.
>>> 
>>> The DBus method which accesses this API is put behind the experimental
>>> flag, therefore we expect they are flexible enough to support changes.
>>> Previously, we already had a discussion in an email thread with the
>>> title "Offload RSSI tracking to controller", and the outcome supports
>>> this change.
>>> 
>>> Here is an excerpt of the discussion.
>> 
>> it doesn’t matter. This is fixed API now and so we can not just change it. The argument above is void. What matters if it is in already released kernel.
> 
> If that is the case, do you have a suggestion to allow RSSI to be
> considered when monitoring advertisement? Would a new MGMT opcode with
> these parameters suffice?

its the only way.

Regards

Marcel


  reply	other threads:[~2020-12-07  9:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 10:29 [PATCH v1 0/5] MSFT offloading support for advertisement monitor Archie Pusaka
2020-12-03 10:29 ` [PATCH v1 1/5] Bluetooth: advmon offload MSFT add rssi support Archie Pusaka
2020-12-03 14:03   ` Marcel Holtmann
2020-12-04  3:25     ` Archie Pusaka
2020-12-04  9:51       ` Marcel Holtmann
2020-12-04 16:34         ` Archie Pusaka
2020-12-07  9:56           ` Marcel Holtmann [this message]
2020-12-07 10:48             ` Archie Pusaka
2020-12-03 10:29 ` [PATCH v1 2/5] Bluetooth: advmon offload MSFT add monitor Archie Pusaka
2020-12-03 10:29 ` [PATCH v1 3/5] Bluetooth: advmon offload MSFT remove monitor Archie Pusaka
2020-12-03 10:29 ` [PATCH v1 4/5] Bluetooth: advmon offload MSFT handle controller reset Archie Pusaka
2020-12-03 10:29 ` [PATCH v1 5/5] Bluetooth: advmon offload MSFT handle filter enablement Archie Pusaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14E449EF-6E91-43BF-9477-61B29B20783A@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=apusaka@chromium.org \
    --cc=apusaka@google.com \
    --cc=chromeos-bluetooth-upstreaming@chromium.org \
    --cc=davem@davemloft.net \
    --cc=howardchung@google.com \
    --cc=johan.hedberg@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcchou@chromium.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH v1 1/5] Bluetooth: advmon offload MSFT add rssi support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).