From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC0BC11F67 for ; Thu, 1 Jul 2021 16:56:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8598B613E2 for ; Thu, 1 Jul 2021 16:56:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232850AbhGAQ7I (ORCPT ); Thu, 1 Jul 2021 12:59:08 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:57452 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbhGAQ7G (ORCPT ); Thu, 1 Jul 2021 12:59:06 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1625158596; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=a6Y+UJzX51hrFbNp2BhxTJQy4FwK+otdQWbFQJKCVAo=; b=MMHPqNBgN7cXJsjSGL+El74Md6se60ibJzug57eLkEhqQ83qyCedlISyFIPZHnHfXYTJuUZq tuy5ldsL1Sunieyv3xZ+eiHYdZDvUNl7Ybx9aNrLnh64G1FKOvrjCEUaTvmsQK+5usEznpgf 50Q4bGbahCIGNBAgKwwkdS7eko0= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 60ddf3c3f3042986149733b5 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 01 Jul 2021 16:56:35 GMT Sender: okukatla=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5525CC433D3; Thu, 1 Jul 2021 16:56:34 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: okukatla) by smtp.codeaurora.org (Postfix) with ESMTPSA id B7763C433F1; Thu, 1 Jul 2021 16:56:33 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 01 Jul 2021 22:26:33 +0530 From: okukatla@codeaurora.org To: Mike Tipton Cc: djakov@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org, saravanak@google.com, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, mdtipton=codeaurora.org@codeaurora.org Subject: Re: [PATCH 1/4] interconnect: Zero initial BW after sync-state In-Reply-To: <20210625212839.24155-2-mdtipton@codeaurora.org> References: <20210625212839.24155-1-mdtipton@codeaurora.org> <20210625212839.24155-2-mdtipton@codeaurora.org> Message-ID: <14c52b496918900c9cb3bef662a9e833@codeaurora.org> X-Sender: okukatla@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-26 02:58, Mike Tipton wrote: > The initial BW values may be used by providers to enforce floors. Zero > these values after sync-state so that providers know when to stop > enforcing them. > > Fixes: b1d681d8d324 ("interconnect: Add sync state support") > Signed-off-by: Mike Tipton > --- > drivers/interconnect/core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c > index 8a1e70e00876..945121e18b5c 100644 > --- a/drivers/interconnect/core.c > +++ b/drivers/interconnect/core.c > @@ -1106,6 +1106,8 @@ void icc_sync_state(struct device *dev) > dev_dbg(p->dev, "interconnect provider is in synced state\n"); > list_for_each_entry(n, &p->nodes, node_list) { > if (n->init_avg || n->init_peak) { > + n->init_avg = 0; > + n->init_peak = 0; nit: It is good to reset init/floor levels back to zero, but we don't need to do this as we have sync_state flag to let providers know when to stop enforcing. > aggregate_requests(n); > p->set(n, n); > }