From: Jiri Slaby <jslaby@suse.cz>
To: Nick Desaulniers <ndesaulniers@google.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nathan Chancellor <nathan@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH] kbuild: pass jobserver to cmd_ld_vmlinux.o
Date: Tue, 21 Jun 2022 09:30:11 +0200 [thread overview]
Message-ID: <14c9839b-c015-69c1-84f0-a99d03877005@suse.cz> (raw)
In-Reply-To: <CAKwvOdmb5xdF70TzNp=4STCpzkGh16FnuKE1KbdzDhHt=OuRFA@mail.gmail.com>
On 17. 06. 22, 18:32, Nick Desaulniers wrote:
> On Fri, Jun 17, 2022 at 3:35 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>>
>> On Fri, Jun 17, 2022 at 12:53 AM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>>>
>>> On Thu, Jun 16, 2022 at 4:09 PM Sedat Dilek <sedat.dilek@gmail.com> wrote:
>>>>
>>>> On Thu, Jun 16, 2022 at 12:45 PM Jiri Slaby <jslaby@suse.cz> wrote:
>>>>>
>>>>> Until the link-vmlinux.sh split (cf. the commit below), the linker was
>>>>> run with jobserver set in MAKEFLAGS. After the split, the command in
>>>>> Makefile.vmlinux_o is not prefixed by "+" anymore, so this information
>>>>> is lost.
>>>>>
>>>>> Restore it as linkers working in parallel (esp. the LTO ones) make a use
>>>>> of it.
>
> TBH, I agree with Masahiro. I didn't understand this comment "esp. the
> LTO ones." Jiri, can you clarify what you mean here?
Sure. clang is not the only compiler/linker that can handle kernel ;).
So while rebasing gcc-LTO-kernel-patches to 5.19-rc (to upstream them
later), this broke. See:
https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/lto-wrapper.cc;h=26e06e77be4e0afb2bc3e913062a9c51cab5d205;hb=HEAD#l1336
gcc really parses MAKEFLAGS and looks for "--jobserver-auth=" there, if
one passes specifies -flto=jobserver.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-06-21 7:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 10:45 [PATCH] kbuild: pass jobserver to cmd_ld_vmlinux.o Jiri Slaby
2022-06-16 14:09 ` Sedat Dilek
2022-06-16 22:53 ` Sedat Dilek
2022-06-17 10:35 ` Sedat Dilek
2022-06-17 10:41 ` Sedat Dilek
2022-06-17 15:21 ` Masahiro Yamada
2022-06-17 20:05 ` Fangrui Song
2022-06-18 6:13 ` Sedat Dilek
2022-06-17 16:32 ` Nick Desaulniers
2022-06-17 17:50 ` Sedat Dilek
2022-06-17 19:34 ` Nathan Chancellor
2022-06-18 5:57 ` Sedat Dilek
2022-06-21 7:30 ` Jiri Slaby [this message]
2022-06-21 8:41 ` Masahiro Yamada
2022-09-20 8:43 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14c9839b-c015-69c1-84f0-a99d03877005@suse.cz \
--to=jslaby@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).