From: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Mel Gorman <mgorman@suse.de>, Adrian Freund <adrian@freund.io>
Subject: RE: [PATCH v2 2/2] Documentation: scheduler: ask users to set sched_debug cmdline
Date: Fri, 13 Nov 2020 11:41:57 +0000 [thread overview]
Message-ID: <14dfc49fb03f401fa1c661e22bb6e4c1@hisilicon.com> (raw)
In-Reply-To: <jhj5z69xzi7.mognet@arm.com>
> -----Original Message-----
> From: Valentin Schneider [mailto:valentin.schneider@arm.com]
> Sent: Saturday, November 14, 2020 12:34 AM
> To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com>
> Cc: corbet@lwn.net; linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org;
> Linuxarm <linuxarm@huawei.com>; Ingo Molnar <mingo@redhat.com>; Peter
> Zijlstra <peterz@infradead.org>; Mel Gorman <mgorman@suse.de>; Adrian
> Freund <adrian@freund.io>
> Subject: Re: [PATCH v2 2/2] Documentation: scheduler: ask users to set
> sched_debug cmdline
>
>
> On 12/11/20 22:31, Barry Song wrote:
> > From: Valentin Schneider <valentin.schneider@arm.com>
> >
> > To print the schedule debug information, users need to set sched_debug
> > cmdline or enable it by sysfs entry.
> >
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Mel Gorman <mgorman@suse.de>
> > Cc: Adrian Freund <adrian@freund.io>
> > Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
>
> FYI, forging SoB, or any 'tag' other than Suggested-by / Reported-by is
> frowned up. Now I do appreciate your effort to give me credit, but in this
> case you should've used Suggested-by.
As this part is actually your code, so I put an --author=" Valentin ..." in
git commit so that git can show you are the author. Actually I was not
sure if SoB was proper when I made it. My intention was only telling
people the code was from you :-)
>
> Moreso, this really is a trivial change and doesn't deserve a separate
> patch, so I would say just squash that into patch 1, and add
>
> Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
>
> to it :)
Cool, thanks.
>
> > Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
> > ---
> > Documentation/scheduler/sched-domains.rst | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/scheduler/sched-domains.rst
> b/Documentation/scheduler/sched-domains.rst
> > index 55983b7e1098..8582fa5e9170 100644
> > --- a/Documentation/scheduler/sched-domains.rst
> > +++ b/Documentation/scheduler/sched-domains.rst
> > @@ -74,6 +74,8 @@ for a given topology level by creating a
> sched_domain_topology_level array and
> > calling set_sched_topology() with this array as the parameter.
> >
> > The sched-domains debugging infrastructure can be enabled by enabling
> > -CONFIG_SCHED_DEBUG. This enables an error checking parse of the sched
> domains
> > -which should catch most possible errors (described above). It also prints out
> > -the domain structure in a visual format.
> > +CONFIG_SCHED_DEBUG and adding 'sched_debug' to your cmdline. If you
> forgot to
> > +tweak your cmdline, you can also flip the /sys/kernel/debug/sched_debug
> > +knob. This enables an error checking parse of the sched domains which
> should
> > +catch most possible errors (described above). It also prints out the domain
> > +structure in a visual format.
Thanks
Barry
prev parent reply other threads:[~2020-11-13 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 22:31 [PATCH v2 1/2] Documentation: scheduler: fix outdated information on arch SD flags and sched_domain Barry Song
2020-11-12 22:31 ` [PATCH v2 2/2] Documentation: scheduler: ask users to set sched_debug cmdline Barry Song
2020-11-13 11:34 ` Valentin Schneider
2020-11-13 11:41 ` Song Bao Hua (Barry Song) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14dfc49fb03f401fa1c661e22bb6e4c1@hisilicon.com \
--to=song.bao.hua@hisilicon.com \
--cc=adrian@freund.io \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).