From: Ross Maynard <bids.7405@bigpond.com>
To: Dave Jones <davej@codemonkey.org.uk>,
Thorsten Leemhuis <regressions@leemhuis.info>,
Bagas Sanjaya <bagasdotme@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Regressions <regressions@lists.linux.dev>,
Linux Networking <netdev@vger.kernel.org>,
Linux USB <linux-usb@vger.kernel.org>,
Oliver Neukum <oneukum@suse.com>
Subject: Re: Fwd: 3 more broken Zaurii - SL-5600, A300, C700
Date: Sat, 8 Jul 2023 22:17:07 +1000 [thread overview]
Message-ID: <14fd48c8-3955-c933-ab6f-329e54da090f@bigpond.com> (raw)
In-Reply-To: <62a9e058-c853-1fcd-5663-e2e001f881e9@bigpond.com>
[-- Attachment #1: Type: text/plain, Size: 2860 bytes --]
I applied my patch then recompiled the kernel, and the 3 devices can now
connect via USB:
[ 268.872485] usb 3-2: New USB device found, idVendor=04dd,
idProduct=8005, bcdDevice= 0.00
[ 268.872498] usb 3-2: New USB device strings: Mfr=1, Product=2,
SerialNumber=0
[ 268.872502] usb 3-2: Product: SL-A300
[ 268.872505] usb 3-2: Manufacturer: Sharp
[ 268.876526] zaurus 3-2:1.0 usb0: register 'zaurus' at
usb-0000:00:14.0-2, pseudo-MDLM (BLAN) device, fa:0f:0f:08:2b:59
[ 595.541549] usb 3-2: New USB device found, idVendor=04dd,
idProduct=8006, bcdDevice= 0.00
[ 595.541562] usb 3-2: New USB device strings: Mfr=1, Product=2,
SerialNumber=0
[ 595.541566] usb 3-2: Product: SL-5600
[ 595.541569] usb 3-2: Manufacturer: Sharp
[ 595.545148] zaurus 3-2:1.0 usb0: register 'zaurus' at
usb-0000:00:14.0-2, pseudo-MDLM (BLAN) device, fa:0f:0f:08:2b:59
[ 446.954583] usb 3-2: New USB device found, idVendor=04dd,
idProduct=8007, bcdDevice= 0.00
[ 446.954596] usb 3-2: New USB device strings: Mfr=1, Product=2,
SerialNumber=0
[ 446.954600] usb 3-2: Product: SL-C700
[ 446.954603] usb 3-2: Manufacturer: Sharp
[ 446.957871] zaurus 3-2:1.0 usb0: register 'zaurus' at
usb-0000:00:14.0-2, pseudo-MDLM (BLAN) device, fa:0f:0f:08:2b:59
Could someone please submit the patch for me?
Thanks.
Ross
On 7/7/23 10:28 pm, Ross Maynard wrote:
> Hi,
>
> I am not a kernel developer, but I think the attached patch would work.
>
> Ross
>
> On 7/7/23 2:41 am, Dave Jones wrote:
>> On Thu, Jul 06, 2023 at 01:45:57PM +0200, Thorsten Leemhuis wrote:
>> > On 06.07.23 05:08, Bagas Sanjaya wrote:
>> > >>
>> > >> I notice a regression report on Bugzilla [1]. Quoting from it:
>> > >>
>> > >>> The following patch broke support of 3 more Zaurus models:
>> SL-5600, A300 and C700
>> > >>>
>> > >>> [16adf5d07987d93675945f3cecf0e33706566005] usbnet: Remove
>> over-broad module alias from zaurus
>> >
>> > ...
>> > He sometimes shows up on Linux kernel lists, but I doubt he cares
>> about
>> > that change after all these years. And I would not blame him at all.
>>
>> That's about the size of it. This is pretty near the bottom of my
>> ever-shrinking
>> list of kernel drivers I care about.
>>
>> > Yes, we have the "no regressions" rule, but contributing a change
>> to the
>> > kernel OTOH should not mean that you are responsible for all
>> regressions
>> > it causes for your whole life. :-)
>>
>> That said, 12 years later, 16adf5d07987d93675945f3cecf0e33706566005
>> is still the right thing to do. Adding actual matches for the devices
>> rather than matching by class will prevent this getting loaded where it
>> doesn't need to be.
>>
>> If someone actually cares to get this working, cargo-culting Oliver's
>> change to add the extra id is likely the way forward.
>>
>> Dave
>>
[-- Attachment #2: 3-zaurii-patch.patch --]
[-- Type: text/x-patch, Size: 3180 bytes --]
diff -urpN a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
--- a/drivers/net/usb/cdc_ether.c 2023-07-07 17:48:27.991833366 +1000
+++ b/drivers/net/usb/cdc_ether.c 2023-07-07 21:53:11.556198087 +1000
@@ -616,6 +616,13 @@ static const struct usb_device_id produc
}, {
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO
| USB_DEVICE_ID_MATCH_DEVICE,
+ .idVendor = 0x04DD,
+ .idProduct = 0x8005, /* A-300 */
+ ZAURUS_FAKE_INTERFACE,
+ .driver_info = 0,
+}, {
+ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
+ | USB_DEVICE_ID_MATCH_DEVICE,
.idVendor = 0x04DD,
.idProduct = 0x8006, /* B-500/SL-5600 */
ZAURUS_MASTER_INTERFACE,
@@ -623,12 +630,26 @@ static const struct usb_device_id produc
}, {
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO
| USB_DEVICE_ID_MATCH_DEVICE,
+ .idVendor = 0x04DD,
+ .idProduct = 0x8006, /* B-500/SL-5600 */
+ ZAURUS_FAKE_INTERFACE,
+ .driver_info = 0,
+}, {
+ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
+ | USB_DEVICE_ID_MATCH_DEVICE,
.idVendor = 0x04DD,
.idProduct = 0x8007, /* C-700 */
ZAURUS_MASTER_INTERFACE,
.driver_info = 0,
}, {
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO
+ | USB_DEVICE_ID_MATCH_DEVICE,
+ .idVendor = 0x04DD,
+ .idProduct = 0x8007, /* C-700 */
+ ZAURUS_FAKE_INTERFACE,
+ .driver_info = 0,
+}, {
+ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
| USB_DEVICE_ID_MATCH_DEVICE,
.idVendor = 0x04DD,
.idProduct = 0x9031, /* C-750 C-760 */
diff -urpN a/drivers/net/usb/zaurus.c b/drivers/net/usb/zaurus.c
--- a/drivers/net/usb/zaurus.c 2023-07-07 17:48:28.043849110 +1000
+++ b/drivers/net/usb/zaurus.c 2023-07-07 22:06:49.267699853 +1000
@@ -289,11 +289,25 @@ static const struct usb_device_id produc
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO
| USB_DEVICE_ID_MATCH_DEVICE,
.idVendor = 0x04DD,
+ .idProduct = 0x8005, /* A-300 */
+ ZAURUS_FAKE_INTERFACE,
+ .driver_info = (unsigned long) &bogus_mdlm_info,
+}, {
+ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
+ | USB_DEVICE_ID_MATCH_DEVICE,
+ .idVendor = 0x04DD,
.idProduct = 0x8006, /* B-500/SL-5600 */
ZAURUS_MASTER_INTERFACE,
.driver_info = ZAURUS_PXA_INFO,
}, {
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO
+ | USB_DEVICE_ID_MATCH_DEVICE,
+ .idVendor = 0x04DD,
+ .idProduct = 0x8006, /* B-500/SL-5600 */
+ ZAURUS_FAKE_INTERFACE,
+ .driver_info = (unsigned long) &bogus_mdlm_info,
+}, {
+ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
| USB_DEVICE_ID_MATCH_DEVICE,
.idVendor = 0x04DD,
.idProduct = 0x8007, /* C-700 */
@@ -301,6 +315,13 @@ static const struct usb_device_id produc
.driver_info = ZAURUS_PXA_INFO,
}, {
.match_flags = USB_DEVICE_ID_MATCH_INT_INFO
+ | USB_DEVICE_ID_MATCH_DEVICE,
+ .idVendor = 0x04DD,
+ .idProduct = 0x8007, /* C-700 */
+ ZAURUS_FAKE_INTERFACE,
+ .driver_info = (unsigned long) &bogus_mdlm_info,
+}, {
+ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
| USB_DEVICE_ID_MATCH_DEVICE,
.idVendor = 0x04DD,
.idProduct = 0x9031, /* C-750 C-760 */
next prev parent reply other threads:[~2023-07-08 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 2:09 Fwd: 3 more broken Zaurii - SL-5600, A300, C700 Bagas Sanjaya
2023-07-06 3:08 ` Bagas Sanjaya
2023-07-06 11:45 ` Thorsten Leemhuis
2023-07-06 16:41 ` Dave Jones
2023-07-07 12:28 ` Ross Maynard
2023-07-08 12:17 ` Ross Maynard [this message]
2023-07-08 20:49 ` Andrew Lunn
2023-07-09 4:36 ` Linux regression tracking (Thorsten Leemhuis)
2023-07-10 16:55 ` Jakub Kicinski
2023-07-10 17:09 ` Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14fd48c8-3955-c933-ab6f-329e54da090f@bigpond.com \
--to=bids.7405@bigpond.com \
--cc=bagasdotme@gmail.com \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).