From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: lduncan@suse.com, cleech@redhat.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com
Cc: open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] scsi: scsi_transport_spi: constify attribute_group structures.
Date: Fri, 14 Jul 2017 13:53:30 +0530 [thread overview]
Message-ID: <1500020610-15973-5-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1500020610-15973-1-git-send-email-arvind.yadav.cs@gmail.com>
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/attribute_container.h>
and <linux/sysfs.h> work with const attribute_group. So mark the non-const
structs as const.
File size before:
text data bss dec hex filename
15444 1616 0 17060 42a4 drivers/scsi/scsi_transport_spi.o
File size After adding 'const':
text data bss dec hex filename
15572 1488 0 17060 42a4 drivers/scsi/scsi_transport_spi.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/scsi/scsi_transport_spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c
index d0219e3..ec723b2 100644
--- a/drivers/scsi/scsi_transport_spi.c
+++ b/drivers/scsi/scsi_transport_spi.c
@@ -1426,7 +1426,7 @@ static DECLARE_ANON_TRANSPORT_CLASS(spi_device_class,
NULL
};
-static struct attribute_group host_attribute_group = {
+static const struct attribute_group host_attribute_group = {
.attrs = host_attributes,
};
@@ -1536,7 +1536,7 @@ static umode_t target_attribute_is_visible(struct kobject *kobj,
NULL
};
-static struct attribute_group target_attribute_group = {
+static const struct attribute_group target_attribute_group = {
.attrs = target_attributes,
.is_visible = target_attribute_is_visible,
};
--
1.9.1
prev parent reply other threads:[~2017-07-14 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 8:23 [PATCH 0/4] constify scsi attribute_group structures Arvind Yadav
2017-07-14 8:23 ` [PATCH 1/4] scsi: scsi_transport_iscsi: constify " Arvind Yadav
2017-07-14 8:23 ` [PATCH 2/4] scsi: iscsi_boot_sysfs: " Arvind Yadav
2017-07-14 8:23 ` [PATCH 3/4] scsi: scsi_transport_fc: " Arvind Yadav
2017-07-14 8:23 ` Arvind Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500020610-15973-5-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).