From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754775AbdGNQmx (ORCPT ); Fri, 14 Jul 2017 12:42:53 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:58542 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754089AbdGNQmu (ORCPT ); Fri, 14 Jul 2017 12:42:50 -0400 Message-ID: <1500050552.2707.145.camel@decadent.org.uk> Subject: Re: [PATCH 3.18 36/68] Handle mismatched open calls From: Ben Hutchings To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Sachin Prabhu Cc: stable@vger.kernel.org, Pavel Shilovsky Date: Fri, 14 Jul 2017 17:42:32 +0100 In-Reply-To: <20170505183214.050929158@linuxfoundation.org> References: <20170505183212.587141964@linuxfoundation.org> <20170505183214.050929158@linuxfoundation.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-O+R4pZGqHyxMq6VEobEU" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-O+R4pZGqHyxMq6VEobEU Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2017-05-05 at 11:32 -0700, Greg Kroah-Hartman wrote: > 3.18-stable review patch.=C2=A0=C2=A0If anyone has any objections, please= let me know. >=20 > ------------------ >=20 > From: Sachin Prabhu >=20 > commit 38bd49064a1ecb67baad33598e3d824448ab11ec upstream. [...] > --- a/fs/cifs/smb2ops.c > +++ b/fs/cifs/smb2ops.c > @@ -1461,6 +1461,8 @@ struct smb_version_operations smb21_oper > =C2=A0 .clear_stats =3D smb2_clear_stats, > =C2=A0 .print_stats =3D smb2_print_stats, > =C2=A0 .is_oplock_break =3D smb2_is_valid_oplock_break, > + .handle_cancelled_mid =3D smb2_handle_cancelled_mid, > + .handle_cancelled_mid =3D smb2_handle_cancelled_mid, > =C2=A0 .downgrade_oplock =3D smb2_downgrade_oplock, > =C2=A0 .need_neg =3D smb2_need_neg, > =C2=A0 .negotiate =3D smb2_negotiate, > @@ -1542,6 +1544,8 @@ struct smb_version_operations smb30_oper > =C2=A0 .print_stats =3D smb2_print_stats, > =C2=A0 .dump_share_caps =3D smb2_dump_share_caps, > =C2=A0 .is_oplock_break =3D smb2_is_valid_oplock_break, > + .handle_cancelled_mid =3D smb2_handle_cancelled_mid, > + .handle_cancelled_mid =3D smb2_handle_cancelled_mid, > =C2=A0 .downgrade_oplock =3D smb2_downgrade_oplock, > =C2=A0 .need_neg =3D smb2_need_neg, > =C2=A0 .negotiate =3D smb2_negotiate, [...] This doesn't look right. handle_cancelled_mid should be initialised once in each of the 3 smb_version_operations structures, shouldn't it? Ben. --=20 Ben Hutchings If the facts do not conform to your theory, they must be disposed of. --=-O+R4pZGqHyxMq6VEobEU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAllo9HgACgkQ57/I7JWG EQkq6w/+MnTh/Ig+n7dL1Xoh2ZH23PzI549nnNsNTBYm75lEXNFp0Z3ue6Q/X/hT XkDXMp+Gk3B/rFwv/zqSOBKW6yQZaa5oNiLOYSzqPSGIDR2L8dbF4+6ALdoxUZ/f MZifWiZfTaz64pH9l1Elm7yF9k2oXapgGpvBnj56/egL5+XQJlBiLiOH3td/vatL wyjsSLU+4hS+jDag8iYk1Gcq3/luBBcxzzx9unaEObOue0rOStAgHwC0AR9j59DA 9LSeALBfOigI+ugpfkErwWeK0zK3Cz3CmVeHsK3wO/Ke8DY1HBgAJwfRLCNaTnIk TEe7QOEnli2wQ1WCi8wCs3D3Flo4QT6YXw48JBcIKaVZp42m1Gd/jHadqzTQREmj 12nGz2j+6/aNg/ZCELDeq6rigvw4BzuD7H2X6ITFjzXcwchjLZ5bJnnc4ZtuZ4Oq Ak4kf2phQO2p7TumcZxlDC/FkDafVMJUVcfsUMA8urNQ3DDZTgnCmVhcMzmH5NbV jsUV1Lar98Q3VFqqrO65WsYlobj+MshvlBW56nxCRu6SSsbhqCbhNI9wv20/Q8jp a73kNExos+qX39dunN1+fKVS8dwPeOwRzg7dCBSg4nVoEd6nSKYLQWl7PTDl6fy/ /JHwbqcWwvYhNAgRFWXEk9XycMWHlCHV2v+2gknDkYi4HRfHtO0= =wcRI -----END PGP SIGNATURE----- --=-O+R4pZGqHyxMq6VEobEU--