From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "H . J . Lu" <hjl@valinux.com>
Cc: NFS maillist <nfs@lists.sourceforge.net>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [NFS] Updated patch for the [2.4.x] NFS 'missing directory entry a.k.a. IRIX server' problem...
Date: Wed, 28 Feb 2001 12:19:04 +0100 (CET) [thread overview]
Message-ID: <15004.57000.33634.592757@charged.uio.no> (raw)
In-Reply-To: <20010227152437.A18517@valinux.com>
In-Reply-To: <14997.9938.106305.635202@charged.uio.no> <20010227150432.A18066@valinux.com> <20010227152437.A18517@valinux.com>
>>>>> " " == H J Lu <hjl@valinux.com> writes:
> On Tue, Feb 27, 2001 at 03:04:32PM -0800, H . J . Lu wrote:
>> > entry->prev_cookie = entry->cookie;
>> > - p = xdr_decode_hyper(p, &entry->cookie);
>> > + p = xdr_decode_hyper(p, cookie);
>> > + entry->cookie = nfs_transform_cookie64(cookie);
>>
>> I don't understand this. As far as I can tell, "cookie" is not
>> initialized at all. Even if it is initialized, what does
>>
>> p = xdr_decode_hyper(p, cookie);
>>
> Trond, I think you missed
> p = xdr_decode_hyper(p, &cookie);
> ^
Oops. You're quite right. As far as I can see, this bug seems to have
crept in when I created the patch itself. My own source has the
correct dereference, hence I didn't see any errors.
I've also updated the copy on http://www.fys.uio.no/~trondmy/src/2.4.2
Thanks,
Trond
prev parent reply other threads:[~2001-02-28 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-22 14:48 Updated patch for the [2.4.x] NFS 'missing directory entry a.k.a. IRIX server' problem Trond Myklebust
2001-02-26 23:28 ` [NFS] " H . J . Lu
2001-02-27 6:57 ` Trond Myklebust
2001-02-27 7:06 ` H . J . Lu
2001-02-27 7:41 ` Trond Myklebust
2001-02-27 19:12 ` Jamie Lokier
2001-02-27 23:04 ` H . J . Lu
2001-02-27 23:24 ` H . J . Lu
2001-02-28 11:19 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15004.57000.33634.592757@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=hjl@valinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).