From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346AbdG2VY5 (ORCPT ); Sat, 29 Jul 2017 17:24:57 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:12708 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146AbdG2VYz (ORCPT ); Sat, 29 Jul 2017 17:24:55 -0400 X-IronPort-AV: E=Sophos;i="5.40,433,1496073600"; d="scan'208";a="37964986" From: Bart Van Assche To: "dan.j.williams@intel.com" CC: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "snitzer@redhat.com" , "hch@lst.de" , "toshi.kani@hpe.com" , "linux-nvdimm@lists.01.org" , "linux-fsdevel@vger.kernel.org" , "dm-devel@redhat.com" Subject: Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support Thread-Topic: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support Thread-Index: AQHSt68N9Qj1Xbxua02B9V2ggfYo66JqCoeAgAHP34CAABg+gA== Date: Sat, 29 Jul 2017 21:24:07 +0000 Message-ID: <1501363445.3005.1.camel@wdc.com> References: <149245612770.10206.15496018295337908594.stgit@dwillia2-desk3.amr.corp.intel.com> <149245618859.10206.13182319600260215993.stgit@dwillia2-desk3.amr.corp.intel.com> <1501258623.2413.3.camel@wdc.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [73.223.62.206] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN3PR0401MB1527;20:e9EARCCkt6rcai7bWL0xqf95PbYviXR5QJrhaau/9OiTTUy2sk4WBC/uVvo0ymjEH/SG/L/EC09M+GunwDg15kx25szyMV4m1pAaVC1KHeS996TUvZblPr+dHVtui5aBR50Wt8IMW682uO9Vkb3fT8BEO7rLbACkjDGsuKx90LI= x-ms-office365-filtering-correlation-id: c9351155-3aa6-4500-175b-08d4d6c82562 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254147)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN3PR0401MB1527; x-ms-traffictypediagnostic: BN3PR0401MB1527: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN3PR0401MB1527;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN3PR0401MB1527; x-forefront-prvs: 03838E948C x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39850400002)(39400400002)(39450400003)(39860400002)(39410400002)(39840400002)(189002)(377424004)(24454002)(199003)(377454003)(53936002)(99286003)(5660300001)(7736002)(66066001)(5640700003)(2906002)(3280700002)(54906002)(3660700001)(6436002)(6512007)(305945005)(103116003)(6506006)(110136004)(36756003)(38730400002)(93886004)(6246003)(77096006)(6486002)(2900100001)(229853002)(2501003)(72206003)(189998001)(8676002)(81166006)(81156014)(14454004)(6916009)(2950100002)(68736007)(8936002)(53546010)(97736004)(102836003)(478600001)(25786009)(6116002)(86362001)(50986999)(54356999)(105586002)(106356001)(33646002)(101416001)(2351001)(76176999)(3846002)(4326008);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0401MB1527;H:BN3PR0401MB1527.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <075CB57016976D449B7B56C037AF491A@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2017 21:24:07.3977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0401MB1527 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v6TLP26v026399 On Sat, 2017-07-29 at 12:57 -0700, Dan Williams wrote: > On Fri, Jul 28, 2017 at 9:17 AM, Bart Van Assche wrote: > > On Mon, 2017-04-17 at 12:09 -0700, Dan Williams wrote: > > > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig > > > index b7767da50c26..1de8372d9459 100644 > > > --- a/drivers/md/Kconfig > > > +++ b/drivers/md/Kconfig > > > @@ -200,6 +200,7 @@ config BLK_DEV_DM_BUILTIN > > > config BLK_DEV_DM > > > tristate "Device mapper support" > > > select BLK_DEV_DM_BUILTIN > > > + select DAX > > > ---help--- > > > Device-mapper is a low level volume manager. It works by allowing > > > people to specify mappings for ranges of logical sectors. Various > > > > (replying to an e-mail of three months ago) > > > > Hello Dan, > > > > While building a v4.12 kernel I noticed that enabling device mapper support > > now unconditionally enables DAX. I think there are plenty of systems that use > > dm but do not need DAX. Have you considered to rework this such that instead > > of dm selecting DAX that DAX support is only enabled in dm if CONFIG_DAX is > > enabled? > > I'd rather flip this around and add a CONFIG_DM_DAX that gates whether > DM enables / links to the DAX core. I'll take a look at a patch. Thanks! Please also consider to move all DAX-related dm code into a separate source file such that the number of #ifdef CONFIG_DM_DAX statements can be kept to an absolute minimum. Bart.