From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbdHGLfS (ORCPT ); Mon, 7 Aug 2017 07:35:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:57234 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752997AbdHGLfR (ORCPT ); Mon, 7 Aug 2017 07:35:17 -0400 Message-ID: <1502105549.1909.8.camel@suse.com> Subject: Re: [PATCH] usb: quirks: Add no-lpm quirk for Moshi USB to Ethernet Adapter From: Oliver Neukum To: Kai-Heng Feng Cc: gregkh@linuxfoundation.org, Alan Stern , LKML , USB list Date: Mon, 07 Aug 2017 13:32:29 +0200 In-Reply-To: References: <20170804093419.13958-1-kai.heng.feng@canonical.com> <1502096904.1909.5.camel@suse.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, den 07.08.2017, 17:33 +0800 schrieb Kai-Heng Feng: > On Mon, Aug 7, 2017 at 5:08 PM, Oliver Neukum wrote: > > > > Am Freitag, den 04.08.2017, 17:34 +0800 schrieb Kai-Heng Feng: > > > > > > The Realtek r8153 ethernet does not work on Genesys Logic hub, no-lpm > > > quirk can make it work. > > > > So can you confirm it works with LPM on another hub? > > Yes, another r8153 dongle (Dell Type-C to Ethernet) does not have this issue. OK. > > > > > > > > > > Since another r8153 dongle at my hand does not have the issue, so add > > > the quirk to the hub instead. > > > > This does not match the comment in the patch. This needs to > > be clarified. > > The Moshi USB to Ethernet Adapter internally has a Genesys Logic hub. > Ethernet chip r8153 is connected to the Genesys Logic hub. > > I'll resend a patch with this information if it's clear enough. Thanks. The piece about an internal hub was missing. Regards Oliver