From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: alsa-devel@alsa-project.org, xen-devel@lists.xen.org,
linux-kernel@vger.kernel.org
Cc: perex@perex.cz, tiwai@suse.com, andr2000@gmail.com,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [PATCH RESEND1 03/12] ALSA: vsnd: Implement Xen bus state handling
Date: Mon, 7 Aug 2017 15:22:48 +0300 [thread overview]
Message-ID: <1502108577-8099-4-git-send-email-andr2000@gmail.com> (raw)
In-Reply-To: <1502108577-8099-1-git-send-email-andr2000@gmail.com>
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Initial handling for Xen bus states: implement
Xen bus state machine for the front driver according to
the state diagram and recovery flow from sound para-virtualized
protocol: xen/interface/io/sndif.h.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
sound/drivers/xen-front.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 92 insertions(+)
diff --git a/sound/drivers/xen-front.c b/sound/drivers/xen-front.c
index 8c5de7b0e7b5..c4fd21cac3a7 100644
--- a/sound/drivers/xen-front.c
+++ b/sound/drivers/xen-front.c
@@ -36,9 +36,99 @@ static void xdrv_remove_internal(struct xdrv_info *drv_info)
{
}
+static int xdrv_be_on_initwait(struct xdrv_info *drv_info)
+{
+ return 0;
+}
+
+static inline int xdrv_be_on_connected(struct xdrv_info *drv_info)
+{
+ return 0;
+}
+
+static inline void xdrv_be_on_disconnected(struct xdrv_info *drv_info)
+{
+ xdrv_remove_internal(drv_info);
+}
+
static void xdrv_be_on_changed(struct xenbus_device *xb_dev,
enum xenbus_state backend_state)
{
+ struct xdrv_info *drv_info = dev_get_drvdata(&xb_dev->dev);
+ int ret;
+
+ switch (backend_state) {
+ case XenbusStateReconfiguring:
+ /* fall through */
+ case XenbusStateReconfigured:
+ /* fall through */
+ case XenbusStateInitialised:
+ /* fall through */
+ break;
+
+ case XenbusStateInitialising:
+ if (xb_dev->state == XenbusStateInitialising)
+ break;
+
+ /* recovering after backend unexpected closure */
+ mutex_lock(&drv_info->mutex);
+ xdrv_be_on_disconnected(drv_info);
+ mutex_unlock(&drv_info->mutex);
+ xenbus_switch_state(xb_dev, XenbusStateInitialising);
+ break;
+
+ case XenbusStateInitWait:
+ if (xb_dev->state != XenbusStateInitialising)
+ break;
+
+ mutex_lock(&drv_info->mutex);
+ ret = xdrv_be_on_initwait(drv_info);
+ mutex_unlock(&drv_info->mutex);
+ if (ret < 0) {
+ xenbus_dev_fatal(xb_dev, ret,
+ "initializing " XENSND_DRIVER_NAME);
+ break;
+ }
+
+ xenbus_switch_state(xb_dev, XenbusStateInitialised);
+ break;
+
+ case XenbusStateConnected:
+ if (xb_dev->state != XenbusStateInitialised)
+ break;
+
+ mutex_lock(&drv_info->mutex);
+ ret = xdrv_be_on_connected(drv_info);
+ mutex_unlock(&drv_info->mutex);
+ if (ret < 0) {
+ xenbus_dev_fatal(xb_dev, ret,
+ "connecting " XENSND_DRIVER_NAME);
+ break;
+ }
+
+ xenbus_switch_state(xb_dev, XenbusStateConnected);
+ break;
+
+ case XenbusStateClosing:
+ /*
+ * in this state backend starts freeing resources,
+ * so let it go into closed state first, so we can also
+ * remove ours
+ */
+ break;
+
+ case XenbusStateUnknown:
+ /* fall through */
+ case XenbusStateClosed:
+ if (xb_dev->state == XenbusStateClosed)
+ break;
+
+ mutex_lock(&drv_info->mutex);
+ xdrv_be_on_disconnected(drv_info);
+ mutex_unlock(&drv_info->mutex);
+ xenbus_switch_state(xb_dev, XenbusStateInitialising);
+ break;
+ }
}
static int xdrv_probe(struct xenbus_device *xb_dev,
@@ -56,6 +146,7 @@ static int xdrv_probe(struct xenbus_device *xb_dev,
spin_lock_init(&drv_info->io_lock);
mutex_init(&drv_info->mutex);
dev_set_drvdata(&xb_dev->dev, drv_info);
+ xenbus_switch_state(xb_dev, XenbusStateInitialising);
return 0;
}
@@ -63,6 +154,7 @@ static int xdrv_remove(struct xenbus_device *dev)
{
struct xdrv_info *drv_info = dev_get_drvdata(&dev->dev);
+ xenbus_switch_state(dev, XenbusStateClosed);
mutex_lock(&drv_info->mutex);
xdrv_remove_internal(drv_info);
mutex_unlock(&drv_info->mutex);
--
2.7.4
next prev parent reply other threads:[~2017-08-07 12:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 12:22 [PATCH RESEND1 00/12] ALSA: vsnd: Add Xen para-virtualized frontend driver Oleksandr Andrushchenko
2017-08-07 12:22 ` [PATCH RESEND1 01/12] ALSA: vsnd: Introduce Xen para-virtualized sound " Oleksandr Andrushchenko
2017-08-07 12:22 ` [PATCH RESEND1 02/12] ALSA: vsnd: Implement driver's probe/remove Oleksandr Andrushchenko
2017-08-07 12:22 ` Oleksandr Andrushchenko [this message]
2017-08-07 12:22 ` [PATCH RESEND1 04/12] ALSA: vsnd: Read sound driver configuration from Xen store Oleksandr Andrushchenko
2017-08-07 12:22 ` [PATCH RESEND1 05/12] ALSA: vsnd: Implement Xen event channel handling Oleksandr Andrushchenko
2017-08-07 12:22 ` [PATCH RESEND1 06/12] ALSA: vsnd: Implement handling of shared buffers Oleksandr Andrushchenko
2017-08-07 12:22 ` [PATCH RESEND1 07/12] ALSA: vsnd: Introduce ALSA virtual sound driver Oleksandr Andrushchenko
2017-08-07 12:22 ` [PATCH RESEND1 08/12] ALSA: vsnd: Initialize virtul sound card Oleksandr Andrushchenko
2017-08-07 12:22 ` [PATCH RESEND1 09/12] ALSA: vsnd: Add timer for period interrupt emulation Oleksandr Andrushchenko
2017-08-07 12:22 ` [PATCH RESEND1 10/12] ALSA: vsnd: Implement ALSA PCM operations Oleksandr Andrushchenko
2017-08-07 12:22 ` [PATCH RESEND1 11/12] ALSA: vsnd: Implement communication with backend Oleksandr Andrushchenko
2017-08-07 12:22 ` [PATCH RESEND1 12/12] ALSA: vsnd: Introduce Kconfig option to enable Xen PV sound Oleksandr Andrushchenko
2017-08-10 3:14 ` [PATCH RESEND1 00/12] ALSA: vsnd: Add Xen para-virtualized frontend driver Takashi Sakamoto
2017-08-10 8:10 ` Oleksandr Andrushchenko
2017-08-17 10:05 ` [Xen-devel] " Oleksandr Grytsov
2017-08-18 5:43 ` Takashi Sakamoto
2017-08-18 5:56 ` Oleksandr Andrushchenko
2017-08-18 7:17 ` Takashi Sakamoto
2017-08-18 7:23 ` Oleksandr Andrushchenko
2017-08-22 2:43 ` Takashi Sakamoto
2017-08-23 14:51 ` Oleksandr Grytsov
2017-08-24 4:38 ` Takashi Sakamoto
2017-08-24 7:04 ` Oleksandr Andrushchenko
2017-09-04 7:21 ` Oleksandr Andrushchenko
2017-09-05 7:24 ` [alsa-devel] " Clemens Ladisch
2017-09-12 7:52 ` Oleksandr Grytsov
2017-09-19 8:57 ` Oleksandr Andrushchenko
2017-09-26 11:35 ` Oleksandr Andrushchenko
2017-10-04 6:50 ` Oleksandr Andrushchenko
2017-10-13 6:15 ` Oleksandr Andrushchenko
2017-10-30 6:33 ` [RFC] " Oleksandr Andrushchenko
2017-11-02 9:44 ` Takashi Sakamoto
2017-11-02 9:55 ` Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502108577-8099-4-git-send-email-andr2000@gmail.com \
--to=andr2000@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).