From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: lenb@kernel.org, linux-pm@vger.kernel.org,
mario.limonciello@dell.com, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, lukas@wunner.de
Subject: Re: [PATCH v2 2/2] ACPI / Sleep: Check low power idle constraints for debug only
Date: Wed, 09 Aug 2017 17:50:55 -0700 [thread overview]
Message-ID: <1502326255.4234.35.camel@linux.intel.com> (raw)
In-Reply-To: <2200531.jeIBytVRuy@aspire.rjw.lan>
On Thu, 2017-08-10 at 01:17 +0200, Rafael J. Wysocki wrote:
> On Wednesday, August 9, 2017 12:41:15 AM CEST Srinivas Pandruvada
> wrote:
> >
> > For SoC to achieve its lowest power platform idle state a set of
> > hardware
> > preconditions must be met. These preconditions or constraints can
> > be
> > obtained by issuing a device specific method (_DSM) with function
> > "1".
> > Refer to the document provided in the link below.
> >
> > Here during initialization (from attach() callback of LPS0 device),
> > invoke
> > function 1 to get the device constraints. Each enabled constraint
> > is
> > stored in a table.
> >
> > The devices in this table are used to check whether they were in
> > required
> > minimum state, while entering suspend. This check is done from
> > platform
> > freeze wake() callback, only when /sys/power/pm_debug_messages
> > attribute
> > is non zero.
> >
> > If any constraint is not met and device is ACPI power managed then
> > it
> > prints the device name to kernel logs.
> >
> > Also if debug is enabled in acpi/sleep.c, the constraint table and
> > state
> > of each device on wake is dumped in kernel logs.
> >
> > Link: http://www.uefi.org/sites/default/files/resources/Intel_ACPI_
> > Low_Power_S0_Idle.pdf
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel
> > .com>
> > ---
> > drivers/acpi/sleep.c | 162
> > +++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 162 insertions(+)
> >
> > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> > index 2b881de..b3ef577 100644
> > --- a/drivers/acpi/sleep.c
> > +++ b/drivers/acpi/sleep.c
> > @@ -669,6 +669,7 @@ static const struct acpi_device_id
> > lps0_device_ids[] = {
> [cut]
>
> >
> >
> > @@ -773,6 +933,8 @@ static void acpi_freeze_wake(void)
> > */
> > if (acpi_sci_irq_valid() &&
> > !irqd_is_wakeup_armed(irq_get_irq_data(acpi_sci_irq)))
> > {
> > + if (pm_debug_messages_enabled())
> > + lpi_check_constraints();
> I'm not sure why you only want to check the constraints when we do
> the
> _cancel_wakeup() thing.
>
> IMO the check is relevant regardless of whether or not the wakeup was
> via ACPI.
OK. I will move out of this if block.
Thanks,
Srinivas
>
> >
> > pm_system_cancel_wakeup();
> > s2idle_wakeup = true;
> > }
> >
>
next prev parent reply other threads:[~2017-08-10 0:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 22:41 [PATCH v2 0/2] ACPI: Low power idle constraints check Srinivas Pandruvada
2017-08-08 22:41 ` [PATCH v2 1/2] PM / sleep: Export the setting of pm_debug_messages_on Srinivas Pandruvada
2017-08-08 22:41 ` [PATCH v2 2/2] ACPI / Sleep: Check low power idle constraints for debug only Srinivas Pandruvada
2017-08-09 23:17 ` Rafael J. Wysocki
2017-08-10 0:50 ` Srinivas Pandruvada [this message]
2017-08-10 22:07 ` Mario.Limonciello
2017-08-10 22:54 ` Srinivas Pandruvada
2017-08-11 14:43 ` Mario.Limonciello
2017-08-11 16:18 ` Srinivas Pandruvada
2017-08-12 14:07 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502326255.4234.35.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mario.limonciello@dell.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).