From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752151AbdHKBdK (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Aug 2017 21:33:10 -0400
Received: from imap0.codethink.co.uk ([185.43.218.159]:49574 "EHLO
        imap0.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751373AbdHKBdJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Aug 2017 21:33:09 -0400
Message-ID: <1502415185.2047.29.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 01/58] parisc: Increase thread and stack size to 32kb
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Helge Deller <deller@gmx.de>
Date: Fri, 11 Aug 2017 02:33:05 +0100
In-Reply-To: <20170809194146.557693970@linuxfoundation.org>
References: <20170809194146.501519882@linuxfoundation.org>
         <20170809194146.557693970@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-08-09 at 12:41 -0700, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Helge Deller <deller@gmx.de>
> 
> commit 8f8201dfed91a43ac38c899c82f81eef3d36afd9 upstream.
> 
> Since kernel 4.11 the thread and irq stacks on parisc randomly overflow
> the default size of 16k. The reason why stack usage suddenly grew is yet
> unknown.

So we don't need this for 4.4.

Ben.

> Signed-off-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> ---
>  arch/parisc/include/asm/thread_info.h |    2 +-
>  arch/parisc/kernel/irq.c              |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/arch/parisc/include/asm/thread_info.h
> +++ b/arch/parisc/include/asm/thread_info.h
> @@ -34,7 +34,7 @@ struct thread_info {
>  
>  /* thread information allocation */
>  
> -#define THREAD_SIZE_ORDER	2 /* PA-RISC requires at least 16k stack */
> +#define THREAD_SIZE_ORDER	3 /* PA-RISC requires at least 32k stack */
>  /* Be sure to hunt all references to this down when you change the size of
>   * the kernel stack */
>  #define THREAD_SIZE             (PAGE_SIZE << THREAD_SIZE_ORDER)
> --- a/arch/parisc/kernel/irq.c
> +++ b/arch/parisc/kernel/irq.c
> @@ -380,7 +380,7 @@ static inline int eirr_to_irq(unsigned l
>  /*
>   * IRQ STACK - used for irq handler
>   */
> -#define IRQ_STACK_SIZE      (4096 << 2) /* 16k irq stack size */
> +#define IRQ_STACK_SIZE      (4096 << 3) /* 32k irq stack size */
>  
>  union irq_stack_union {
>  	unsigned long stack[IRQ_STACK_SIZE/sizeof(unsigned long)];
> 
> 

-- 
Ben Hutchings
Software Developer, Codethink Ltd.