From: Chen Zhong <chen.zhong@mediatek.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Eddie Huang <eddie.huang@mediatek.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Jaechul Lee <jcsing.lee@samsung.com>,
Jonathan Cameron <jic23@kernel.org>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Beomho Seo <beomho.seo@samsung.com>,
<linux-input@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-rtc@vger.kernel.org>
Subject: Re: [PATCH v2 5/5] mfd: mt6397: Add PMIC keys support to MT6397 driver
Date: Fri, 11 Aug 2017 15:18:28 +0800 [thread overview]
Message-ID: <1502435908.28466.21.camel@mhfsdcap03> (raw)
In-Reply-To: <20170808111556.dmx2s6bcwnsccrkn@dell>
On Tue, 2017-08-08 at 12:15 +0100, Lee Jones wrote:
> On Mon, 07 Aug 2017, Chen Zhong wrote:
>
> > This patch adds compatible strings and interrupts for pmic keys
> > which serves as child device of MFD.
> >
> > Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>
> > ---
> > drivers/mfd/mt6397-core.c | 36 +++++++++++++++++++++++++++++++++++-
> > 1 file changed, 35 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> > index 6546d7f..3c6a765 100644
> > --- a/drivers/mfd/mt6397-core.c
> > +++ b/drivers/mfd/mt6397-core.c
> > @@ -43,6 +43,30 @@
> > },
> > };
> >
> > +static const struct resource mt6323_keys_resources[] = {
> > + {
> > + .start = MT6323_IRQ_STATUS_PWRKEY,
> > + .end = MT6323_IRQ_STATUS_PWRKEY,
> > + .flags = IORESOURCE_IRQ,
> > + }, {
> > + .start = MT6323_IRQ_STATUS_FCHRKEY,
> > + .end = MT6323_IRQ_STATUS_FCHRKEY,
> > + .flags = IORESOURCE_IRQ,
> > + },
> > +};
> > +
> > +static const struct resource mt6397_keys_resources[] = {
> > + {
> > + .start = MT6397_IRQ_PWRKEY,
> > + .end = MT6397_IRQ_PWRKEY,
> > + .flags = IORESOURCE_IRQ,
> > + }, {
> > + .start = MT6397_IRQ_HOMEKEY,
> > + .end = MT6397_IRQ_HOMEKEY,
> > + .flags = IORESOURCE_IRQ,
> > + },
> > +};
>
> We have better ways to define these now.
>
> Please grep for "DEFINE_RES_"
I'll define these with "DEFINE_RES_IRQ" here, Thank you for your
suggestion.
>
> > static const struct mfd_cell mt6323_devs[] = {
> > {
> > .name = "mt6323-regulator",
> > @@ -50,6 +74,11 @@
> > }, {
> > .name = "mt6323-led",
> > .of_compatible = "mediatek,mt6323-led"
> > + }, {
> > + .name = "mtk-pmic-keys",
> > + .num_resources = ARRAY_SIZE(mt6323_keys_resources),
> > + .resources = mt6323_keys_resources,
> > + .of_compatible = "mediatek,mt6323-keys"
> > },
> > };
> >
> > @@ -71,7 +100,12 @@
> > }, {
> > .name = "mt6397-pinctrl",
> > .of_compatible = "mediatek,mt6397-pinctrl",
> > - },
> > + }, {
> > + .name = "mtk-pmic-keys",
> > + .num_resources = ARRAY_SIZE(mt6397_keys_resources),
> > + .resources = mt6397_keys_resources,
> > + .of_compatible = "mediatek,mt6397-keys"
> > + }
> > };
> >
> > static void mt6397_irq_lock(struct irq_data *data)
>
prev parent reply other threads:[~2017-08-11 7:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 1:57 [PATCH v2 0/5] Add MediaTek PMIC keys support Chen Zhong
2017-08-07 1:57 ` [PATCH v2 1/5] mfd: mt6397: create irq mappings in mfd core driver Chen Zhong
2017-08-07 21:32 ` Alexandre Belloni
2017-08-08 2:53 ` Dmitry Torokhov
2017-08-08 9:09 ` Chen Zhong
2017-08-08 11:14 ` Lee Jones
2017-08-07 1:57 ` [PATCH v2 2/5] dt-bindings: input: Add document bindings for mtk-pmic-keys Chen Zhong
2017-08-10 20:41 ` Rob Herring
2017-08-11 7:01 ` Chen Zhong
2017-08-07 1:57 ` [PATCH v2 3/5] dt-bindings: mfd: Add bindings for the keys as subnode of PMIC Chen Zhong
2017-08-10 20:42 ` Rob Herring
2017-08-07 1:57 ` [PATCH v2 4/5] input: Add MediaTek PMIC keys support Chen Zhong
2017-08-08 3:03 ` Dmitry Torokhov
2017-08-08 9:22 ` Chen Zhong
2017-08-07 1:57 ` [PATCH v2 5/5] mfd: mt6397: Add PMIC keys support to MT6397 driver Chen Zhong
2017-08-08 11:15 ` Lee Jones
2017-08-11 7:18 ` Chen Zhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502435908.28466.21.camel@mhfsdcap03 \
--to=chen.zhong@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=beomho.seo@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eddie.huang@mediatek.com \
--cc=javier@osg.samsung.com \
--cc=jcsing.lee@samsung.com \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).