From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753535AbdHKQMw (ORCPT <rfc822;w@1wt.eu>);
        Fri, 11 Aug 2017 12:12:52 -0400
Received: from imap0.codethink.co.uk ([185.43.218.159]:51179 "EHLO
        imap0.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752901AbdHKQMu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 11 Aug 2017 12:12:50 -0400
Message-ID: <1502467959.2047.32.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 15/58] iscsi-target: Fix initial login PDU
 asynchronous socket close OOPs
From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Nicholas Bellinger <nab@linux-iscsi.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Mike Christie <mchristi@redhat.com>, Hannes Reinecke <hare@suse.com>,
        Sagi Grimberg <sagi@grimberg.me>, Varun Prakash <varun@chelsio.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Fri, 11 Aug 2017 17:12:39 +0100
In-Reply-To: <20170809194147.115146026@linuxfoundation.org>
References: <20170809194146.501519882@linuxfoundation.org>
         <20170809194147.115146026@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-08-09 at 12:41 -0700, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me
> know.
> 
> ------------------
> 
> From: Nicholas Bellinger <nab@linux-iscsi.org>
> 
> commit 25cdda95fda78d22d44157da15aa7ea34be3c804 upstream.
[...]
> --- a/drivers/target/iscsi/iscsi_target_nego.c
> +++ b/drivers/target/iscsi/iscsi_target_nego.c
> @@ -489,14 +489,60 @@ static void iscsi_target_restore_sock_ca
>  
>  static int iscsi_target_do_login(struct iscsi_conn *, struct iscsi_login *);
>  
> -static bool iscsi_target_sk_state_check(struct sock *sk)
> +static bool __iscsi_target_sk_check_close(struct sock *sk)
>  {
>  	if (sk->sk_state == TCP_CLOSE_WAIT || sk->sk_state == TCP_CLOSE) {
> -		pr_debug("iscsi_target_sk_state_check: TCP_CLOSE_WAIT|TCP_CLOSE,"
> +		pr_debug("__iscsi_target_sk_check_close: TCP_CLOSE_WAIT|TCP_CLOSE,"
>  			"returning FALSE\n");
> -		return false;
> +		return true;
[...]

The log message no longer matches the code.  This seems to be unfixed
upstream.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.