From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752471AbdHPSBg (ORCPT ); Wed, 16 Aug 2017 14:01:36 -0400 Received: from g2t2353.austin.hpe.com ([15.233.44.26]:38182 "EHLO g2t2353.austin.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbdHPSBd (ORCPT ); Wed, 16 Aug 2017 14:01:33 -0400 From: "Kani, Toshimitsu" To: "bp@alien8.de" CC: "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "tony.luck@intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Thread-Topic: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Thread-Index: AQHTDKTuWyxK/OMe00e0Ovda8CeGBqJzlIKAgAEZcQCAAIyugIAD9yeAgAW2iQCABSfDgIAACkUAgAAEFwCAAAdxAIAACkmAgAAGWwCAAAC7gIAAB8WAgAAEpwCAAAu+AIAACWYAgAAIzwCAATq3AIAABjEAgAEXv4CAAHGnAIAAGBsAgAAKLgCAAAX/AIAAAyYA Date: Wed, 16 Aug 2017 18:01:30 +0000 Message-ID: <1502905904.2042.159.camel@hpe.com> References: <1502736750.2042.145.camel@hpe.com> <20170814193432.mjldfhfal5ba5dt7@pd.tnic> <1502741290.2042.147.camel@hpe.com> <20170814203942.6t3mrq3hc324blab@pd.tnic> <1502810766.2042.149.camel@hpe.com> <20170815154815.wy3dqwb4yi3feahg@intel.com> <20170816082931.p6rpvtlxwt5nccxr@pd.tnic> <1502896578.2042.155.camel@hpe.com> <20170816164234.mgwapenb7fpym6nk@pd.tnic> <1502903940.2042.157.camel@hpe.com> <20170816174028.dqfvubjigvwtcbcy@pd.tnic> In-Reply-To: <20170816174028.dqfvubjigvwtcbcy@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.203.227.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DF4PR84MB0188;6:5hS420n0pB4jq7MfhDQS3fsGyL3Z1FOJgeqP22lKqQ1MDlAJ9Kj/NtbTDUpilGItjNFnVanCRDvmvSdcjUi7gfDghS+A5hbJsGBB1y5gpT+t3IVwr2ROFtVHpN/8POazIIMOzwISfrbE7/igM5XqCC5/yg65oBA1kr42HzeDpbQF9oAL4b6fY5xumyBGIgvv+t93P6MLKUL07a55peo5SP0YJ/iF2oukYjcNcO09W8mT59ZqgQrLMMMv9N8NY83adVLCuhySyBqMLu3RzOm/UskyamJ0NZElDogxA6ebImRhGp29hy/GodqyyHaebJRk+yHngs0X2nhgAMkq5IvQ2g==;5:R8nc88Ycbh3Wlw6xpl9C6AIgT4cKpP8RatkFBzn1O+iIYZh8U5W1W1M315E0OD40KqujGbOrKqkGGT77z7GYGUDIMvOGqW5DiTgQmVMxhJkjWC70n2g75UMBRoni+44rLvd7ybwrYzCt0aOJnfsAUw==;24:Bx1ZaYyF2pJ0GX9eIvu3ev4Dpv6vt6ICoI9orwMIbgesXJrZjv2pMjARFAGI+VzeNwNyKCHV5EYLZCCOlxOFi0qqPIhdsbqJDynoB9p4KZA=;7:LdXcCKw6BOovkBb60eC4PcauidZbdXnA9TeVOtX1FU2CRCXZZmre73GtF79CMezSwE4htqZeBbZ1auRWiABxprySqJBg9C3WyD9g6rzlVCaNfw8b8HlumdvAnFp0Z4i/wStM24aPPfs1VpFt8Uz/4ZOm0FWnR+9F8RFAvNxlg5euZpfzj8Mh0kg9KQ9Yd1j1KKSn17+3YLvYXbPTpI4rcK4SuZd6ua5MVjeIca186ac= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 43afc3fd-18b8-47ce-691b-08d4e4d0d2eb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DF4PR84MB0188; x-ms-traffictypediagnostic: DF4PR84MB0188: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DF4PR84MB0188;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DF4PR84MB0188; x-forefront-prvs: 0401647B7F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(199003)(377424004)(24454002)(189002)(105586002)(14454004)(2351001)(86362001)(33646002)(229853002)(106356001)(2900100001)(2906002)(54906002)(3660700001)(93886005)(6512007)(53936002)(3280700002)(36756003)(6246003)(110136004)(5640700003)(7736002)(305945005)(5660300001)(6916009)(2950100002)(6116002)(189998001)(3846002)(102836003)(478600001)(4326008)(54356999)(50986999)(76176999)(68736007)(2501003)(6436002)(103116003)(25786009)(101416001)(66066001)(8936002)(81156014)(6506006)(1730700003)(81166006)(8676002)(97736004)(77096006)(6486002);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0188;H:DF4PR84MB0187.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Aug 2017 18:01:30.8587 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0188 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7GI1goW032553 On Wed, 2017-08-16 at 19:40 +0200, Borislav Petkov wrote: > On Wed, Aug 16, 2017 at 05:28:50PM +0000, Kani, Toshimitsu wrote: > > Assuming this big spinlock works, yes, this addresses my concern > > that > > You mean, lengthy locked section. We can always switch to on-stack > buffers if there are issues or even to something more fancy like > genpool. Yes, I meant the lengthy locked section. I still think that multiple mcis is a better approach for concurrency as it naturally addresses it. But as long as edac func and error handlers are tolerant with this spinlock and serialization, I am OK with that. > > I will test the patch with an SCI when I got a chance.  I won't be > > able to test other notification types or race conditions, though. > > Thanks, here's the latest version with the atomic registration too. Sure, I will test with this version. Thanks, -Toshi