From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753434AbdHQR03 (ORCPT ); Thu, 17 Aug 2017 13:26:29 -0400 Received: from mout.gmx.net ([212.227.17.22]:51874 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752536AbdHQR01 (ORCPT ); Thu, 17 Aug 2017 13:26:27 -0400 Message-ID: <1502990778.6840.2.camel@gmx.de> Subject: Re: [patch-rt] hotplug, hrtimer: Migrate expired/deferred timers during cpu offline From: Mike Galbraith To: Sebastian Andrzej Siewior Cc: Thomas Gleixner , LKML , linux-rt-users , Steven Rostedt Date: Thu, 17 Aug 2017 19:26:18 +0200 In-Reply-To: <20170817171720.jz2ok332bpxcjzme@linutronix.de> References: <20170804173823.lzuhnejlnxczr2lj@linutronix.de> <1501913583.7917.42.camel@gmx.de> <1501945043.5473.31.camel@gmx.de> <20170807073350.nwytftryfp34mrwi@linutronix.de> <1502094121.5568.22.camel@gmx.de> <1502186459.8042.31.camel@gmx.de> <1502438116.16425.18.camel@gmx.de> <1502439312.16425.19.camel@gmx.de> <1502697588.12319.199.camel@gmx.de> <20170817165041.3agf2btidfdcspiq@linutronix.de> <20170817171720.jz2ok332bpxcjzme@linutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:EUr5mScTZ34I8pAvabpQvwOIZDfhkllZ117ocXQsKbxF52zwJWG Pq7IvXGoo6Prxx7NZRaCK0yQxfPqnEwnxdt5gVwnnvA0CkiiLWc7mjcI3bYOCMICDIMir+M DG7fsEYLUfz7/cKPHjMQkNa1SHrAr0LTX8S6yUdi4x+0eJ4pG6RCuDLaOmpApnN9F9jZV5O UqjffE3Tc7xstikW4r5yA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Gs3PXmg7RFs=:R5PVASNa/UeoOOkI7JQ3ox 2L7YV1wsXM+SDi0S2vEcPbgtTbD65vbxUesElC4hLPfGCrrgbRkNZ3VDdIctua+Wu8XYcgMFo WxDHPHDVBHMdJXnnsMKLCe7v7IWN/lJwtOicR6e8k88KXMBHQVvdvvKz29nxOymV4f9Ef9aN3 5ke1WAkdsUb5PXbgoWFgVtNr4+EOsEez+3pHBdEpEPDHZtX6UtQNYLAhmB7+tv3OKqUWlRPBx 7l4MLr4naZtmz/QHwbYDVzjtkx7n5k9/+PW9CwqNOG7wnTCjF5eGZCJrcgrM6h5XvZ1FGLjQT G3K2unbKXt2y4qXLpP0dRPMQ0+wmYzeJKsIG6XzhY4WAR9hRk+pvtMCUVu9t3LkyJrWZWydVE wYj1hcq+/Juugn34Km31xTHk5IwZVH/yCBhtbw3uMGc/joEDqp8hNxyVAhtsOxf90tFbrrxA1 hX9g/xFw93hLNMxvDSYfYVypm7o/Puphbb9Q0o5eAB0+SUE5zqQek48Idk920H6l29WJW6c6n KEP7NTd4+FlQCA3MHl+22CJvUZtZaKx1lYZCD1d9HbyjWLr22FXhQ+teXPAJwBBA7AKs74B0t XTxLsDpBXkcHhwu4HamP+1/5nmPqhR8JLiHg5sJ824b+xyfUsLq1vYSQXxfkH4nCtdiSInhKW 8PgCYNM1OIL88NR6+yA/AQyrSdrltBDfcVskWCPQ1PbNHUfCV/2+xQlpsJxdOKqrHIKbpffOH 40+O6AB4hZck7ZeF11ZZF8SVdNUQF6+ObJQUq5u9r2iFUoUtELQRG4ijV5oT+OQxu3193geHZ GM2n+1pKFApb/pZS+MbRzcrm4AKsxXbnVh/EKiiFA3U9G3HRao= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-08-17 at 19:17 +0200, Sebastian Andrzej Siewior wrote: > On 2017-08-17 18:50:42 [+0200], To Mike Galbraith wrote: > > __remove_hrtimer() shouldn't be required because it has been done > > already. It should be enough to just list_splice() one list to the > > other and raise the softirq afterwards. > > Mike, can you check this please: Yeah, will do. > diff --git a/kernel/time/hrtimer.c b/kernel/time/hrtimer.c > index 55839ff2bba6..4b9264e0d363 100644 > --- a/kernel/time/hrtimer.c > +++ b/kernel/time/hrtimer.c > @@ -1802,6 +1802,11 @@ static void migrate_hrtimer_list(struct hrtimer_clock_base *old_base, > */ > enqueue_hrtimer(timer, new_base); > } > +#ifdef CONFIG_PREEMPT_RT_BASE > + list_splice_tail(&old_base->expired, &new_base->expired); > + if (!list_empty(&new_base->expired)) > + raise_softirq_irqoff(HRTIMER_SOFTIRQ); > +#endif > } > > int hrtimers_dead_cpu(unsigned int scpu)