From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753752AbdHQVIq (ORCPT ); Thu, 17 Aug 2017 17:08:46 -0400 Received: from g4t3426.houston.hpe.com ([15.241.140.75]:51702 "EHLO g4t3426.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753310AbdHQVIn (ORCPT ); Thu, 17 Aug 2017 17:08:43 -0400 From: "Kani, Toshimitsu" To: "bp@alien8.de" CC: "linux-kernel@vger.kernel.org" , "rostedt@goodmis.org" , "mchehab@kernel.org" , "rjw@rjwysocki.net" , "tony.luck@intel.com" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-edac@vger.kernel.org" Subject: Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Thread-Topic: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk() Thread-Index: AQHTDKTuWyxK/OMe00e0Ovda8CeGBqJzlIKAgAEZcQCAAIyugIAD9yeAgAW2iQCABSfDgIAACkUAgAAEFwCAAAdxAIAACkmAgAAGWwCAAAC7gIAAB8WAgAAEpwCAAAu+AIAACWYAgAAIzwCAATq3AIAABjEAgAEXv4CAAHGnAIAAGBsAgAAKLgCAAAX/AIAAAyYAgAHGngA= Date: Thu, 17 Aug 2017 21:08:40 +0000 Message-ID: <1503003532.2042.161.camel@hpe.com> References: <1502736750.2042.145.camel@hpe.com> <20170814193432.mjldfhfal5ba5dt7@pd.tnic> <1502741290.2042.147.camel@hpe.com> <20170814203942.6t3mrq3hc324blab@pd.tnic> <1502810766.2042.149.camel@hpe.com> <20170815154815.wy3dqwb4yi3feahg@intel.com> <20170816082931.p6rpvtlxwt5nccxr@pd.tnic> <1502896578.2042.155.camel@hpe.com> <20170816164234.mgwapenb7fpym6nk@pd.tnic> <1502903940.2042.157.camel@hpe.com> <20170816174028.dqfvubjigvwtcbcy@pd.tnic> <1502905904.2042.159.camel@hpe.com> In-Reply-To: <1502905904.2042.159.camel@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.219.147.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CS1PR84MB0055;6:XVn0yjzzkU1o+qFqaJQ+3TvXLxnmb4JZXF8NBavFCUVt2Ct3tIFahXnf3WcZu9XYvUfJkNbAn223NOpHWWO6wc/dEmn4j0CU6ITCzagwBEZ9heBbLgDXoLSyFVoRF2OrecQ/wjd8w/TyFK2yrBHb2m8+FeGc+h0Cuf6qLHxB0o9l7/yv68mcP5Pv/V3XHjytV+bABnYu1zcCRohdUMWGSl3807wsHw6+u7aBCegZXPhB9NdPmuNgVNzi6DZKRlo9A5qpH23eGFVk7bZkHPCGiaGHX9xdMVyjG7ALVxT+JqXwZjfPGyvygFcUTL9ZqOUwwX3HKxtDFcCcUdCe/WZgVA==;5:qXV9GcriUgMTA1SDHwp+2TQIvg9q/PR58Lv7r2VD8bKNLbhqdhcat7AhmG5jSlMZTAC8L0iv07uFMZwVI4TA0h1aBj+5TvffhG/XOMSQavaPjY69roxgG9R7toV5ZXOi8LsBLirM10IDy+djHF6QZA==;24:nPLUgetjUXEWVjU9Vr34oaAPeeJVDLUfT/0NAdvS73pMeFbbEuU94qsuvycHdpkI6fOU8+3Ju905aDb2VtuHCgGyCypF7QsmSeb1Pysz4LA=;7:oPzwRrwroRfNimy2ICAt/GI/wIdBWO6yxC8lUNPnqKMb9+vwk+MExDsmEmqTUs/wPiPFVWQdABlJvs1Tg1gS3hf/yNoz4y+2onRVStv8X08tiqSEKit7MmoWDP49fOJCShT8VRnjcqV77zp2aONWIZzuHTe6uPcs9wg2ikwI04JlhNg2yz59P79N3BXQFhk6rJQ4v39ykRqjKuBkdXKsb7jVlKnhpad03TdWM0eOc4k= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: b641ba6b-9f32-4e1c-d0e9-08d4e5b422cd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CS1PR84MB0055; x-ms-traffictypediagnostic: CS1PR84MB0055: x-exchange-antispam-report-test: UriScan:(211171220733660); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123555025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CS1PR84MB0055;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CS1PR84MB0055; x-forefront-prvs: 0402872DA1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(189002)(24454002)(199003)(377424004)(189998001)(81156014)(6506006)(1730700003)(97736004)(81166006)(7736002)(3660700001)(3280700002)(6512007)(4326008)(54906002)(50986999)(93886005)(54356999)(76176999)(102836003)(6916009)(6116002)(8936002)(2950100002)(86362001)(2900100001)(3846002)(2501003)(25786009)(2906002)(229853002)(77096006)(6486002)(305945005)(8676002)(68736007)(5640700003)(36756003)(478600001)(6436002)(14454004)(66066001)(33646002)(5660300001)(101416001)(2351001)(53936002)(6246003)(105586002)(103116003)(110136004)(106356001);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0055;H:CS1PR84MB0181.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2017 21:08:40.5932 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0055 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7HL9PUv005523 On Wed, 2017-08-16 at 11:51 -0600, Toshi Kani wrote: > On Wed, 2017-08-16 at 19:40 +0200, Borislav Petkov wrote: > > On Wed, Aug 16, 2017 at 05:28:50PM +0000, Kani, Toshimitsu wrote: : > > > I will test the patch with an SCI when I got a chance.  I won't > > > be able to test other notification types or race conditions, > > > though. > > > > Thanks, here's the latest version with the atomic registration too. > > Sure, I will test with this version. I briefly tested the patch with an SCI. The error reporting part seems to work fine. There are two issues I noticed: 1. It creates mc0 and mc1.   I think this is because you called edac_mc_alloc() with mc_num 1. 2. 'ras-mc-ctl --layout' does not show all DIMMs. # ras-mc-ctl --layout +------------------------+          |    mc0     |    mc1     | ---------+------------------------+ memory4: |     0 MB  |  16384 MB  | memory3: |     0 MB  |     0 MB  | memory2: |     0 MB  |     0 MB  | memory1: |     0 MB  |     0 MB  | memory0: |     0 MB  |  8192 MB  | ---------+-----------------------+ # ls /sys/bus/mc1/devices csrow0   csrow12  csrow23  dimm0   dimm12  dimm23  mc1 csrow11  csrow19  csrow4   dimm11  dimm19  dimm4 Thanks, -Toshi