From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbdHaMhF (ORCPT ); Thu, 31 Aug 2017 08:37:05 -0400 Received: from smtprelay0096.hostedemail.com ([216.40.44.96]:52718 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751242AbdHaMhC (ORCPT ); Thu, 31 Aug 2017 08:37:02 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1434:1437:1515:1516:1518:1534:1542:1593:1594:1711:1712:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:4321:5007:6742:7875:7974:10004:10400:10848:11026:11232:11473:11658:11914:12043:12109:12296:12438:12740:12760:12895:13439:14181:14659:14721:21080:21451:21627:30029:30054:30060:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: view37_2c4d70ad2f21 X-Filterd-Recvd-Size: 3591 Message-ID: <1504183017.2786.36.camel@perches.com> Subject: Re: linux-next: manual merge of the xen-tip tree with the tip tree From: Joe Perches To: Ingo Molnar , Thomas Gleixner Cc: Stephen Rothwell , Juergen Gross , Konrad Rzeszutek Wilk , Stefano Stabellini , Boris Ostrovsky , Xen Devel , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , Linux-Next Mailing List , Linux Kernel Mailing List Date: Thu, 31 Aug 2017 05:36:57 -0700 In-Reply-To: <20170831091656.dmh7lgb7w4cfws6j@gmail.com> References: <20170831142654.47f17cd7@canb.auug.org.au> <20170831091656.dmh7lgb7w4cfws6j@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-08-31 at 11:16 +0200, Ingo Molnar wrote: > * Thomas Gleixner wrote: > Low prio nitpicking, could we please write such table based initializers in a > vertically organized, tabular fashion: > > > + { debug, xen_xendebug, true }, > > + { int3, xen_xenint3, true }, > > + { double_fault, xen_double_fault, true }, > > +#ifdef CONFIG_X86_MCE > > + { machine_check, xen_machine_check, true }, > > +#endif > > + { nmi, xen_nmi, true }, > > + { overflow, xen_overflow, false }, > > +#ifdef CONFIG_IA32_EMULATION > > + { entry_INT80_compat, xen_entry_INT80_compat, false }, > > +#endif > > + { page_fault, xen_page_fault, false }, > > + { divide_error, xen_divide_error, false }, > > + { bounds, xen_bounds, false }, > > + { invalid_op, xen_invalid_op, false }, > > + { device_not_available, xen_device_not_available, false }, > > + { coprocessor_segment_overrun, xen_coprocessor_segment_overrun, false }, > > + { invalid_TSS, xen_invalid_TSS, false }, > > + { segment_not_present, xen_segment_not_present, false }, > > + { stack_segment, xen_stack_segment, false }, > > + { general_protection, xen_general_protection, false }, > > + { spurious_interrupt_bug, xen_spurious_interrupt_bug, false }, > > + { coprocessor_error, xen_coprocessor_error, false }, > > + { alignment_check, xen_alignment_check, false }, > > + { simd_coprocessor_error, xen_simd_coprocessor_error, false }, > > +#ifdef CONFIG_TRACING > > + { trace_page_fault, xen_trace_page_fault, false }, > > +#endif > ,, > ... as to me such a table is 100 times more readable - YMMV. Yeah, kinda. It's a lot of whitespace and eyeball left/right scanning. And these tables require whitespace updating if a longer name is ever used. Given the near 1:1 mapping of to xen_ perhaps adding a macro would be nice. #define xen_trap(trap, ist_ok) \ { trap, xen_##trap, ist_ok } { debug, xen_xendebug, true }, { int3, xen_xenint3, true }, #ifdef CONFIG_X86_MCE xen_trap(machine_check, true), #endif xen_trap(double_fault, true), xen_trap(nmi, true), xen_trap(overflow, false), ... ymmv.