From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751881AbdHaQR1 (ORCPT ); Thu, 31 Aug 2017 12:17:27 -0400 Received: from g4t3427.houston.hpe.com ([15.241.140.73]:33198 "EHLO g4t3427.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbdHaQRX (ORCPT ); Thu, 31 Aug 2017 12:17:23 -0400 From: "Kani, Toshimitsu" To: "bp@alien8.de" CC: "linux-edac@vger.kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "tony.luck@intel.com" , "linux-kernel@vger.kernel.org" , "rjw@rjwysocki.net" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac Thread-Topic: [PATCH v4 3/5] ghes_edac: add platform check to enable ghes_edac Thread-Index: AQHTHGQ64gYgIKEhTEmknkbrX4SyMaKeVuWAgABWs4A= Date: Thu, 31 Aug 2017 16:17:07 +0000 Message-ID: <1504195625.2042.179.camel@hpe.com> References: <20170823225447.15608-1-toshi.kani@hpe.com> <20170823225447.15608-4-toshi.kani@hpe.com> <20170831105647.a7ypixekv6jybqyu@pd.tnic> In-Reply-To: <20170831105647.a7ypixekv6jybqyu@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-originating-ip: [15.211.195.8] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DF4PR84MB0028;6:7Y79/GohelSc8FEfyxnN6p7p9t73dhIznsVM3YD349JMCDbXGdfoK19qGPzO8YOTgp1sC9esMBSRUO/5MdhKKtkRyjBfbLcdRWRDzCzDKeNd9WX2PaNEl22A32UxMEgu78/keJayuPbl/RFj40GKChvu+5sTp7dnlJ+oWZNZegQcNLr2WFGuVsDkI2O6idl/hm/IgNVX663Hl8fZXd6Ufu9G6Uu1Un8JJkpxnIaYWZdo3M27/V+FCugf76ka2PlPXC0ZuHRpiWJdnOzqc8QotVcjSeSzPELGuogWcRoH4mKNpf59pJqGgeAPLH0r0Yy2T8G43MVokBD6DJ2tPbuZJQ==;5:My9qB2CZhlwwAEEZ0KqatRo7eUv4TzQTI7cOZOYCvQmhJuwVgQMRi8e4H4OBTvhfg7fw3IxohFLVzkInyWq2axxgXLHWJtA7xOOC/NfXZvR1xxtsLq/NHbWbMKvoxSxuFFZAr8xy7mSx10X9ej03ew==;24:uZGco4RwHhpAV9dbroh/oV9cDW5cwEHfzsUq5tSJUxb1SGShCrndh5O7euKaSlzuf+wMzLjp+hnfeMpmFxkkt3UZMKgpEXDCz3Oa2FxSaE0=;7:8xIjMEzYm2hM2t7tY/EM6J5kf8lr3pgSvKwWfZK45rAL3LGb4xR6Jsv58tB/tdYzlOLqbnGTjgeNtDAhpP65brpjZSVDNcIkfx4K+KkIC5QU0BcjaVXIbzVMFD02KTcPK1ICF31K8M2RgfszKIbZAfMnGMw25intBIMUy3PY2a1kXD3Qcg9RWLGy6C98UynjsfAYYuQxA8R+Vk/HHhQZGGnpouuMeAsyCGc8iwJHTRg= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 86de9ddd-31f8-46fe-b54d-08d4f08bb9e5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DF4PR84MB0028; x-ms-traffictypediagnostic: DF4PR84MB0028: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DF4PR84MB0028;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DF4PR84MB0028; x-forefront-prvs: 04163EF38A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(199003)(189002)(24454002)(377424004)(305945005)(14454004)(110136004)(6486002)(77096006)(106356001)(68736007)(478600001)(1730700003)(81156014)(5660300001)(105586002)(2906002)(81166006)(2351001)(8676002)(25786009)(5640700003)(2501003)(8936002)(6506006)(103116003)(189998001)(6512007)(101416001)(4326008)(3660700001)(97736004)(3280700002)(54906002)(6436002)(53936002)(36756003)(2900100001)(6116002)(3846002)(2950100002)(102836003)(6916009)(7736002)(66066001)(33646002)(229853002)(50986999)(6246003)(86362001)(54356999)(76176999);DIR:OUT;SFP:1102;SCL:1;SRVR:DF4PR84MB0028;H:DF4PR84MB0187.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <9001CA75183E074EB558E88C597B0741@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2017 16:17:07.5729 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR84MB0028 X-OriginatorOrg: hpe.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7VGHZkC007337 On Thu, 2017-08-31 at 12:56 +0200, Borislav Petkov wrote: > On Wed, Aug 23, 2017 at 04:54:45PM -0600, Toshi Kani wrote: : > > --- > >  drivers/edac/ghes_edac.c |   29 ++++++++++++++++++++++++----- > >  1 file changed, 24 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c > > index 8d904df..0030a09 100644 > > --- a/drivers/edac/ghes_edac.c > > +++ b/drivers/edac/ghes_edac.c > > @@ -38,6 +38,10 @@ static struct ghes_edac_pvt *ghes_pvt; > >   */ > >  static DEFINE_SPINLOCK(ghes_lock); > >   > > +/* Set 1 to skip the platform check */ > > +static bool __read_mostly ghes_edac_force_load; > > It is static - "force_load" as a bool name is enough. Will do. > > +module_param_named(force_load, ghes_edac_force_load, bool, 0); > > ERROR: Use 4 digit octal (0777) not decimal permissions > #53: FILE: drivers/edac/ghes_edac.c:43: > +module_param_named(force_load, ghes_edac_force_load, bool, 0); > > This last param is @perm: visibility in sysfs. Why not visible in > sysfs? I followed in the footsteps of 'ghes_disable', which is also a kernel boot option and uses 0. > > + > >  /* Memory Device - Type 17 of SMBIOS spec */ > >  struct memdev_dmi_entry { > >   u8 type; > > @@ -415,6 +419,15 @@ void ghes_edac_report_mem_error(struct ghes > > *ghes, int sev, > >   spin_unlock_irqrestore(&ghes_lock, flags); > >  } > >   > > +/* > > + * Known systems that are safe to enable this module. > > + * "ghes_edac.force_load=1" skips this check if necessary. > > Put this second sentence over the parameter definition. Will do. Thanks, -Toshi