From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbdIFTlG (ORCPT ); Wed, 6 Sep 2017 15:41:06 -0400 Received: from mga04.intel.com ([192.55.52.120]:64680 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752404AbdIFTlE (ORCPT ); Wed, 6 Sep 2017 15:41:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,355,1500966000"; d="scan'208";a="308737270" From: "Bernat, Yehezkel" To: "mario.limonciello@dell.com" CC: "mika.westerberg@linux.intel.com" , "linux-kernel@vger.kernel.org" , "platform-driver-x86@vger.ke" , "dvhart@infradead.org" , "hughsient@gmail.com" Subject: Re: Fwd: [PATCH] Add driver to force WMI Thunderbolt controller power status Thread-Topic: Fwd: [PATCH] Add driver to force WMI Thunderbolt controller power status Thread-Index: AQHTJ0YV8o1w6haZs0+qP3ceDgEFGaKoQZmA Date: Wed, 6 Sep 2017 19:40:59 +0000 Message-ID: <1504726863.2677.154.camel@intel.com> References: <1504720440-24423-1-git-send-email-mario.limonciello@dell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.18.5.2-0ubuntu3.2 authentication-results: spf=none (sender IP is ) smtp.mailfrom=yehezkel.bernat@intel.com; x-originating-ip: [134.191.232.68] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN4PR11MB0851;6:y2W7568FO76z/qPms35qg+YxwLhJI6ZTUueUPvJzSL7eoOdYNGLNcs2lNa1ZtyEG0pTzinKQWYha+RCTEQQEB/sZI3GRw2/2XrQMTxLcLsLIuHYU2ozggSOVBUEWTlho+3jPkwWXXwmWJ7RxiKOcxSRo2V0OkSCYII/0se0IRLB5v5bDsyspUlCukY/FAjARGTYjMushXGyTcp2kY+ABazSr6Tph4nifhqfvzBHcdnaV2gE8gs2yOmPcQCFmKumRlR3hDI4LY3P2OkkLchbSKDC9Dzw8Pad1XPWduMCgsvntTn1cyTVlAkBMBYwH12twkiGVxLgQPWGta7R/2qY9vw==;5:j9M5ZT7CDKGYWjU2i3VMS+np8UNAJv/aAstfMfkARkfQd5H5iEfH8YQfXmRBXYevwYegmA5QTWGafrM3Yo1G9yRX9qfuPKN2GlIWuNmdIjSkpHdtaDMv7930ig+J0exZ+6OiflHeRd3N5DUZ+bOL5Q==;24:BoVLNoDJ1x4haIiJ+e7dcaMLIivA/9uiDDbWhloYwJjYiwlmYVT+/oQb/UU4Wvmxv51Aw5ay05DDDJ7DQaHSol3VdL4u4VFchpeXdqpNbWQ=;7:AO4BJDh2Rhuv433Xv9R+st9HImaoktcBnv6QJTTdElwIuTe5bikyukGURLOCGpUlsMdB26JixpD8G7/YM3qOCCALx0/BoW6PlTHehc9lEHBHKQ+xYaNbWzApvTKPMRDCmuU75vjAOUfLtk0eWy1YN8pI0h1l6Xl5SokjkExJCQhRDKSB33om1aTfdAN8hIHbecV9pzDsF06gpBCdKaitExiHDg9V/arMeRbda7A/3h0= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: ea931a49-54e8-426b-b11a-08d4f55f32f5 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN4PR11MB0851; x-ms-traffictypediagnostic: BN4PR11MB0851: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN4PR11MB0851;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN4PR11MB0851; x-forefront-prvs: 0422860ED4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39830400002)(189002)(199003)(66066001)(50986999)(36756003)(101416001)(97736004)(189998001)(478600001)(76176999)(3280700002)(6436002)(6506006)(2900100001)(77096006)(3660700001)(6486002)(2950100002)(229853002)(2501003)(14454004)(68736007)(6916009)(8676002)(81156014)(81166006)(305945005)(2351001)(99286003)(6512007)(4326008)(105586002)(2906002)(50226002)(6116002)(102836003)(7736002)(3846002)(103116003)(8666007)(25786009)(86362001)(8936002)(39060400002)(53936002)(54906002)(5640700003)(110136004)(33646002)(5660300001)(6246003)(106356001)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN4PR11MB0851;H:BN4PR11MB0996.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <82D4045712AE25429579BFBABE13ABCC@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2017 19:40:59.0805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR11MB0851 X-OriginatorOrg: intel.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v86JfDDU023776 > Current implementations of Intel Thunderbolt controllers will go > into a low power mode when not in use. > > Many machines containing these controllers also have a GPIO wired up > that can force the controller awake.  This is offered via a ACPI-WMI > interface intended to be manipulated by a userspace utility. > This mechanism is provided by Intel to OEMs to include in BIOS. > It uses an industry wide GUID that is populated in a separate _WDG > entry with no binary MOF. > > This interface allow software such as fwupd to wake up thunderbolt > controllers to query the firmware version or flash new firmware. As this is a Thunderbolt specific function, maybe it's better to be exposed from the Thunderbolt driver? > + > +static DEVICE_ATTR_WO(force_power); > + I'm not sure what is the convention for permissions for this type of attributes but I feel like this worth being root-only writable, as it can be used to power-off the controller in the middle of a FW update, for example.