From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755576AbdIGRD3 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Sep 2017 13:03:29 -0400
Received: from mga03.intel.com ([134.134.136.65]:63291 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1755540AbdIGRD1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Sep 2017 13:03:27 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,359,1500966000"; 
   d="scan'208";a="1170075784"
Message-ID: <1504803627.13310.8.camel@tzanussi-mobl.amr.corp.intel.com>
Subject: Re: [PATCH v2 19/40] tracing: Account for variables in named
 trigger compatibility
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org,
        vedang.patel@intel.com, bigeasy@linutronix.de, joel.opensrc@gmail.com,
        joelaf@google.com, mathieu.desnoyers@efficios.com,
        baohong.liu@intel.com, linux-kernel@vger.kernel.org,
        linux-rt-users@vger.kernel.org
Date: Thu, 07 Sep 2017 12:00:27 -0500
In-Reply-To: <20170907124011.222b58a7@gandalf.local.home>
References: <cover.1504642143.git.tom.zanussi@linux.intel.com>
         <ee6b4ead2b42a2757254d447696f3c367e9cc49c.1504642143.git.tom.zanussi@linux.intel.com>
         <20170907124011.222b58a7@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-09-07 at 12:40 -0400, Steven Rostedt wrote:
> On Tue,  5 Sep 2017 16:57:31 -0500
> Tom Zanussi <tom.zanussi@linux.intel.com> wrote:
> 
> > @@ -1786,6 +1786,12 @@ static bool hist_trigger_match(struct event_trigger_data *data,
> >  			return false;
> >  		if (key_field->is_signed != key_field_test->is_signed)
> >  			return false;
> > +		if ((key_field->var.name && !key_field_test->var.name) ||
> > +		    (!key_field->var.name && key_field_test->var.name))
> > +			return false;
> 
> Short cut:
> 
> 		if (!!key_field->var.name != !!key_field_test->var.name)
> 			return false;
> 

Nice!

> > +		if ((key_field->var.name && key_field_test->var.name) &&
> 
> Only need to test if key_field->var.name, as the previous if statement
> would exit out if key_field_test->var.name is false.
> 

OK, will change, thanks.

Tom