linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tobin Harding <me@tobin.cc>
To: Greg KH <greg@kroah.com>, Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Linux-Next Mailing List" <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commits in the staging tree
Date: Wed, 20 Sep 2017 01:50:48 +1000	[thread overview]
Message-ID: <1505836248.392159.1111298816.4DE9BCE7@webmail.messagingengine.com> (raw)
In-Reply-To: <1505835299.387461.1111276008.64AD9525@webmail.messagingengine.com>


On Wed, Sep 20, 2017, at 01:34, Tobin Harding wrote:
> 
> On Tue, Sep 19, 2017, at 16:09, Greg KH wrote:
> > On Tue, Sep 19, 2017 at 07:54:55AM +1000, Stephen Rothwell wrote:
> > > Hi Greg,
> > > 
> > > Commits
> > > 
> > >   688a0206cfb8 ("staging: rtlwifi: fix parenthesis alignment")
> > >   85d309d53f7a ("staging: rtlwifi: use kcalloc instead of multiply")
> > >   f216f6cdeb1d ("staging: rtlwifi: remove unused functions")
> > > 
> > > are missing a Signed-off-by from their author.
> > 
> > Ugh, I totally missed that, Tobin, what went wrong here?
> 
> Apologies, I bet I didn't set up my environment on the laptop fully.
> Usual dev machine is a desktop, I did these patches as prep for OSS. 

I've got a strong feeling I didn't enable the driver before I 'built'
this patch series also.  Bad Tobin.

Luckily the kbot didn't punish me.

  reply	other threads:[~2017-09-19 15:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-18 21:54 linux-next: Signed-off-by missing for commits in the staging tree Stephen Rothwell
2017-09-19  6:09 ` Greg KH
2017-09-19 15:34   ` Tobin Harding
2017-09-19 15:50     ` Tobin Harding [this message]
2017-11-27 21:16 Stephen Rothwell
2017-11-28 19:41 ` Greg KH
2017-11-28 22:59   ` Stephen Rothwell
2017-11-29  0:09     ` Michael Ellerman
2017-11-29  0:18       ` Stephen Rothwell
2018-02-23  9:17     ` Greg KH
2017-11-29  8:44   ` Christian Gromm
2017-11-29  9:14     ` Greg KH
2017-11-29  9:25       ` Christian Gromm
2017-11-29  9:32         ` Greg KH
2017-11-29 12:24     ` Stephen Rothwell
2017-11-29 12:35       ` Stephen Rothwell
2017-11-29 12:42       ` Christian Gromm
2018-01-09 20:18 Stephen Rothwell
2018-01-11 17:50 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1505836248.392159.1111298816.4DE9BCE7@webmail.messagingengine.com \
    --to=me@tobin.cc \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).