From: "David S. Miller" <davem@redhat.com>
To: Alexander Viro <viro@math.psu.edu>
Cc: Jeff Garzik <jgarzik@mandrakesoft.com>,
Andreas Dilger <adilger@turbolinux.com>,
kowalski@datrix.co.za, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [CFT][PATCH] Re: Fwd: Re: memory usage - dentry_cache
Date: Thu, 12 Apr 2001 01:44:44 -0700 (PDT) [thread overview]
Message-ID: <15061.27388.843554.687422@pizda.ninka.net> (raw)
In-Reply-To: <Pine.GSO.4.21.0104120257070.18135-100000@weyl.math.psu.edu>
In-Reply-To: <3AD550F0.8058FAA@mandrakesoft.com> <Pine.GSO.4.21.0104120257070.18135-100000@weyl.math.psu.edu>
Alexander Viro writes:
> OK, how about wider testing? Theory: prune_dcache() goes through the
> list of immediately killable dentries and tries to free given amount.
> It has a "one warning" policy - it kills dentry if it sees it twice without
> lookup finding that dentry in the interval. Unfortunately, as implemented
> it stops when it had freed _or_ warned given amount. As the result, memory
> pressure on dcache is less than expected.
The reason the code is how it is right now is there used to be a bug
where that goto spot would --count but not check against zero, making
count possibly go negative and then you'd be there for a _long_ time
:-)
Just a FYI...
Later,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-04-12 8:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-11 11:36 Fwd: Re: memory usage - dentry_cache Marcin Kowalski
2001-04-12 4:48 ` Fwd: Re: memory usage - dentry_cacheg Andreas Dilger
2001-04-12 5:45 ` Alexander Viro
2001-04-12 6:53 ` [PATCH] " Jeff Garzik
2001-04-12 7:10 ` [CFT][PATCH] Re: Fwd: Re: memory usage - dentry_cache Alexander Viro
2001-04-12 8:44 ` David S. Miller [this message]
2001-04-12 12:27 ` Marcin Kowalski
2001-04-12 12:43 ` Yoann Vandoorselaere
2001-04-12 13:54 ` Alexander Viro
2001-04-12 17:27 ` Andreas Dilger
2001-04-12 7:00 ` Fwd: Re: memory usage - dentry_cacheg Andreas Dilger
2001-04-12 7:27 ` [race][RFC] d_flags use Alexander Viro
2001-04-12 8:01 ` David S. Miller
2001-04-12 8:06 ` Alexander Viro
2001-04-12 11:46 ` [PATCH] Re: memory usage - dentry_cacheg Ed Tomlinson
2001-04-12 14:56 ` Rik van Riel
2001-04-12 15:12 ` Alexander Viro
2001-04-13 1:34 ` Ed Tomlinson
2001-04-13 2:03 ` Alexander Viro
2001-04-13 4:45 ` Ed Tomlinson
2001-04-13 13:36 ` Ed Tomlinson
2001-04-12 15:30 ` Marcin Kowalski
2001-04-14 3:28 ` Paul
2001-04-12 14:34 ` [PATCH] Re: Fwd: " Jan Harkes
2001-04-12 14:50 ` Alexander Viro
2001-04-12 15:07 ` Rik van Riel
2001-04-12 15:27 ` Alexander Viro
2001-04-12 15:42 ` Alexander Viro
2001-04-12 15:48 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15061.27388.843554.687422@pizda.ninka.net \
--to=davem@redhat.com \
--cc=adilger@turbolinux.com \
--cc=jgarzik@mandrakesoft.com \
--cc=kowalski@datrix.co.za \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).