From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759305AbYENL1J (ORCPT ); Wed, 14 May 2008 07:27:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760087AbYENL0v (ORCPT ); Wed, 14 May 2008 07:26:51 -0400 Received: from mx1.redhat.com ([66.187.233.31]:53460 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755821AbYENL0t (ORCPT ); Wed, 14 May 2008 07:26:49 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1210619134.24092.51.camel@brick> References: <1210619134.24092.51.camel@brick> To: Harvey Harrison Cc: dhowells@redhat.com, Andrew Morton , LKML , James Bottomley , linux-scsi , Bartlomiej Zolnierkiewicz , linux-ide , linux-netdev , David Miller , Jeff Garzik , Ingo Molnar , Jason Wessel , "ralf@linux-mips.org" , Paul Mundt , Paul Mackerras Subject: Re: [PATCH 01/12] lib: create common ascii hex array X-Mailer: MH-E 8.0.3+cvs; nmh 1.2-20070115cvs; GNU Emacs 23.0.50 Date: Wed, 14 May 2008 12:26:10 +0100 Message-ID: <1507.1210764370@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Harvey Harrison wrote: > Add a common hex array in hexdump.c so everyone can use it. > > Add a common hi/lo helper to avoid the shifting masking that is > done to get the upper and lower nibbles of a byte value. > > Pull the pack_hex_byte helper from kgdb as it is opencoded many > places in the tree that will be consolidated. > > Signed-off-by: Harvey Harrison Acked-by: David Howells