From: Jia-Ju Bai <baijiaju1990@163.com>
To: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
ching2048@areca.com.tw, bhumirks@gmail.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Jia-Ju Bai <baijiaju1990@163.com>
Subject: [PATCH] arcmsr: Fix possible sleep-in-atomic bugs in arcmsr_queue_command
Date: Sun, 8 Oct 2017 20:51:49 +0800 [thread overview]
Message-ID: <1507467109-23640-1-git-send-email-baijiaju1990@163.com> (raw)
The driver may sleep under a spinlock, and the function call paths are:
arcmsr_queue_command(acquire the spinlock)
arcmsr_queue_command_lck
arcmsr_handle_virtual_command
arcmsr_iop_message_xfer
arcmsr_iop_parking
arcmsr_stop_adapter_bgrb
arcmsr_hbaA_stop_bgrb
arcmsr_hbaA_wait_msgint_ready
msleep --> may sleep
arcmsr_queue_command(acquire the spinlock)
arcmsr_queue_command_lck
arcmsr_handle_virtual_command
arcmsr_iop_message_xfer
arcmsr_iop_parking
arcmsr_stop_adapter_bgrb
arcmsr_hbaB_stop_bgrb
arcmsr_hbaB_wait_msgint_ready
msleep --> may sleep
arcmsr_queue_command(acquire the spinlock)
arcmsr_queue_command_lck
arcmsr_handle_virtual_command
arcmsr_iop_message_xfer
arcmsr_iop_parking
arcmsr_stop_adapter_bgrb
arcmsr_hbaC_stop_bgrb
arcmsr_hbaC_wait_msgint_ready
msleep --> may sleep
arcmsr_queue_command(acquire the spinlock)
arcmsr_queue_command_lck
arcmsr_handle_virtual_command
arcmsr_iop_message_xfer
arcmsr_iop_parking
arcmsr_stop_adapter_bgrb
arcmsr_hbaD_stop_bgrb
arcmsr_hbaD_wait_msgint_ready
msleep --> may sleep
To fix them, msleep is replaced with mdelay.
These bugs are found by my static analysis tool and my code review.
Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
---
drivers/scsi/arcmsr/arcmsr_hba.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index af032c4..31d94bd 100644
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -347,7 +347,7 @@ static uint8_t arcmsr_hbaA_wait_msgint_ready(struct AdapterControlBlock *acb)
®->outbound_intstatus);
return true;
}
- msleep(10);
+ mdelay(10);
} /* max 20 seconds */
return false;
@@ -367,7 +367,7 @@ static uint8_t arcmsr_hbaB_wait_msgint_ready(struct AdapterControlBlock *acb)
reg->drv2iop_doorbell);
return true;
}
- msleep(10);
+ mdelay(10);
} /* max 20 seconds */
return false;
@@ -385,7 +385,7 @@ static uint8_t arcmsr_hbaC_wait_msgint_ready(struct AdapterControlBlock *pACB)
&phbcmu->outbound_doorbell_clear); /*clear interrupt*/
return true;
}
- msleep(10);
+ mdelay(10);
} /* max 20 seconds */
return false;
@@ -403,7 +403,7 @@ static bool arcmsr_hbaD_wait_msgint_ready(struct AdapterControlBlock *pACB)
reg->outbound_doorbell);
return true;
}
- msleep(10);
+ mdelay(10);
} /* max 20 seconds */
return false;
}
--
1.7.9.5
next reply other threads:[~2017-10-08 12:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-08 12:51 Jia-Ju Bai [this message]
2017-12-12 13:33 [PATCH] arcmsr: Fix possible sleep-in-atomic bugs in arcmsr_queue_command Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507467109-23640-1-git-send-email-baijiaju1990@163.com \
--to=baijiaju1990@163.com \
--cc=bhumirks@gmail.com \
--cc=ching2048@areca.com.tw \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).