From: Kees Cook <keescook@chromium.org>
To: Jessica Yu <jeyu@kernel.org>
Cc: Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param_call()
Date: Tue, 17 Oct 2017 19:04:40 -0700 [thread overview]
Message-ID: <1508292283-140003-1-git-send-email-keescook@chromium.org> (raw)
(re-sending to Jessica's @korg address...)
The module_param_call() macro was explicitly casting the .set and .get
function prototypes away with (void *). This can lead to hard-to-find
type mismatches. Additionally, it creates problems for static checkers
and Control Flow Itegrity compiler features, which depend on clustering
function call sites based on prototype signature.
This removes the casts and fixes all the incorrect prototypes tree-wide.
-Kees
next reply other threads:[~2017-10-18 2:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 2:04 Kees Cook [this message]
2017-10-18 2:04 ` [PATCH 1/3] module: Prepare to convert all module_param_call() prototypes Kees Cook
2017-10-18 2:04 ` [PATCH 2/3] treewide: Fix function prototypes for module_param_call() Kees Cook
2017-10-18 2:04 ` [PATCH 3/3] module: Do not paper over type mismatches in module_param_call() Kees Cook
2017-10-18 10:12 ` [RESEND][PATCH 0/3] " Arnd Bergmann
2017-10-18 14:21 ` Kees Cook
2017-10-30 21:20 ` Kees Cook
2017-10-31 14:46 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508292283-140003-1-git-send-email-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).