From: David Howells <dhowells@redhat.com> To: linux-security-module@vger.kernel.org Cc: gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org, matthew.garrett@nebula.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, jforbes@redhat.com Subject: [PATCH 17/27] acpi: Disable APEI error injection if the kernel is locked down Date: Thu, 19 Oct 2017 15:52:41 +0100 Message-ID: <150842476188.7923.14340260837257633120.stgit@warthog.procyon.org.uk> (raw) In-Reply-To: <150842463163.7923.11081723749106843698.stgit@warthog.procyon.org.uk> From: Linn Crosetto <linn@hpe.com> ACPI provides an error injection mechanism, EINJ, for debugging and testing the ACPI Platform Error Interface (APEI) and other RAS features. If supported by the firmware, ACPI specification 5.0 and later provide for a way to specify a physical memory address to which to inject the error. Injecting errors through EINJ can produce errors which to the platform are indistinguishable from real hardware errors. This can have undesirable side-effects, such as causing the platform to mark hardware as needing replacement. While it does not provide a method to load unauthenticated privileged code, the effect of these errors may persist across reboots and affect trust in the underlying hardware, so disable error injection through EINJ if the kernel is locked down. Signed-off-by: Linn Crosetto <linn@hpe.com> Signed-off-by: David Howells <dhowells@redhat.com> cc: linux-acpi@vger.kernel.org --- drivers/acpi/apei/einj.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c index b38737c83a24..6d71e1e97b20 100644 --- a/drivers/acpi/apei/einj.c +++ b/drivers/acpi/apei/einj.c @@ -518,6 +518,9 @@ static int einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2, int rc; u64 base_addr, size; + if (kernel_is_locked_down("ACPI error injection")) + return -EPERM; + /* If user manually set "flags", make sure it is legal */ if (flags && (flags & ~(SETWA_FLAGS_APICID|SETWA_FLAGS_MEM|SETWA_FLAGS_PCIE_SBDF)))
next prev parent reply index Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-19 14:50 [PATCH 00/27] security, efi: Add kernel lockdown David Howells 2017-10-19 14:50 ` [PATCH 01/27] Add the ability to lock down access to the running kernel image David Howells 2017-10-20 23:19 ` James Morris 2017-10-19 14:50 ` [PATCH 02/27] Add a SysRq option to lift kernel lockdown David Howells 2017-10-19 17:20 ` Randy Dunlap 2017-10-19 22:12 ` David Howells 2017-11-07 17:39 ` Thiago Jung Bauermann 2017-11-07 22:56 ` David Howells 2017-10-19 14:50 ` [PATCH 03/27] Enforce module signatures if the kernel is locked down David Howells 2017-10-20 6:33 ` joeyli 2017-10-20 23:21 ` James Morris 2017-10-27 18:48 ` Mimi Zohar 2017-10-30 17:00 ` David Howells 2017-10-30 17:52 ` Mimi Zohar 2017-11-02 17:22 ` David Howells 2017-11-02 19:13 ` Mimi Zohar 2017-11-02 21:30 ` David Howells 2017-11-02 21:41 ` Mimi Zohar 2017-11-02 22:01 ` David Howells 2017-11-02 22:18 ` Mimi Zohar 2017-10-19 14:51 ` [PATCH 04/27] Restrict /dev/mem and /dev/kmem when " David Howells 2017-10-20 6:37 ` joeyli 2017-10-20 23:21 ` James Morris 2017-10-19 14:51 ` [PATCH 05/27] kexec: Disable at runtime if " David Howells 2017-10-20 6:38 ` joeyli 2017-10-20 23:22 ` James Morris 2017-10-19 14:51 ` [PATCH 06/27] Copy secure_boot flag in boot params across kexec reboot David Howells 2017-10-20 6:40 ` joeyli 2017-10-19 14:51 ` [PATCH 07/27] kexec_file: Disable at runtime if securelevel has been set David Howells 2017-10-20 23:26 ` James Morris 2017-10-23 15:54 ` Mimi Zohar 2017-10-26 7:42 ` joeyli 2017-10-26 14:17 ` Mimi Zohar 2017-10-27 19:30 ` Mimi Zohar 2017-10-27 19:32 ` Mimi Zohar 2017-10-28 8:34 ` joeyli 2017-10-29 22:26 ` Mimi Zohar 2017-10-30 9:00 ` David Howells 2017-10-30 12:01 ` Mimi Zohar 2017-10-26 15:02 ` David Howells 2017-10-26 15:46 ` Mimi Zohar 2017-10-30 15:49 ` David Howells 2017-10-30 16:43 ` Mimi Zohar 2017-11-02 17:00 ` David Howells 2017-10-26 14:51 ` David Howells 2017-11-02 17:29 ` David Howells 2017-10-19 14:51 ` [PATCH 08/27] hibernate: Disable when the kernel is locked down David Howells 2017-10-20 6:40 ` joeyli 2017-10-19 14:51 ` [PATCH 09/27] uswsusp: " David Howells 2017-10-20 6:41 ` joeyli 2017-10-20 23:29 ` James Morris 2017-10-19 14:51 ` [PATCH 10/27] PCI: Lock down BAR access " David Howells 2017-10-20 6:42 ` joeyli 2017-10-19 14:51 ` [PATCH 11/27] x86: Lock down IO port " David Howells 2017-10-20 6:43 ` joeyli 2017-10-19 14:52 ` [PATCH 12/27] x86/msr: Restrict MSR " David Howells 2017-10-20 6:43 ` joeyli 2017-10-20 18:09 ` Alan Cox 2017-10-20 20:48 ` David Howells 2017-10-21 4:39 ` joeyli 2017-10-23 14:49 ` David Howells 2017-10-25 14:03 ` joeyli 2017-10-19 14:52 ` [PATCH 13/27] asus-wmi: Restrict debugfs interface " David Howells 2017-10-20 6:44 ` joeyli 2017-10-19 14:52 ` [PATCH 14/27] ACPI: Limit access to custom_method " David Howells 2017-10-20 6:45 ` joeyli 2017-10-19 14:52 ` [PATCH 15/27] acpi: Ignore acpi_rsdp kernel param when the kernel has been " David Howells 2017-10-20 6:45 ` joeyli 2017-10-19 14:52 ` [PATCH 16/27] acpi: Disable ACPI table override if the kernel is " David Howells 2017-10-20 6:46 ` joeyli 2017-10-19 14:52 ` David Howells [this message] 2017-10-20 6:47 ` [PATCH 17/27] acpi: Disable APEI error injection " joeyli 2017-10-19 14:52 ` [PATCH 18/27] bpf: Restrict kernel image access functions when " David Howells 2017-10-19 22:18 ` Alexei Starovoitov 2017-10-20 2:47 ` joeyli 2017-10-20 8:08 ` David Howells 2017-10-20 15:57 ` jlee 2017-10-20 23:00 ` Alexei Starovoitov 2017-10-23 14:51 ` David Howells 2017-10-20 16:03 ` David Howells 2017-10-20 16:43 ` jlee 2017-10-23 14:53 ` David Howells 2017-10-25 7:07 ` joeyli 2017-10-19 22:48 ` David Howells 2017-10-19 23:31 ` Alexei Starovoitov 2017-11-09 17:15 ` David Howells 2017-10-19 14:52 ` [PATCH 19/27] scsi: Lock down the eata driver David Howells 2017-10-19 14:53 ` [PATCH 20/27] Prohibit PCMCIA CIS storage when the kernel is locked down David Howells 2017-10-19 14:53 ` [PATCH 21/27] Lock down TIOCSSERIAL David Howells 2017-10-19 14:53 ` [PATCH 22/27] Lock down module params that specify hardware parameters (eg. ioport) David Howells 2017-10-19 14:53 ` [PATCH 23/27] x86/mmiotrace: Lock down the testmmiotrace module David Howells 2017-10-19 14:53 ` [PATCH 24/27] debugfs: Disallow use of debugfs files when the kernel is locked down David Howells 2017-10-19 14:53 ` [PATCH 25/27] Lock down /proc/kcore David Howells 2017-10-21 2:11 ` James Morris 2017-10-23 14:56 ` David Howells 2017-10-19 14:53 ` [PATCH 26/27] efi: Add an EFI_SECURE_BOOT flag to indicate secure boot mode David Howells 2017-10-21 2:19 ` James Morris 2017-10-23 14:58 ` David Howells 2017-10-19 14:53 ` [PATCH 27/27] efi: Lock down the kernel if booted in " David Howells 2017-10-19 22:39 ` [PATCH 00/27] security, efi: Add kernel lockdown David Howells 2017-10-23 14:34 ` [PATCH 04/27] Restrict /dev/mem and /dev/kmem when the kernel is locked down David Howells 2017-10-24 10:48 ` Ethan Zhao 2017-10-24 14:56 ` David Howells 2017-11-02 22:01 ` [PATCH 00/27] security, efi: Add kernel lockdown Mimi Zohar 2017-11-02 22:04 ` Firmware signing -- " David Howells 2017-11-02 22:10 ` Mimi Zohar 2017-11-07 23:07 ` Luis R. Rodriguez 2017-11-08 6:15 ` AKASHI, Takahiro 2017-11-08 19:46 ` Luis R. Rodriguez 2017-11-09 1:48 ` AKASHI, Takahiro 2017-11-09 2:17 ` Mimi Zohar 2017-11-09 4:46 ` AKASHI, Takahiro 2017-11-10 13:37 ` Mimi Zohar 2017-11-11 2:32 ` Alan Cox 2017-11-13 11:49 ` Mimi Zohar 2017-11-13 17:42 ` Luis R. Rodriguez 2017-11-13 21:08 ` Alan Cox 2017-12-04 19:51 ` Luis R. Rodriguez 2017-12-07 15:32 ` Alan Cox 2017-11-13 21:44 ` David Howells 2017-11-13 22:09 ` Linus Torvalds 2017-11-14 0:20 ` Alan Cox 2017-11-14 12:21 ` Mimi Zohar 2017-11-14 12:38 ` Greg Kroah-Hartman 2017-11-14 13:17 ` Mimi Zohar 2017-11-14 17:34 ` Linus Torvalds 2017-11-14 19:58 ` Matthew Garrett 2017-11-14 20:18 ` Linus Torvalds 2017-11-14 20:31 ` Matthew Garrett 2017-11-14 20:35 ` Linus Torvalds 2017-11-14 20:37 ` Matthew Garrett 2017-11-14 20:50 ` Luis R. Rodriguez 2017-11-14 20:55 ` Matthew Garrett 2017-11-14 22:14 ` James Bottomley 2017-11-14 22:17 ` Matthew Garrett 2017-11-14 22:31 ` James Bottomley 2017-11-14 22:34 ` Matthew Garrett 2017-11-15 11:49 ` Mimi Zohar 2017-11-15 17:52 ` Luis R. Rodriguez 2017-11-15 19:56 ` Mimi Zohar 2017-11-15 20:46 ` Luis R. Rodriguez 2017-11-16 0:05 ` Mimi Zohar 2017-12-05 10:27 ` Pavel Machek 2017-12-07 23:02 ` Luis R. Rodriguez 2017-12-08 17:11 ` Alan Cox 2017-11-10 1:46 ` Luis R. Rodriguez 2017-11-10 13:45 ` Mimi Zohar 2017-11-13 18:50 ` Luis R. Rodriguez 2017-11-13 19:08 ` Luis R. Rodriguez 2017-11-08 20:01 ` Mimi Zohar 2017-11-08 20:09 ` Luis R. Rodriguez 2019-02-28 21:28 [PULL REQUEST] Lock down patches Matthew Garrett 2019-02-28 23:11 ` [PATCH 01/27] Add the ability to lock down access to the running kernel image Matthew Garrett 2019-02-28 23:11 ` [PATCH 17/27] acpi: Disable APEI error injection if the kernel is locked down Matthew Garrett 2019-03-06 23:58 [PULL REQUEST] Kernel lockdown patches for 5.2 Matthew Garrett 2019-03-06 23:59 ` [PATCH 17/27] acpi: Disable APEI error injection if the kernel is locked down Matthew Garrett
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=150842476188.7923.14340260837257633120.stgit@warthog.procyon.org.uk \ --to=dhowells@redhat.com \ --cc=gnomes@lxorguk.ukuu.org.uk \ --cc=gregkh@linuxfoundation.org \ --cc=jforbes@redhat.com \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=matthew.garrett@nebula.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git